grouzen / play2-jsend Goto Github PK

Jsend.error works properly when called with objs containing some value:

JSend.error("My error message.", None, Some(Seq("foo" -> "bar")))

Though, when I pass objs as None, such as in:

JSend.error("My error message.", None, None)

or

JSend.error("My error message.")

I get the following compile error:

diverging implicit expansion for type play.api.libs.json.Writes[A] starting with object StringWrites in trait DefaultWrites

Using JSend.error with an empty objs is the most common usage. Thus this bug is rather critical.
It happens with Play 2.5 and Scala 2.11, I did not test with earlier versions.

It would be much handy if you could publish this library into some code repo such as Maven Central.

Right now the only way to use it is to publish it into the local repo. This adds complexity to build scripts and CI environments.

Currently all test are failing with an error similar to this:

play2-jsend/test/src/main/scala/play/api/libs/json/JSendSpec.scala:17: type mismatch;
  found   : play.api.libs.json.JsString
  required: play.api.libs.json.JsLookupResult
       (json \ "status") must be equalTo(JsString("success"))

I don't know what type we really want, and thus what should be the proper solution.