grumd / genshin-artifact-farm-calculator Goto Github PK

I am currently writing my own artifact sim with probabilities in preparation for my math and computer science finals and happened to stumble across your project. I checked the files and noticed that you calculate the chance for getting the desired artifact in one run (20 resin) the following way:
chance = 1 - (1- chance) * (1 - 0.07 * chance)
This confused me, as I first calculated the chance manually using chance = chance * 1.07 and got a different result than you, so I ran a simulation to confirm the matter:
I created 100 million random artifacts with a 7% chance to create two at once and logged the amount of Flowers I got: 21400206
This proves that the chance for getting an artifact with chance c in one run (20 resin) with a chance of 7% for double artifacts is indeed chance = chance * 1.07 instead of the formula you used.

This new formula can also be proven the following way:
0.93 * chance + 0.07 * (2*chance*(1-chance)+2*(chance)²)

• 93% chance to get 1 artifact (0.93*chance)
• 7% chance to get 2 artifacts (0.07*...)
  -> getting at least one desired artifact from the drops: 2 * chance * (1-chance) + 2 * chance²
  Simplifying this formula leads to chance = chance * 1.07 and calculates a probability of 21.4% for the aforementioned example (with chance = 0.2)

Probably since the addition of dendro.
To test it, simply use "Flower of life" and run, it should give flat 10% (or 20% for combined).
Elemental goblets display 0.535% (or 1.07%) which are the only correct values, every other % should have been the same except ATK%, DEF%, HP% for goblets.

Minor things:
The UI is written in English but the X-Axis is displayed in local language:

Would it be possible to add custom resin usage per day? In case people use fragile resins/refills or only allocate a lower resin amount per day to artifacts. Hovering gives you the resin value to manually divide but this would be more convenient.

When I'm looking for an artifact to use, my selection process is

1. Correct main stat
2. At most one 'bad' substat (e.g. DEF(%), or HP(%) if not desired for the character)
3. Send it to the moon and hope that 'bad' substat doesn't level (oh look at that, it did)

Could we get a way to express in your calculator "no defense substats" or similar? That would be really useful for me

Hi, I'm looking into creating an application that utilizes the probabilities of given artifact rolls, and stumbled upon this handy tool. It would be awesome if I were able to reuse some of your logic but I noticed that this repo has no license. Are you interested in allowing for such modification/reuse?

I couldn't find a LICENSE file in here, so I wanted to check: would you have any objection to someone forking and deploying this?

This tool has been very helpful, but there are a couple of additional features I'm missing (mainly around making it easier to share results).