Comments (2)
Thanks! Works for me in 1.7.0.
from octoprint-webcamtab.
@malnvenshorn ! Hey man! You're alive! Yay \o/
I have no idea why I missed your post way back in Oct last year. :-( It's been happening a lot with me lately. Apologies. Seems I've also done a disappearing act for months. Gosh. (I've been struggling in lots of ways, actually. But hey.)
You know ... I think I might have noticed an issue there. I recall reading, "works for me" as a reply, some time after I posted the last update. I guess I didn't bother replying because I had already posted the update? I sure as heck SHOULD have and certainly would have if I even noticed it was YOU! My bad. I'm so useless sometimes. sigh
Anywho ...
As it happens, after learning OctoPrint 1.8 is getter close, I sat down yesterday to see about doing things a different way myself. The main part of that appears to be about the same as your new solution. Hell, you'll probably think I stole the idea from you. LOL Actually, I was in the process of executing the pull request at the registry repo when I noticed, "Isses: 1" up there.
My just rewritten v0.3.0 uses .bind(self.control)
— perhaps unnecessarily, since your works fine I presume. Now I think of it, OctoPrint probably mashes all the listed dependencies into the same scope, which would explain why the keyboard control still work. So I guess the binding was indeed not needed ... but I won't fix what aint broken.
Do you want to take back maintainer status? We tried contacting you (over a month or so iirc) before "taking over". I never dreamed of doing such a thing but I really liked WebcamTab and didn't want to keep the required changes at the time all to myself. It's the only OctoPrint plugin I have anything to do with. I never would have known how to write the thing myself — or rather, bothered learning how, not to mention coming up with the idea!
Because you are still listed as an original author, you should be able to simply fork the plugins repo and submit a PR without issue.
Of course, if there's something in my code you like go ahead and take it -- or remove anything dumb. No worries at all.
Or if you prefer to leave things as they are, obviously just let me know. Thanks.
Bryan
from octoprint-webcamtab.
Related Issues (13)
- Tab appears but no webcam, same as original version under OctoPrint 1.5 HOT 13
- Wont update and tab not working...
- Feature request: Disable keyboard control on webcam tab HOT 1
- Error with OctoPrint 1.7.0rc3 - tab created, but camera view not moved HOT 9
- 1.9.0 breaks things HOT 11
- Error while updating HOT 6
- the stream is removed from the control tab but no webcam tab HOT 2
- Works excellent, thank you!
- JS error HOT 3
- Error in webcam update HOT 1
- 1.6 compatibility HOT 9
- Problem to update to 0.2.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octoprint-webcamtab.