1.9.0 breaks things about octoprint-webcamtab HOT 11 CLOSED

This is now the issue as 1.9.0 is officially out of RC phase.

from octoprint-webcamtab.

i pushed a fix for this issue it just needs to be approved and released (I'm a sub-beginner-noob in github matters so hopefully did that right)

from octoprint-webcamtab.

This wasn't my plugin, so by all means you keep it.
Oh! My bad. Dang. Can't say I didn't try. :P

from octoprint-webcamtab.

Confirmed working without issue on my system with all my other plugins. Yay!

from octoprint-webcamtab.

Your patch works perfectly in 1.9.0 and your PR looks perfectly fine. Just got to get @gruvin to merge it now and bump the version and release.

from octoprint-webcamtab.

@gruvin i'm a complete idiot when it comes to github. is the release generated automatically or do i need to do anything about it? pardon my ignorance :|

from octoprint-webcamtab.

technically, you need to update the plugin_version in setup.py and then on GitHub someone with the rights create the release.

from octoprint-webcamtab.

oh. Sorry guys. Was in a hurry. I'll sort that now.

from octoprint-webcamtab.

I'll find a place to install OP 1.9 and test this properly now, after the fact and all.
@jneilliii if you'd like to take back the plugin maintenance then by all means. I only stepped in when you appeared to be unavailable for an extended time, around covid 'n'all if you know what I mean. (Also, I get so many otherwise meaningless Github emails that I keep missing these ones that I care about. :/)

from octoprint-webcamtab.

This wasn't my plugin, so by all means you keep it.

from octoprint-webcamtab.

@alex1platon should be good to go now. I'm still upgrading one of my printers to 1.9.0 but have confirmed that your changes didn't break v1.8.6.

Thanks for the help! :-)

from octoprint-webcamtab.