gskinner / justaddmusic Goto Github PK

In the case where the developer wants to use audioData in an existing tick, instead of passing in an ontick handler, the audio data does not get generated.

An ontick must be set to a non-null value in order for the audioData to get populated. Not sure the best solution, maybe a manual` property on the config object or on the instance?

In Safari and Firefox (OS X) I encountered an issue with audio that loaded, but failed to decode. Currently JAM does not handle or surface this error. Ideally it would console.error, or dispatch an event.

Here is a file that failed. It is 44kbps. When it was re-encoded for 48kbps, it worked fine, so that could be the cause. The error happens specifically when the file is loaded in an iframe, and it seemed to work fine when loaded in its own window.

Receiving an RTE when playing default music.

TypeError: undefined is not an object (evaluating 'prevO[key]')
_loop — JustAddMusic.js:336
_calculate — JustAddMusic.js:343
tick — JustAddMusic.js:205

Happened in all browsers on OSX using this demo