gt-emorymindlab / rodent-whole-brain-preprocessing-recipe Goto Github PK

Hello Sam
Thanks for sharing your codes and it was very useful for us to try your sample data before testing our data. One question, I have is, what is the output file of the final processing. Is there any way to display the resting-state connectivity on the images in addition to the FC map? Please let me know.
Thanks
Ned

All revisions from first review.

Hi
I tried running my data set on the second script, and the following error was encountered.

./preproc_script_mouse2.sh: line 250: [: -eq: unary operator expected

Parse error: bad expression
:1

Is this something to worry about or does it change the final results? Is this bash-specific?
Please let me know
Thanks
Ned

There are a few things we should do to ensure other people can use and work on this codebase without issues.

1. Restrict the main branch, only allowing merges after a PR has been reviewed by maintainers
2. Release official version(s) of the code
3. Review open source licensing
4. Remove old stale branches

cc @nxu25

Bugfix for iter_nuis infinite loop with multiple fldir values.

Problem:

• Currently preproc_script_2.sh will run infinitely if multiple fldir directories are specified.

Proposed Solution:

• Fix all loop iterators in the nuisance regressor functions so they are not reset each time nuis_args is parsed.