gtgalone / prompt_dialog Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 12.0 58 KB

Prompt Dialog Widget for Flutter(JS-LIKE).

Home Page: https://pub.dev/packages/prompt_dialog

License: MIT License

Dart 100.00%

prompt_dialog's People

Contributors

Stargazers

Watchers

Forkers

shadyboshra2012 tpillow joachimvalente chandra-deb albertozurini koehler1000 gnilron frfgccevcv dakamojo eduardocosobr aoliman

prompt_dialog's Issues

Press Enter returns the value

In the Javascript prompt, pressing Enter will return the value. In this project, pressing Enter will unfocus the textbox.

For now, the workaround is to press Tab, Tab, Enter.

Btw, this is not urgent. I'm posting this to keep track of the issue.

Inactive InputConnection after second or more calls

I am testing your basic example and I see that when I start and open dialog so everything is OK.
But when I close and open it again so into Debug log it write:

W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection

And it is writting there everytime when the dialog is opened.
It looks like that first input wasn't closed correctly and there is still some inactive InputConnection
Can you fix it please? My logs are quite messy when I use promp_dialog more times..:

Debug service listening on ws://127.0.0.1:46217/6YiWkl9qWqs=/ws
Syncing files to device Android SDK built for x86...
I/zygote  (16204): Do partial code cache collection, code=30KB, data=28KB
I/zygote  (16204): After code cache collection, code=30KB, data=28KB
I/zygote  (16204): Increasing code cache capacity to 128KB
I/flutter (16204): null
W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection
I/flutter (16204): null
W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): beginBatchEdit on inactive InputConnection
W/IInputConnectionWrapper(16204): getTextBeforeCursor on inactive InputConnection
I/zygote  (16204): Do partial code cache collection, code=57KB, data=48KB
I/zygote  (16204): After code cache collection, code=57KB, data=48KB
I/zygote  (16204): Increasing code cache capacity to 256KB
W/IInputConnectionWrapper(16204): getTextAfterCursor on inactive InputConnection
W/IInputConnectionWrapper(16204): getSelectedText on inactive InputConnection
W/IInputConnectionWrapper(16204): endBatchEdit on inactive InputConnection
Application finished.

Set to autofocus: true by default

Thanks for implementing the autofocus option! It'd be even more useful if it was set to true by default, since most users will want to type right away, instead of tapping the text box.

isSelectedInitialValue not work

isSelectedInitialValue set true, but not work.
and add all properties of TextField please

initialValue not returned unless textchange

When setting initialValue to something and then using the prompt without editing that initialValue, pressing ok will return null unless you do some typing.

I think having a value as null but an initialValue set this prompt should return initialValue "onOK"

Selection of initial value

Hi, love your widget!

How to select all text of initial value show on display of the prompt, so user erases initial value as soon as entering a character?

Instead of ...

All initial input selected like ...

Cheers,

Add onCancel callback

Hi,

I really liked your package.

Please add onCancel callback. So that we can do something when that happens.

installing both prompt and confirm dialog causing prompt to close immediately

when i installed https://github.com/gtgalone/confirm_dialog, it works fine, but the prompt dialog disappear quickly

when i uninstalled confirm_dialog, prompt dialog works normally

please help thank you for this wonderful plugin

Add text input type support

Please input type argument so as to render the keyboard appropriately
e.g email, number, text

"isSelectedInitialValue" is never used

Please add the folloing code to initState() to make this field beneficial:

if (widget.isSelectedInitialValue) {
  controller.selection = TextSelection(baseOffset: 0, extentOffset: value?.length ?? 0);
}

Trying to get validator to work.

Thanks for the nice clean widget. I'm trying to get the validator to work. It may be that the validator message is displaying but the dialog still closes immediately.

So I tried the sample custom_message.dart.

First, the sample has some minor issues. The prompt widget needs a context that is a descendent of the MaterialApp. So I wrapped the Center Widget with a Builder for simplicity. Second I got some error related to the obscureText so I commented that out. Here is my updated sample.

import 'package:flutter/material.dart';

import 'package:prompt_dialog/prompt_dialog.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Welcome to Flutter',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Welcome to Flutter'),
        ),
        body: Builder(builder: (context) {
          return Center(
            child: TextButton(
              onPressed: () async {
                return print(await prompt(
                  context,
                  title: const Text('Would you like to remove?'),
                  initialValue: 'Sure',
                  isSelectedInitialValue: false,
                  textOK: const Text('Yes'),
                  textCancel: const Text('No'),
                  hintText: 'Please write reason',
                  validator: (String? value) {
                    if (value == null || value.isEmpty) {
                      return 'Please enter some text';
                    }
                    return null;
                  },
                  minLines: 2,
                  maxLines: 3,
                  autoFocus: false,
                  // obscureText: true,
                  obscuringCharacter: '*',
                  showPasswordIcon: true,
                  barrierDismissible: true,
                  textCapitalization: TextCapitalization.words,
                ));
              },
              child: const Text('Prompt Dialog'),
            ),
          );
        }),
      ),
    );
  }
}

When running this sample the validator message is never presented to the user.