gthole / drink-stash Goto Github PK

I tried to add a new book - Beta Cocktails. I wanted it to be private so did not click the "Public" button but got two books created (26 and 27)

I created a new tag - "mocktail" - and I can't seem to add it to the drink "Steph's Request". I also don't know if the intention was that you could add tags right from the drink add/edit screen but that doesn't work.

The app seems to be using a conversion of 4oz = 1 cup (see screenshots)

• New comments from other users
• New recipes added

Show a summary of lists that a recipe has been added to on the recipe page.

• Booze (Alcohols)
• Bitters
• Syrup (Simple, Honey, Tea, etc.)
• Juice (Lime, Lemon, etc.)
• Kitchen Staples (Egg, Mint, etc.)
• Ungrouped (Anything untyped)

Break up the "cabinet" view into sub-views with checkboxes instead of a search form. That way people can look over the list to see what's available to check off and select based on what they have and where.

See screenshot - both you and I have favorited "Santa Rosella" and yet it only shows 1 heart in the left panel.

Possibly irrelevant if you are deprecating favorites.

Should be able to flag a recipe as a "favorite" and then filter by favorites.

Unless I'm missing something, I can't remove a recipe from a list.

If I go to my lists (https://drinks.litbt.net/users/grace/lists) and click "Edit" nothing happens.

• Some kind of distance metric between drinks
• Compare against user ratings
• Suggestions view

• Tags should be manually entered
• Anyone can add / remove tags
• The list of available tags should be predefined by admins
• Recipe List view should support filtering by tags, a different mechanism from searching
• Tags should be displayed on the Recipe List items, alongside or after the ingredient list.
• Tags can be added to a Recipe in the Create/Edit View or on the Recipe Details view.

OK, perhaps this is more a preference than a bug, but the recently added font changes enhance the amount of an ingredient while minimizing and fading the actual unit of measure, meaning it is easier to make a mistake in amounts.

Users should be able to log in with their email address as well as their username.

User who added/created can set a permission level to control who else can see the recipe.

Roughly:

• Public: anyone
• Protected: anyone with a login
• Shared: "friends only"
• Private: user only

In list detail (probably in an "edit" view), add a selection box next to each recipe that allows for some action to be performed on the selected. Possible actions:

• Delete all selected
• Move all to a new list (Which then prompts to create new list name) or existing list
• Copy all to new/existing lists (leaves them in the current list)
• Randomly choose a drink for me to make from the selected options (for when you don't want to choose)

(It's just so ugly.)

Really could use some design help with this (and the rest of the site), but I can take a stab at making it a bit better on my own.

This could be complete user error but twice now I have deleted comments I meant to edit because the position of the "Delete" in the Edit comment page is where I would instinctively click to approve (lower right, i.e. where the "Submit new issue" button is in this github comment.

I tried to add "Ab Fab" to my Favorites and also to "Wanna Try That" and got a "That doesn't look right" error, and the drink did not add. I assume this is related to the Books rollout.

Things that call for the empty unit (usually whole egg, egg whites) are being rejected by the server since the UOM change. Need to modify the server validation to let '' units be accepted. (Really puts a kink in the egg-based recipe additions.)

Schema

• User (FKey)
• Recipe (FKey)
• Text
• Rating

It would be really helpful to have a total at the top of the recipe filter that tells you how many recipes were returned after each filter (starting by showing the total recipes when you first land on the recipes page - also impressive!) Given how many recipes we have now it would be good to know how much more filtering you need to do to get to a usable list, and it's not immediately apparent after your initial search.

Improvements on list creation:

1. It would be great to be able to do an initial search (i.e. NOT lime juice, mezcal), swipe to clear out the list and then save the remaining .recipes as a list
2. Add a "swipe right to add to list" feature for mobile
3. When adding to a list from the recipe screen you should have an option to "Create New List"

• Allow users to upload their profile images, and ditch Gravatar.
• Let users edit name and email in the app.
• Add change password form.
• Self description field? Like "about"? Everyone hates writing those, though.

(Alternately, could support OAuth so users can log in via FB/Google/Twitter/Github/etc)

Since the last noted activity feed issues (when it wasn't refreshing and you corrected it) I don't think I had verified the feed in mobile - the last feed item showing there for me is Jersey Isle Julep, which was added 11 days ago. Desktop feed seems fine.

I have tried logging in and out, and refreshing. I haven't cleared cache completely, I'm not entirely sure how to do that in mobile, but can if desired.

Drink Stash sounds like exactly what I'm looking for, but the very last part of the setup process—the provisioning step—is blocking me. I feel so teased!

See, I use a Synology DS218+ as my home server, and it comes with a (mostly) convenient app to manage Docker. It's great for finding, downloading, deploying, and managing containers. This is a convenience for seasoned Docker pros, but it also makes the world of Docker apps more accessible to people for whom it would otherwise be just a bit too complicated—or at the very least, it spares them from however many hours of headaches it might take for them to teach themself. It's pretty great.

However, I can't figure out how to pass CLI commands to the containers. This usually isn't an issue, but that's how the Drink Stash provisioning is done. I've technically got Drink Stash installed, but I'm unable to create any users.

With other apps I've set up, what I do is install the container, use my browser to connect to my DS218+ using whichever port I configured for the app, and then I'm greeted by the app telling me that I need to make the first user. This works great, so if you are considering requests, I'd really appreciate it if you made a way to do the initial provisioning like this.

Thank you for reading.

P.S. I just noticed that you're looking for design help. I'm an interaction designer finishing my master's thesis. I need to make a new portfolio because my current portfolio is absolutely ancient. I made it during my junior year of undergrad, which was quite some time ago. So, I want to do some new projects to show what I've learned since then (here's a PDF of my current resumé so you can at least get an idea). Maybe we can help each other?

Now that "Favorites" are lists, it would be nice to be able to filter the recipes by what has been added to a "Favorites" lists.
Other possibilities:

• Filtering by "any recipe that has been added to a list"
• Filtering by a particular list (maybe an alternative to sharing lists?)
• Filtering by a person who has listed a drink ("show me everything that Greg has added to a list")

Suggestion based on recent used (and seeing your comments on 370 Comm Ave):
Create a "clone recipe" feature that allows people to duplicate, make the changes, and create a new name. Because it would be duplicated off an existing recipe, if that parentage/breadcrump is tracked somehow you basically start to build a network of variations that could lead to other features (i.e. a sidebar link that shows what it was cloned from, or shows what a base recipe has been cloned to, ways to make suggestions)

Include gravatar md5 hashes on user endpoint for image displays.

Adding a recipe is now throwing an error, probably due to blocks.

I added two new books, Three Ingredient Cocktails and Smuggler's Cove, and they aren't showing up in the add recipe view.

Also, I thought you used to be able to add new books right from the Add Recipes view...I don't think only admins should be able to add new books as it discourages other people adding recipes.

The lists themselves are quite hidden. I did find them (in the profile) but ideally lists would be linked from several places (the main page, the recipe section).

It would be nice to be able to administer units of measures (i.e. add "rinse") in the admin console.

There seems to be a regression with the latest push (I assume related to button position trading) that when tabbing through the "Add new recipe" screen, the first button highlighted after writing the description is "Save and New" on the right, followed by "Save" on the left, switching the intuitive left-to-right tab positioning.

Specifically I am thinking about when adding a recipe where the name already exists, making it clear that is the case, rather than just throwing a generic error. Ideally, it might even recognize the dupe before you've entered the whole recipe!

Also, I am getting an error when trying to enter something that is listed as "1/6". Any version of .1666... that I enter gets an error, i'm assuming because of the conversion to fractions. However, I just get a generic error.

All low priority, clearly!

It's difficult to know that the drink has been added to a list. I think that maybe a check box when selecting the list might be clearer than highlighting.

Feature request from Lillian: ability to see which of my lists (if any) a drink is in when I’m browsing recipes (so I can know if a drink is already added to one of my “want to try” lists without having to click in)

A recent update (perhaps preferencing the most popular selection when typing an ingredient?) has made it so that ingredient autofill is basically nonfunctional. If I type "Cam" Campari comes up in the suggestion list but if I either press enter or actually select "Campari" with the mouse, nothing populates the ingredient box. This is a regression which means all data entry is completely manual (no autofill).

In the edit drink view:
Currently if you enter a tag that doesn't exist you can save but it doesn't actually save, and also doesn't let you know that the reason is because that tag doesn't exist. This is confusing to the user, and the free text field leads you to think you can enter whatever you want there.

This is low priority.

I was entering recipes and mistakenly entered a bad quantity. When I tried to save it threw an error which was great because it showed me what to fix. But now the error message shows up on all subsequent recipe entries. It doesn't block anything so it's very low priority.

It'd be prettier if the UI routed on a slug of the drink name instead of the id.

e.g. /recipes/the-last-word instead of /recipes/385

Change from clicking "x" after adding to a list to "Save" or "Done". With an updated list summary on the recipe page this will help the user confirm they have successfully added to the lists they intend.

Very low priority.

It should, of course, contain an egg, and jam.

When adding new recipes you must choose a book, but if that book is also a source then you have to enter the book again as a the source. This makes sense when it is not an actual Book (like book = Grace Public/source = Grace + Date) but maybe the book name could auto populate in the source, but with the ability to overwrite it?

Allow for portion changing to show the proportions for large format versions.

When creating a new user, the app should automatically send a welcome email with a link to the set your password.

Users should only be able to edit themselves via the API. Email address should not be returned on the endpoint.

We should start to think about how people filter down to the drink they want to make, and potentially, to save drinks for later. Our new user suggested swiping, his notes on this topic:

I really like this as a mobile app, so yeah, anything that can utilize those gestures would be super helpful. For instance, if I search for something on Kindred Cocktails (on desktop) and get 30 recipes back, I will generally open them all in new tabs, then go through and close the tabs I decide against, leaving me with a shorter list I can whittle down. The swiping here would make that super easy -- filter down to a dozen recipes and then swipe away half of them quickly because they contain ingredients I don't like or don't have. You could even build on that gesture later on to swipe left for adding recipes to your own lists (e.g., create a new drinks list like "party drinks" for an upcoming event, then do a recipe search and filter down results, swiping ones you like into your list. Now you have a defined menu you can pull up any time at the party.)

Maybe change the helper text for List View notes to:
Add recipe notes that will only be visible in this list.