Giter VIP home page Giter VIP logo

notenoughitems's Introduction

NotEnoughItems Unofficial - By the GTNH Team

A continuation of NotEnoughItems for 1.7.10 by the developers of Gregtech: New Horizons modpack, with features either inspired and/or backported from JustEnoughItems

We've tested this against all of the mods included in GTNH, as well as a limited set of other mods (like Reika's mods). Every effort has been made to maintain backwards compatibility, however the focus is on the mods contained in the GTNH modpack.

If you have issues with NEI outside of the GTNH modpack you may report them in the GTNH NEI GitHub.

New Features:

  • Speed
    • Uses a parallel stream to search the item list over multiple cores, resulting in 2-6x faster searches on average
    • Loads the recipe handlers in parallel
  • A textbox for search with most of the features you'd expect - moving forward, backwards, selection, etc
  • Bookmarks! Are you in the process of crafting? Bookmark it using either 'A' or configure your own key.
  • Toggle bookmark pane. Default shortcut key B. Item Subsets menu is only available if bookmarks are not visible.
  • Utility/Cheat buttons line up and wrap based on GUI size
  • ItemList is no longer regenerated from the ItemRegistry on every inventory load
  • JEI (Or Creative) Style tabs [Optional] Note: Requires explicit support to be added for an ItemStack to render, otherwise falls back to the first two letters of the handler name.
  • Tabs/Handlers are loaded from a CSV config in the JAR (or optionally from the config folder). NBT IMCEvents registerHandlerInfo and removeHandlerInfo are available for mod authors to add handler information, using the same fields as the CSV file
  • @[Mod]->[item] searching. ex: @Mod.gregtech->iron ingot
  • Cycle between Recipe, Utility, and Cheat mode by ctrl clicking on the Wrench Icon
  • GT5u Tools/Items and GT6 tools should now properly work with the Overlay Recipe Transfer

Other items of note:

  • Remove TMI style
  • Removed inventory Load/Save state

License

GTNH Modifications Copyright (c) 2019-2024 mitchej123 and the GTNH Team

Licensed under LGPL-3.0 or later - use this however you want, but please give back any modifications

Parts inspired/borrowed/backported from JEI under the MIT License.

Originial code Copyright (c) 2014-2015 mezz and was licensed under the MIT License.

notenoughitems's People

Contributors

asdflj avatar balthild avatar bombcar avatar caedis avatar chicken-bones avatar d-cysteine avatar dream-master avatar eigenraven avatar embeddedt avatar ghostflyby avatar glease avatar glodblock avatar kiwi233 avatar linyor avatar makamys avatar miozune avatar mitchej123 avatar nilau1998 avatar polarite avatar prometheus0000 avatar quarri6343 avatar slprime avatar socolio avatar theonly1iknow avatar thevikingwarrior avatar timeconqueror avatar toltol avatar vexatos avatar wlhlm avatar yannickmg avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

notenoughitems's Issues

Feature Suggestion: Bookmark Locking

As many circuit components are used over and over, I tend to have them on my bookmark list, but sometimes forget that I do, and try to bookmark them again, leading to me unbookmarking and rebookmarking them, putting them in the 'wrong' order. I imagine people who have more bookmarks than I do encounter this problem even more.

Therefore I believe it would be nice if you could 'lock' either individual items or rows. Perhaps with a visual indicator, or not. Probably with another keybind.

Also, drag and drop moving/sorting would be nice if that's not hard.

Can't shift-click recipes from NEI into the tinkers table or player inventory

Which modpack version are you using?

2.1.0.4

If in multiplayer; On which server does this happen?

Zeta

What did you try to do, and what did you expect to happen?

I tried shift-clicking recipes from NEI into a tinkers crafting table and my player inventory and it wouldn't work

What happened instead? (Attach screenshots if needed)

Nothing

cant_craft_1.mp4
cant_craft_2.mp4

Oddly enough it works in AE just fine.

cant_craft_3.mp4

Can only use the right three spots in item responder chip filter

Which modpack version are you using?

2.0.8.8

If in multiplayer; On which server does this happen?

N/A

What did you try to do, and what did you expect to happen?

Pick up an item and be able to place it in the filter for the ProjectRed Item Responder Chip.

What happened instead? (Attach screenshots if needed)

Item ejects onto ground

What do you suggest instead/what changes do you propose?

Let me place the item in the Item Responder Chip Filter.

It looks like because the "filter" dialog is only a pop up on top of the regular dialog, only the spots on the pop up dialog that overlay the bottom dialog work. Any spots on the pop up dialog that don't overlay the bottom dialog functionally don't exist, which is why items drop on the ground when trying to place an item in that spot.

I'm going to try and see if this reproduces outside of GT:NH next, as well as see if there's a more recent version of projectred out there that doesn't have this problem.

Cannot craft soft mallet

Hey, for some reason I cannot craft a wooden soft mallet. Doesn't matter using the same type of wood or multiple ones, also checked by clicking U on the type of wood I was using and then waiting until every material was correct.

[2.1.0-GTNHA-beta] Bookmark icons scales badly

With GUI Scale Auto and 1920×1080 screen, the toggle bookmarks icon renders very badly compared to the options icon:

image

Instead I propose you use these not up-scaled:

16×16 pixels icons:
image

Compared to the current borked pre-scaling, these would scale as fairly as the wrench option icon:

image

If i was to fast search in nei always the same error happend

[19:53:14] [Client thread/DEBUG] [NotEnoughItems/]: Searching for splicer
[19:53:17] [Client thread/INFO] [NotEnoughItems/]: FindFuels took 55.64 ms
[19:53:18] [Client thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:-1]: java.util.concurrent.ExecutionException: java.lang.NullPointerException
[19:53:18] [Client thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:-1]:     at java.util.concurrent.ForkJoinTask.get(Unknown Source)
[19:53:18] [Client thread/INFO] [STDERR/]: [java.lang.Throwable$WrappedPrintStream:println:-1]:     at codechicken.nei.recipe.GuiUsageRecipe.openRecipeGui(GuiUsageRecipe.java:30)

Wrong handler images

Using beta3. handlers.zip

This appears to be the GT++ basic rocket engine. It should be a combustion generator/engine. I don't think there's anything you can do about the text+arrows, right?
image

Semifluid boiler fuels. Should probably be a boiler of some kind instead. I mean, you can use it in a boiler, right? It says so after all. It appears to be the GT++ semifluid generator.
image

Gas turbine fuel is using the GT++ ULV instead of the LV one.
image

Rocket engine fuel shows a rocket instead of a GT++ rocket fuel gen. Though if you want to make another handler for GC+addons to show what rocket fuels go with what rocket someone might use that? I wouldn't bother though.
image

Steam and SH steam don't show a use in the steam turbine or multi versions. I'm guessing there's no handler because there's only 1 type of fuel for these?

Suggestion: add NBT support for different bookmarks

Hello o/
I apologize in advance for my English.

What exactly do I need: just the ability to create bookmarks for the same item ID, but with different NBTs.

For example: if I want to lay a bookmark with two diamond swords, but with different enchantments. Or I need to have bottles of Thaumcraft essence on hand. Or even I just need to save a written book with important information so that I never lose it.

P.S. I hope that something can be done about it. But in any case, thanks for your time.

Suggestion: Recipe Filters

Possibly add a search bar below the NEI recipe menu which allows you to filter I/O certain items.

(search bar at bottom)
image
(filtering recipes with maps only)
image

While this may not normally yield much use, a modpack with an immense amount of alternative recipes with entirely different items could definitely have some kind of use from this. And also I hate looking at circuit recipes and cycling through the 30 different recipes to find that one recipe that I'll forget 13 times again when crafting it. At least this way you could search for one or two (or more) items in the recipe (possible separated by a comma) which filters out the recipes not containing that specific item/set of items. Also, not sure of its use, but you could also put in terms which makes it ignore recipes with certain ingredients, possibly? Also mod, NBT, tooltip, and pretty much everything that's available on the regular item catalog search bar, except it searches through recipes instead.

Maybe two extra filters called U: and M:? To represent "used in" and "made", or something along those lines? At this point, you wouldn't even have to click on the item to see what makes it, you could just use these filters, which would be pretty interesting.

Edit: corrected an image

When the `ItemPanel.resize` method will be invoked?

A mod which depends on NEI crashed with NEI 2.0. I want to fix it in that mod. That mod overrides the ItemPanel.resize method. I find that this method will be invoked frequently when I open the inventory. such as that

[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing
[17:25:05] [Client thread/INFO] [NotEnoughItems]: easy resizeing

I wonder if this is normal and when the method will be invoked.
Thanks.

[2.1.0-GTNHA-beta] Tabs and paging shall reuse creative GUI assets and layout

If tabs and paging were re-using the creative inventory assets and layout:

  • It would unify the rendering and layout.
  • Avoid loading more resources.
  • Allow a proper rendering with existing resources-packs without having to update it.

Default textures rendered creative inventory tabs;

image

Resources-pack rendered creative inventory tabs:

image

Feature Suggestion: Indexing

Pre-caching all recipes, ingredients defined in plugins like what JEI did
Hugely boosting up in-game searching and recipe lookup
(will be like a fully operational JEI backport)

Interface bug: Main subset bars overlap with items when disabling/enabling items in the sub-subsets

Like it says on the tin.
If I click on a specific item in any and all subcategories that happens to overlap with any of the main subsets ("mod"/"blocks""creative tabs" etc), it re-enables the entire subcateogry.
Here is just one of the many examples I've encountered: GT6 has a ton of item bloat. So I disabled the crucible faucet. I want to only re-enable the ceramic one.
2020-02-28_20 18 09
I do so. The moment I re-enable it, the mod thinks I have clicked the subset below it: mod, and destroys fifteen minutes of meticulous NEI filtering.
2020-02-28_20 18 28

Maybe mirror the subsets on the left, instead of the right? Or add an option to disable the bookmarks bar.
Thanks.

Suggestion: Ding sound when pack finishes loading

Not sure if, from the custom mods in GTNH, this is the most appropriate one but, having some kind of a ding song when the pack finishes loading would be amazing since it can take a while to load and its a nice way of notifying the player while he his alt-tabbed doing other things...

[2.1.0-GTNHA-beta] some tabs have no or weird icons

image
this seem to be a valid icon tho, because this is what is displayed when i hover it:
image

image
when the icon is hovered:
image

image
when the icon is hovered:
image
image
when the icon is hovered:
image

That's all i found, will update the issue if i find new ones

Not working NEI Hide feature from MineTweaker\Crafttweaker

Not working NEI Hide feature from MineTweaker\Crafttweaker at latest 1.7.10 version. At original version of NEI is working fine.

Simple scripts for sample:

import mods.nei.NEI;

NEI.hide(<ForgeMicroblock:microblock:*>);

And that just not working. Don't hide item's. Scripts is only server-side, but locating them locally doesn’t change anything

#Upd I'm test first version of fork - NotEnoughItems-1.7.10-2.0.0-beta-1-GTNH-universal.jar, and that feature is working fine on this build
#Upd2 After restart server, NEI hide feature again not working on beta1 version :). I don't know how it's working.

Suggestion: allow GT tools, motors, etc. to be used when populating crafting grid

Shift+clicking the "?" icon works to populate the crafting grid with materials for crafting a motor (or a number of other GT items, as long as they use "simple" ingredients), but not when crafting something with the motor, or anything that requires GT tools, like rotors. As far as I can tell, that is caused by the last condition in this line:

return stack1.getItem() == stack2.getItem() && stack1.getItemDamage() == stack2.getItemDamage() && ItemStack.areItemStackTagsEqual(stack2, stack1);

GT Tools use NBT tags to keep track of the materials they were made from as well as durability, so they don't "stack" with the tools shown in the recipe, and I think items like motors, conveyor belts, pumps, and such use tags to allow them to work in the disassembler, but I'm unclear on why the tags need to be strictly checked like this before moving items to the crafting table. I tried making a local build with the strict NBT tag matching commented out, and with what little testing I've done so far, it seems to work, though idk if that would break something else.

Clicking on a bookmarked item does not show recipe

I do need to press R while hovering the bookmarked item for it to show the recipe.
Left/right click interaction to show recipe and used in recipes like on the right side of NEI would be awesome.

Specially since most of the times, instead of pressing R, for some reason I actually press A, since in my brain A is the normal key to press on that side of the NEI screen and I end up removing the bookmark...

[Suggestion] JEI like MachineTabs

JEI has this useful feature of offering tabs to switch between the different recipes for machines.
JEI also has a feature where you can press U on a machine and it will not only show you the recipes including the item but also offer the recipes you can do with that machine.

Esp. with Gregtech this would be an insane QoL improvement and make it much easier for new players to find their way

Stretched NEI GUI always stretched

It doesn't not stretch when there's only one item, and there's no config for whether to stretch or not. Also none for whether to use a stretched GUI at all. Also, some people might want it centered if it's stretched. More configs.

Beta5.

[2.1.0-GTNHA-beta] NumberFormatException Crash From Null Value

Noticed my bookmarks had mysteriously disappeared and attempted to re-enable them. Got a NumberFormatException crash from a null value after pressing the button to enable bookmarks.

Crash log: https://pastebin.com/Jugi243t

Null value for bookmarksEnabled.value persists through a client reboot. Opening client.cfg shows the value as "false".
notepad++_VQY7CobN1h
However manually changing the value in the file to "true" seams to temporarily fix the problem and re-enables bookmarks until I try to click the button again. The toggle button seams to always read the value as null regardless of the .cfg.

Keybinds for Switching Between Tabs

Making an issue per request to add a keybind for switching between tabs, similar to how you can use the scroll wheel to quickly change between recipe pages. Something like shift+scroll or ctrl+scroll would be preferred for faster use.

Crash on world startup based on NEI concurrency

Which modpack version are you using?

2.1.0.0

If in multiplayer; On which server does this happen?

N/A This is SP

What did you try to do, and what did you expect to happen?

exited my world with 8 furnaces smelting magnetite and 2/3 smelting chalcopyrite. I expected to be able to load back into my world.

What happened instead? (Attach screenshots if needed)

A concurrency modification exception crashed my game.
https://paste.ee/p/WHmYc

What do you suggest instead/what changes do you propose?

The bandaid fix for me was downgrading to an NEI with 0 concurrency, letting my furnances finish smelting and then restart. This seems to have fixed all problems but still means there is a weird with concurrent modication in NEI.

What is your GTNH Discord username?

FluxDZ#3861

More broken handlers in beta 2

handlers.zip
image
Any cell
image
Any arcane worktable recipe, wand crafting
image
DCT, like infinity ingot
image
DCT shapeless, like infinity catalyst (the original one)
image
anything that needs cooling
image
Infusion, extremely primordial pearl
image
carpenter recipes, escritoire
image
ExU's info tab, angel block
image
BM alchemy, gunpowder
image
Shaped orb crafting, blood infused diamond
image
Shapeless orb crafting, livens
image
BM altar, blank slate
image
Witch's cauldron, infernal chalk
image
TC tool materials, nether star
image
Distillery, diamond vapor
image
Kettle, redstone soup

There's even more, but since I'm not sure the version is correct or w/e, I'll stop here.

ConcurrentModificationException when clicking on bookmarked item

Mod-Version: NotEnoughItems-1.7.10-2.0.9-GTNH-universal.jar
Forge-Version: 1614
Modpack: FTB Infinity Evolved Skyblock 2.0.1 (Modlist on Curseforge)
Log: https://pastebin.com/Dq8qvsZD

Issue Description:
I rarely have an issue that I can't see the recipe of a bookmarked item. I click on the item, the recipe GUI doesn't open and I get a ConcurrentModificationException in the log. Clicking the item multiple times will eventually show the recipe.
I wasn't able to narrow the problem down to specific items or mods that seem to cause this.
Sometimes this issue doesn't happen at all, sometimes 3/4 of attempts fail and throw a exception.

GT++ bookmarked fluids changed after restart

Specifically, the GT++ fluids grisium and talonite, changed to titansteel and (Really long fission lithium fuel thing). After restarting they became two new GT++ fluids. I also confirmed that the entries in the bookmarks.ini file stayed the same, so I'd guess GT++ is registering it's fluids under a different metadata number every restart.

GTNH 2.0.8.5dev
NotEnoughItems-1.7.10-2.0.0-beta-6-GTNH-universal

I don't see any commits that would have fixed this in NotEnoughItems-1.7.10-2.0.1-GTNH-universal though.

[2.1.0-GTNHA-beta] Current Page Number Persists Between Different Tabs

GTNH and NEI are both 2.1.0. Playing on MP with the beta NEI only being client side.

Page number stays the same when switching between tabs (for example, furnace to wiremill). When exceeding available page numbers, this results in an empty recipe with no way to change the page number, unless you switch back to a tab with at least that many pages.

This does not seam to persist when clicking on a new recipe, but does persist when tabbing back to previously viewed recipes. It will also change back to 1 if you re-click the same recipe.

Attached some pictures of before/after:
image
image

Nei Integration freeze game

After entering the world pressing U to see used recipe of an item in inventory the game freeze and then windows say the application is not responding.
Instead pressing R all works and U works again.

2.0.8.3 Exception while trying to check some wand recipes

So when I try to click on Ichorium Adorned Ichor Woven Silverwood Scepter, it doesn't load any recipe and prints the following (without crashing client, but it also doesn't show recipes):
https://hastebin.com/ibafofanus.rb

What I do to see this exception:

  1. Found in NEI "Ichor Woven Silverwood Wand Core".
  2. Moved to 14-th page to see Ichorium Adorned Ichor Woven Silverwood Scepter.
  3. Clicked on Scepter with R.
  4. Checked fml-client-latest.log

Checked with 2 another wands, so count of errored recipes must be much bigger.

Also I want to ask if it affects on any other recipes that wanted to appear but can't, so:
Does it stop other recipes to load or it catches exception within specific recipe handler?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.