Giter VIP home page Giter VIP logo

twilightforest's Issues

Crash

Time: 12/30/23 10:53 PM
Description: Exception in server tick loop

java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1469)
at java.util.HashMap$ValueIterator.next(HashMap.java:1498)
at net.minecraft.world.gen.structure.MapGenStructure.func_75051_a(MapGenStructure.java:89)
at twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:950)
at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:429)
at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1187)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:76)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:14)
at net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:920)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:462)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:845)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:695)
at java.lang.Thread.run(Thread.java:750)

Crash

Description: Exception in server tick loop

java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1469)
at java.util.HashMap$ValueIterator.next(HashMap.java:1498)
at twilightforest.world.MapGenTFHollowTree.generateStructuresInChunk(MapGenTFHollowTree.java:72)
at twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:953)
at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:429)
at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1187)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:76)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:14)
at net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:920)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:462)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:845)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:695)
at java.lang.Thread.run(Thread.java:750)

Notes on the Twilight Forest Materials crash

Your GTNH Discord Username

JodieRuth#2410

Your Pack Version

nightly 361

Your Server

zeta

Java Version

Java 8

Type of Server

None

Your Actions

image
Right click and crash

Crash Report

crash-2024-03-01_22.51.27-client.txt

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the crash still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this crash consistently by following the exact steps I described above.
  • I have asked other people and they confirm they also crash by following the exact steps I described above.

Automation Broken with Placeable Bugs

@Gordon-Frohman The refactor you submitted is breaking automation.

From my community:

Not an incredibly common thing to do with these items(though a neat lighting/alarm alternative), but I am concerned this may branch into other larger problems. I am not sure what other changes were made to the item besides aspects, but the Block Placer places the "out of date" ones just fine, and can't place the new ones.
Cicada (working, but out of date) item id: 1816
Cicada (not working, current) item id: 8651:1
Firefly (working, but out of date) item id: 1815
Firefly (not working, current) item id: 8657

2024-06-05_14 22 49
2024-06-05_14 23 06
2024-06-05_14 22 08

Also are IDs being occupied needlessly with the new refactor?

A few minor things I found that I dont want to spam Issues for.

Just a List of minor things I noticed during my time of adding Compat to Twilight Forest:

  • Naga Scales are not increased when using Looting Weapons, all other Bosses do drop more with Looting (except Urghast, but that one is a Chest)

  • Helmetcrabs when on Fire still drop Raw Fish instead of Cooked Fish. (GT6 happens to fix that lack of roasting the Fish)

  • Filled Maps (Magic Map / Maze Map / Ore Map) still stack to a size of 1 instead of 64, which is a holdover from older MC Versions that did not allow Map duplication. Vanilla Filled Maps do stack to 64 in 1.7.10. (GT6 happens to increase that max stacksize too)

  • Crumble Horn, Peacock Fan, Ore Magnet and the Giant Pickaxe have an insanely low max durability by two orders of magnitude too little (yeah about two decimal digits too little), which makes them almost single use to the point of nobody actually wanting to use them, because you dont get much from them breaking near instantly. (GT6 sets their durability to 10000 for all four of those)

Too bad Mending does not exist yet, because then it would actually make sense that you need to recharge them with EXP Orbs.

I fixed most of these Issues in GT6, so it will work with the old Twilight Forest Versions too, but I wanted to mention it just so there is a record of the Issues I noticed. ^^

Problems with ticon to TF compat

Your GTNH Discord Username

chochem

Your Pack Version

GTNH 2.6.0 beta1

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

image

The Reality

Edit: this compat is now disabled in GTNH which resolves some of these issues but not others, which are still relevant for use outside of GTNH:

image
(resolved)
this is clearly caused by this strange nuggetknightmetel oredict
image
(unresolved)

Also:

image
(unresolved)
image
(unresolved)

there is also duplicate ticon materials for things like knightmetal. (resolved)

And there are nugget->ingot and ingot->nugget crafting grid recipes. (resolved)

And ticon fluids and recycling where sofar we have been using a gt fluid and gt recycling. (resolved)

Your Proposal

remove the oredict

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.

No Black Bighorn Sheep unless you dye them with Ink Sacs you cant really get in Twilight Forest.

At this Line it says "50% brown, 50% any other color"
https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/entity/passive/EntityTFBighorn.java#L28

But here it says random next int 15 instead of 16, resulting in a boundary Error.
https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/entity/passive/EntityTFBighorn.java#L37

This will result in Black Bighorns never existing unless you bring inc sacs from the Overworld, because Squids require a specific Water Height that is not a given in Twilight Forest, except for the TODO in the Urghast Tower claiming there is supposed to be a Squid Tank.

If the comment was also to be believed technically the chance of random to turn out 12 too, would slightly weigh it even more towards brown Bighorns. But I guess that is not really important. ;)

Baubles integration

Should probably add it as a required dependency?

java.lang.NoClassDefFoundError: baubles/common/lib/PlayerHandler
	at twilightforest.integration.TFBaublesIntegration.playerSaveDo(TFBaublesIntegration.java:95)
	at twilightforest.TFEventListener.playerSave(TFEventListener.java:660)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_7_TFEventListener_playerSave_SaveToFile.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.event.ForgeEventFactory.firePlayerSavingEvent(ForgeEventFactory.java:226)
	at net.minecraft.world.storage.SaveHandler.func_75753_a(SaveHandler.java:259)
	at net.minecraft.server.management.ServerConfigurationManager.func_72391_b(ServerConfigurationManager.java:286)
	at net.minecraft.server.integrated.IntegratedPlayerList.func_72391_b(SourceFile:26)
	at net.minecraft.server.management.ServerConfigurationManager.func_72389_g(ServerConfigurationManager.java:899)
	at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:105)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
	at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)
Caused by: java.lang.ClassNotFoundException: baubles.common.lib.PlayerHandler
	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 13 more
Caused by: java.lang.NullPointerException
	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:182)
	... 15 more

Server crash on TF Nagastone facing in worldgen

Random crash in worldgen on exploring TF, very close to the world portal. First instance of triggering this simply kicks the player. If they re-login, it crashes the entire server.

GTNH 2.6.1

Seems similar to #71

Crashlog snippet

// I blame Dinnerbone.

Time: 7/6/24, 3:35 PM
Description: Exception getting block type in world

java.lang.NullPointerException: Cannot invoke "twilightforest.block.BlockTFNagastone2$Yaw.ordinal()" because "facing" is null
at RFB-Launch//twilightforest.block.BlockTFNagastone2.GetMetadata(BlockTFNagastone2.java:639)
at RFB-Launch//twilightforest.structures.courtyard.ComponentTFNagaCourtyardTerraceBrazier.func_74875_a(ComponentTFNagaCourtyardTerraceBrazier.java:265)
at RFB-Launch//net.minecraft.world.gen.structure.StructureStart.func_75068_a(StructureStart.java:44)
at RFB-Launch//net.minecraft.world.gen.structure.MapGenStructure.func_75051_a(MapGenStructure.java:93)
at RFB-Launch//twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:950)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:279)
at RFB-Launch//net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.get(AsynchronousExecutor.java:165)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:341)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:126)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199)
at RFB-Launch//net.minecraft.world.World.func_72964_e(World.java:419)
at RFB-Launch//net.minecraft.world.World.func_147439_a(World.java:345)
at RFB-Launch//net.minecraft.world.World.func_147437_c(World.java:365)
at RFB-Launch//mods.natura.worldgen.BaseCropWorldgen.generateBarley(BaseCropWorldgen.java:145)
at RFB-Launch//mods.natura.worldgen.BaseCropWorldgen.generate(BaseCropWorldgen.java:53)
at RFB-Launch//cpw.mods.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:112)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:280)
at RFB-Launch//net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
at RFB-Launch//net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:596)
at RFB-Launch//net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
at RFB-Launch//net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at RFB-Launch//net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at RFB-Launch//net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
at RFB-Launch//twilightforest.block.BlockTFNagastone2.GetMetadata(BlockTFNagastone2.java:639)
at RFB-Launch//twilightforest.structures.courtyard.ComponentTFNagaCourtyardTerraceBrazier.func_74875_a(ComponentTFNagaCourtyardTerraceBrazier.java:265)
at RFB-Launch//net.minecraft.world.gen.structure.StructureStart.func_75068_a(StructureStart.java:44)
at RFB-Launch//net.minecraft.world.gen.structure.MapGenStructure.func_75051_a(MapGenStructure.java:93)
at RFB-Launch//twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:950)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:279)
at RFB-Launch//net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.get(AsynchronousExecutor.java:165)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.skipQueue(AsynchronousExecutor.java:341)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.getSkipQueue(AsynchronousExecutor.java:302)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOExecutor.syncChunkLoad(ChunkIOExecutor.java:12)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:126)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199)
at RFB-Launch//net.minecraft.world.World.func_72964_e(World.java:419)

-- Requested block coordinates --
Details:
Found chunk: true
Location: World: (-1026,158,-845), Chunk: (at 14,9,3 in -65,-53; contains blocks -1040,0,-848 to -1025,255,-833), Region: (-3,-2; contains chunks -96,-64 to -65,-33, blocks -1536,0,-1024 to -1025,255,-513)
Stacktrace:
at RFB-Launch//net.minecraft.world.World.func_147439_a(World.java:345)
at RFB-Launch//net.minecraft.world.World.func_147437_c(World.java:365)
at RFB-Launch//mods.natura.worldgen.BaseCropWorldgen.generateBarley(BaseCropWorldgen.java:145)
at RFB-Launch//mods.natura.worldgen.BaseCropWorldgen.generate(BaseCropWorldgen.java:53)
at RFB-Launch//cpw.mods.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:112)
at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:280)
at RFB-Launch//net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
at RFB-Launch//net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:596)
at RFB-Launch//net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
at RFB-Launch//net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at RFB-Launch//net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at RFB-Launch//net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Naga drops Hydra trophy

Killed a Naga and got a Hydra Trophy, using TwilightForest-2.6.20-pre

image

Bonus:
image
TF logs dont have a name ^
they do when they drop tho:
image

Crash

Time: 10/18/23 2:51 AM
Description: Exception in server tick loop

java.lang.NoSuchMethodError: net.minecraft.world.WorldProvider.func_76571_f()F
at twilightforest.item.ItemTFMagicBeans.getCloudHeight(ItemTFMagicBeans.java:51)
at twilightforest.item.ItemTFMagicBeans.func_77648_a(ItemTFMagicBeans.java:28)
at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:535)
at net.minecraft.item.ItemStack.func_77943_a(ItemStack.java:164)
at net.minecraft.server.management.ItemInWorldManager.func_73078_a(ItemInWorldManager.java:498)
at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:872)
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:60)
at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:9)
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:245)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1023)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:842)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:692)
at java.lang.Thread.run(Thread.java:750)

[Question]: Is this mod useable outside the gtnh modpack?

When I tried to launch with it I've got:

cpw.mods.fml.common.LoaderException: java.lang.NoClassDefFoundError: twilightforest/biomes/TFBiomeBase at cpw.mods.fml.common.LoadController.transition(LoadController.java:163) at cpw.mods.fml.common.Loader.preinitializeMods(Loader.java:559) at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:243) at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:480) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:878) at net.minecraft.client.main.Main.main(SourceFile:148) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Is there some dependencies or it's just hardly built-in to GTNH Modpack?

Crash on dedicated server

A client-side class is being loaded server-side here:

private static void readTinkersConstructManuals() {
DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
String CurrentLanguage = Minecraft.getMinecraft().getLanguageManager().getCurrentLanguage().getLanguageCode();
Document twilightMaterials_cl = readManual(
"/assets/tinker/manuals/" + CurrentLanguage + "/twilightMaterials.xml",
dbFactory);
twilightMaterials = twilightMaterials_cl != null ? twilightMaterials_cl
: readManual("/assets/tinker/manuals/en_US/twilightMaterials.xml", dbFactory);
manualData = new TFManualInfo();
}

Namely net.minecraft.client.Minecraft.

Exception in Server Tick Loop When Exploring Twilight Forest - Illegal Coordinates Reported by GT_TileEntity_Ores

Exception in server tick loop

Was exploring twilight forest and encountered this crash. Looks unrelated to #71 at first glance. Could be a GT problem?

java.lang.IllegalArgumentException: Tile entity of type gregtech.common.blocks.GT_TileEntity_Ores (jar:file:/home/Minecraft/mods/gregtech-5.09.45.168.jar!/gregtech/common/blocks/GT_TileEntity_Ores.class) reports coordinates of (-576, 28, 2063) that lie outside of the bounds of chunk (x=-44, z=134) in dimension 7 - ending up with illegal in-chunk coordinates of (128, 28, -81).

Full crash:
crash-2024-06-28_12.36.38-server.txt

NullPointerException Crash

Hello, I had this crash on my server today (Version 2.6.1):

Description: Exception in server tick loop

java.lang.NullPointerException: Cannot invoke "net.minecraftforge.common.util.ForgeDirection.ordinal()" because "this.EtchedNagastoneNorth" is null
	at RFB-Launch//twilightforest.structures.courtyard.ComponentTFNagaCourtyardWall.func_74875_a(ComponentTFNagaCourtyardWall.java:576)
	at RFB-Launch//net.minecraft.world.gen.structure.StructureStart.func_75068_a(StructureStart.java:44)
	at RFB-Launch//net.minecraft.world.gen.structure.MapGenStructure.func_75051_a(MapGenStructure.java:93)
	at RFB-Launch//twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:950)
	at RFB-Launch//net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:279)
	at RFB-Launch//net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
	at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:52)
	at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:12)
	at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
	at RFB-Launch//net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
	at RFB-Launch//net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
	at RFB-Launch//net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:596)
	at RFB-Launch//net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
	at RFB-Launch//net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
	at RFB-Launch//net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
	at RFB-Launch//net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Twilight Forest somehow uses Block Metadata 49 for the Biome Dirt and Biome Grass layer.

Twilight Forest somehow uses Block Metadata 49 for the Biome Dirt and Biome Grass layer.

I got a report for a weird crash and noticed that a Block ID/Metadata extender caused Twilight Forests Biome Dirt and Biome Grass Layer in all of its Biomes to have MetaData 49.

Without the Block ID/Metadata Extender installed, it will turn into MetaData 1 thanks to a &15 sanity check, which is ALSO incorrect, as that makes Twilight Forests Dirt into Coarse Dirt, and Twilight Forests Grass into... Grass with an invalid Metadata value.

This might need some investigation or a simple Ctrl+F for the number 49 to replace it with a 0 inside some Biome related superclass in Twilight Forest.

I suspect it was just a mishap when trying to port the mod from the ID system to the "newer" block registry system in 1.7.10.

ConcurrentModificationException Crash

Description: Exception in server tick loop

java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1469)
at java.util.HashMap$ValueIterator.next(HashMap.java:1498)
at twilightforest.world.MapGenTFHollowTree.generateStructuresInChunk(MapGenTFHollowTree.java:72)
at twilightforest.world.ChunkProviderTwilightForest.func_73153_a(ChunkProviderTwilightForest.java:953)
at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:429)
at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1197)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:76)
at net.minecraftforge.common.chunkio.ChunkIOProvider.callStage2(ChunkIOProvider.java:14)
at net.minecraftforge.common.util.AsynchronousExecutor$Task.finish(AsynchronousExecutor.java:189)
at net.minecraftforge.common.util.AsynchronousExecutor.finishActive(AsynchronousExecutor.java:354)
at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:30)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:920)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:462)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:845)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:695)
at java.lang.Thread.run(Thread.java:748)

UrGhast breaks electric helmets and others that lack durability

in the UrGhast class

private void doTantrumDamageEffects() {
// harm player below
AxisAlignedBB below = this.boundingBox.getOffsetBoundingBox(0, -16, 0).expand(0, 16, 0);

    List<EntityPlayer> playersBelow = worldObj.getEntitiesWithinAABB(EntityPlayer.class, below);

    for (EntityPlayer player : playersBelow) {
        int dx = MathHelper.floor_double(player.posX);
        int dy = MathHelper.floor_double(player.posY);
        int dz = MathHelper.floor_double(player.posZ);

        if (worldObj.canBlockSeeTheSky(dx, dy, dz)) {
            player.attackEntityFrom(DamageSource.anvil, 3);
        }
    }

    // also suck up mini ghasts
    List<EntityTFMiniGhast> ghastsBelow = worldObj.getEntitiesWithinAABB(EntityTFMiniGhast.class, below);

    for (EntityTFMiniGhast ghast : ghastsBelow) {
        ghast.motionY += 1;
    }
}


Change the
player.attackEntityFrom(DamageSource.anvil, 3);

to
player.attackEntityFrom(DamageSource.generic, 3);

this causes damage to player but does not break the helmets if does not have durability

Minoshroom Axe, Knightly Axe and Knightly Sword do not do advertised Extra Damage!

While searching for how much extra Damage the Axe does when charging I found that the +3.5 Hearts of extra damage are never applied to anything because the following function is never called.

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFMinotaurAxe.java#L68

And instead the private variable is used to calculate Damage

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFMinotaurAxe.java#L117-L119

And yes I tested that in world too. No Extra Damage at all.

Edit: Same applies to Knightly Weapons just that THOSE have their Code for the +1 Heart of Damage commented out entirely.

https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFKnightlySword.java#L70-L88
https://github.com/GTNewHorizons/twilightforest/blob/master/src/main/java/twilightforest/item/ItemTFKnightlyAxe.java#L77-L94

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.