gtozzi / dophp Goto Github PK

Say I have a model with the following field defined as:

$fields['nm_name'] = [
'label' => 'label',
'rtype' => 'multi',
'dtype' => 'array',
'ropts' => ['refer'=>'Refer_name'],
'nmtab' => 'nm_table_name',
'rtab' => false,
];

An "instance" of the model has associated N values of that field.
If I try to remove all the values of that field, the system doesn't cast an exception but the values are still there.
I would expect values to be removed.
If instead I remove just SOME of the values, it works without problems.

More in depth, if I delete ALL the values of an nm field, no array is sent in POST with the field name as key, whereas if I delete SOME of the values of an nm field, an array with the field name as key is sent to POST with the remaining field values as values.
Our guess is that since no array is sent, the system skips the update.

We tracked down the issue to Model.php:

protected function _insertOrEdit($pk, & $post, & $files) {
[...]
foreach( $related as $k => $v ) {
                    if( $v === null )
                        continue;

if we remove the null check, the field is updated as intended.

We are currently working with version at commit 9778416