Giter VIP home page Giter VIP logo

rlapi-v3-oop's Introduction

rlapi-v3-oop's People

Contributors

brightskyz avatar gtsatsis avatar omnicons avatar rlmeadmin avatar samueldcs avatar sxribe avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

rlapi-v3-oop's Issues

Code design flaw

if(isset($_GET['bucket']) && !is_null($_GET['bucket'])) //Switch from array_key_exists to isset

You are not supposed to access the request body directly from the class, instead, pass the value from the API endpoint (index.php).

Example (index.php):

if(isset($_GET['bucket'] && !is_null[$_GET['bucket'])) {
    $uploader = new RLME\Uploader($_GET['bucket']);
}

And if the bucket is not set (isset() == false), set a default value on the constructor.

Example (Uploader.php)

function __construct($bucket = 'owoapi') {}

If you want, I can create a PR solving this issue

Use docker

Hi, its the guy from WildFyre, it would be super nice to have this dockerized

Adapt to Symfony 4

Notice: This is in-progress.

The codebase is currently being adapted and set up for Symfony 4.

  • User Functions Adaptation (Done)
  • API Key Functions Adaptation (Done)
  • Sentry Adaptation (Done)

[Bug] API isn't written in NodeJS

Describe the bug
The API is written in a terrible API language, should be written in nOdEjS

To Reproduce
Steps to reproduce the behavior:

  1. Use the API at all, or acknowledge its existence

Expected behavior
I expected the API to work well, but it's written in PHP?

Screenshots
https://php.net

Additional context
#3 would be fixed easier by using Node...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.