guikingone / pantherextension Goto Github PK

Hi,

there are minor inconsistencies between PantherDriver::wait() method and its definition in the interface:

• $timeout parameter is expected in milliseconds in the phpdoc from the interface althought we're passing it to $client->wait() where the parameter is called timeoutInSecond
• the phpdoc in the interface expects the $condition parameter to be an interger, but the WebDriverWait::until() which it is passed expects a callable or a WebDriverExpectedCondition. This could be a little bit more annoying because static analysis tools complain about it

For the record, we're using this wait() method in order to wait for an element to be visible :

$driver->wait(5, WebDriverExpectedCondition::visibilityOfElementLocated(WebDriverBy::cssSelector($element)));

Hi,

i tried to use PantherDriver::getStatus() method, but it tells me:

The PantherExtension\Driver\PantherDriver::PantherExtension\Driver\PantherDriver::getStatusCode() method cannot be called when using PantherExtension\Driver\PantherDriver

i've never managed to make it work

version: 0.4.0

Then I wait for "#element" to be visible

calls PantherContext::iWaitForElementToBeVisible()

which calls $driver->wait(3000, WebDriverExpectedCondition::visibilityOfAnyElementLocated(WebDriverBy::cssSelector($element)));

but PantherDriver::wait() must be a string...