guseyn / cutie Goto Github PK

Hi, Guseyn!
I tried your framework and got unexpected behavior with synchronous call.

For example, i want to create two classes with sync and async behavior, for read and write files.

WrittenFile

const AsyncObject = require('@cuties/cutie').AsyncObject
const fs = require('fs')

class WrittenFile extends AsyncObject {
    constructor(path, content) {
        super(path, content);
    }

    asyncCall() {
        return (path, content, callback) => {
            this.path = path;
            fs.writeFile(path, content, callback)
            console.log("asyncCall writtenFile");
        }
    }

    syncCall() {
        return (path, content, callback) => {
            this.path = path;
            fs.writeFileSync(path, content, callback)
            console.log("syncCall writtenFile");
        }
    }

    onResult() {
        console.log("writtenFile has done!");
    }
}

module.exports = WrittenFile;

ReadDataByPath

const AsyncObject = require('@cuties/cutie').AsyncObject
const fs = require('fs')

class ReadDataByPath extends AsyncObject {
  constructor (path, encoding) {
    super(path, encoding);
  }
  
  asyncCall () {
    return fs.readFile
  }

  syncCall() {
      return fs.readFileSync
  }
}

module.exports = ReadDataByPath

And if i want to run as sync operation, i do

new WrittenFile(
    'package2.json',
    new ReadDataByPath('package.json', 'utf-8')
).syncCall();

but nothing happens.

How can i create one class with two behaviors (async and sync)?

Instead of

definedAsyncCall() { return (...args) => { /* ... */ } }

do:

definedSyncCall(...args) { /* ... */ }

The same for sync call

Add as() method to AsyncObject that can cache value.
Now As can be used only for retrieving values from the cache (can accept only one argument, which is key cached value).

Revert new signature, because it's not so obvious in cases like fs.readFile, where you don't need to pass params to async call.

Actually it's more clear if SyncObject would be introduced, so in the whole we'll have three abstractions: AsyncObject, SyncObject and Event.

Refactor Cutie using decorators

Create and implement after conception:

A1(
  A2(), A3()
).after(
  A4(
    A5(), A6()
  )
).call()

Event's body must return async object

Write docs of how async tree is implemented in Cutie.

Consider As abstraction (for cache),
For example:

As('A2')(
   A1(),
   A2().as('A2'),
   A3()
),

where As('A2') is the represented result of A2()

Sometimes it's useful to use Event as AsyncObject (pass some async objects as encapsulated arguments into Event).