h-dong / serina Goto Github PK

This should return 23:59 instead of 00:00

Reproduce:
Match sun tomorrow returns match tomorrow
Match su tomorrow returns Match su

Using global in Regex checks seems to have to some weird behaviours. See https://stackoverflow.com/a/2630538. Should review all g usages, if it is safe to remove then we should remove them.

One thing to consider is how well does these Regex check work with long text, maybe the ones that includes tab, new line and etc. Maybe need to check for m (multi-line) instead of g?

It is weird to allow "a" and "1" but not "one". We should be able to parse all of them.

The on in session was used to match the date and time.

What the title said.

Right now there is no indicator of what was parsed, it would be useful to return with each match something like this:

foundTime: true,
foundDate: false

I've selected for refactoring 7 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Do not copy code.
• Why❓
  When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
• How 🔧
  Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! ✨ 💯

See slide no 25 & 26 -> https://growth.design/case-studies/superhuman-user-onboarding/

I think the Superhuman event parser is the best thing out there so a copy of that would be awesome.

Are you still planning to complete the milestones or working on other projects?

I think this is the best NLP event parser library out there in JavaScript other than Sherlock :)

Use the provided test.each() method to test long list of test cases.

Documentation Link: https://jestjs.io/docs/en/api#testeachtable-name-fn-timeout

E.g. convertDateStringToObj.ts and convertTimeStringObj.ts

E.g have a library that can turn string into numerical value that easily consumed

e.g. "8:30am" => { hour: 8, minute: 30 }

As shown in the screenshots below, yesterday keyword is not doing anything

Yesterday Screenshot:

Today Screenshot:

Tomorrow Screenshot:

Since we have added optional filler word to date-time match, we should do the same for date matches too just to be consistent.

We should revisit the source code and see what was used to ensure ES5 compatibility. Or maybe ES6 compatibility is enough?

• Loops for...of or for...in
• Regex look behind and look ahead MDN

If going for ES5 output, then either polyfill or use alternative loops.