h34tnet / temporize Goto Github PK

Umlauts in the source code are \u**-escaped by the java.commons.text StringEscape utils.

The template "äöü" creates the following write code:

w.write("\u00C3\u00A4\u00C3\u00B6\u00C3\u00BC");

This then gets written as "äöü"

Would remove a file and a an extra import. Has several downsides though, as min 1.8 language level, etc. and have one file (the interface) do several independent things.

If a template gets removed or renamed, the leftover class stays and has to be manually removed.

Proposed resolution:

• Tag compiled templates with a tag that includes the path of the source file
• On compile, find all compiled templates in the output directory that refer to a source file that doesn't exist anymore
• Delete those

Note: it's not necessary to delete all template files and i don't want to just delete all java files in the output directory for security reasons (misconfiguration might make it delete more than necessary).

Seems like i omitted this in the current version, even though the information should be available.

Currently, all files are written immediately after being compiled.

So if there are 3 Templates A, B and C, and compilation of B throws an Exception, A has already been written to disk, while B and C haven't, making the state of the compiled templates inconsistent.

Solution: gather all templates in memory before writing them down as a last step.