hackclub / webring Goto Github PK

URL: https://www.johnlins.com

Webring sites keep going down :(

Here's what I feel is a solution -- Periodically scrape all webring sites

• If a non 2xx code is returned, or
• If the site does not contain the webring code

temporarily kick the member from the webring (until next scrape)

hi!

i currently have the JS deployed on my site, but because the webring buttons are only located on one page, I get console errors from every other page complaining about this line:

https://github.com/hackclub/webring/blob/main/public/embed.js#L14

can the JS be updated to abort early if it can't find the two query selectors on the page to prevent any JS errors?

Rewrite the webring's site with Next.js, using the Hack Club theme starter. This will make the site more in-line with Hack Club's design standards as it evolves and using existent components would simplify the development process.
The webring embed, however, does not need to be refactored as a React component.

The workflow doesn't support @rishiosaur's API :/

Temporary fix is in place

View: https://github.com/rishiosaur/webring-api

title yes

When you link to a page on another site using the target="_blank" attribute, you can expose your site to performance and security issues:
The other page may run on the same process as your page. If the other page is running a lot of JavaScript, your page's performance may suffer.
The other page can access your window object with the window.opener property. This may allow the other page to redirect your page to a malicious URL.

source: https://developer.chrome.com/

Hello. I've recently noticed that this website: https://fayd.me/ does not have Hack Club webring embedded, and I can't proceed to the next hack clubber website because of this. Kindly fix this. Thanks!

Currently, the "maintain" action is malfunctioning because the main branch is protected.

Would you prefer to unprotect the branch or modify the action to create a pull request and merge it?

There's also a potential issue with the current workflow.yml. Won't this configuration lead to an infinite loop, given that it's triggered on every push to the master branch

on:
  push:
    branches: [ master ]
  schedule:
    - cron: 0/15 * * * *

and pushes the new changes back to the branch

- name: Push changes
  uses: ad-m/github-push-action@master
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    branch: ${{ github.ref }}

???

Also, I've noticed that it should reference "main" and not "master".

I suggest removing the push hook and keeping only cron.