github.com hackfoldr.org hack.g0v.tw

據clkao說在這裡 <a href="https://github.com/hackfoldr/hackfoldr/blob/master/app/app/con

first try of live... example sheet: <a href="https://ethercalc.org/hackfoldr

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

for links we know that can't be embeded, just open in new window about hackfoldr HOT 9 CLOSED

hackfoldr commented on July 25, 2024

for links we know that can't be embeded, just open in new window

from hackfoldr.

Comments (9)

jimyhuang commented on July 25, 2024

如果是在ethercalc中標註，這個link是要open new window，是否合適？
判斷難免有例外

from hackfoldr.

clkao commented on July 25, 2024

good idea! we can put that info in the 3rd column (options), which is already being parsed as json

from hackfoldr.

jimyhuang commented on July 25, 2024

據clkao說在這裡
https://github.com/hackfoldr/hackfoldr/blob/master/app/app/controllers.ls#L25

from hackfoldr.

jimyhuang commented on July 25, 2024

first try of livescript...
example sheet: https://ethercalc.org/hackfoldr

diff --git a/app/app/controllers.ls b/app/app/controllers.ls
index 6326fe9..862f7dc 100644
--- a/app/app/controllers.ls
+++ b/app/app/controllers.ls
@@ -23,7 +23,11 @@ angular.module 'app.controllers' <[ui.state]>
     docs: HackFolder.docs
     tree: HackFolder.tree
     godoc: (doc) ->
-      $scope.go "/#{ $scope.hackId }/#{ decodeURIComponent doc.id }"
+      if doc.opts?target == '_blank'
+        window.open doc.url, doc.id
+        return true
+      else
+        $scope.go "/#{ $scope.hackId }/#{ decodeURIComponent doc.id }"
     open: (doc) ->
       window.open doc.url, doc.id
       return false

from hackfoldr.

clkao commented on July 25, 2024

@jimyhuang is now project owner, please commit if this works ;)

from hackfoldr.

jimyhuang commented on July 25, 2024

是能work
但clkao，你確定我寫的對嗎 XD
對的話我就commit進去

from hackfoldr.

clkao commented on July 25, 2024

looks fine to me. we can add some common sites (facebook, github) check in the if as well ;)

from hackfoldr.

jimyhuang commented on July 25, 2024

yep .. trying...