haikuarchives / bephonebook Goto Github PK
View Code? Open in Web Editor NEWA phone book manager.
bephonebook's People
Contributors
Stargazers
Watchers
bephonebook's Issues
No jokes. This is actually the worst code I've ever seen.
It's not only that it does not follow any of the common coding guidelines, but it also has many algorithmic/programming errors.
#2
I tried to follow along the trace, but once I reached MainView::SkinBPK I gave up.
I don't know what its name refers to, there's no documentation/comments either, but it would still be acceptable if the code is easy to understand just by looking at it (IT'S NOT).
The function itself is around 350 lines (which is never healthy) and that's partly because the author did not know or care about top-down design, and partly because it repeats code.
I'm not completely fluent in Haiku's APIs, but I'm sure that it does not encourage you to write an own GUI system. This program renders the buttons and other widgets by drawing strings and lines using the pen tool.
P.S.: I like to contribute to projects, and I'm well aware that most of the repositories found in HaikuArchives are 10+ years old and not have been maintained for years, but this is by far the worst of all. Also, as there is no LICENSE file in the project, which means that it's not open source by default.
Add ReadMe
Crashes in BView::RemoveChild
Debug information for team /boot/home/BePhoneBook/objects.x86_64-cc7-release/BePhoneBook (2124):
CPU(s): 2x Intel Core™ i7-3635QM
Memory: 1.46 GiB total, 332.14 MiB used
Haiku revision: hrev52501 Nov 4 2018 14:43:09 (x86_64)
Active Threads:
thread 2129: team 2124 debug task
thread 2124: BePhoneBook (main)
state: Exception (Segment violation)
Frame IP Function Name
-----------------------------------------------
0x7fea25cd0810 0x1b5b190ca8c BView::RemoveChild(BView*) + 0xa
Disassembly:
BView::RemoveChild(BView*):
0x000001b5b190ca82: b800000000 mov $0x0, %eax
0x000001b5b190ca87: 4885f6 test %rsi, %rsi
0x000001b5b190ca8a: 7406 jz 0xb190ca92
0x000001b5b190ca8c: 48397e68 cmp %rdi, 0x68(%rsi) <--
Frame memory:
[0x7fea25cd0808] .<\..... c9 3c 5c a3 e2 01 00 00
0x7fea25cd0ab0 0x1e2a35c3cc4 MainView::SkinBPK() + 0x10c
0x7fea25cd0d50 0x1e2a35c3e20 MainView::SkinBPK() + 0x268
0x7fea25cd0da0 0x1e2a35bf8d0 MainWindow::MainWindow(BRect) + 0xca
0x7fea25cd0fb0 0x1e2a35caec9 BephoneApp::BephoneApp() + 0x1f9
0x7fea25cd0fe0 0x1e2a35cac5f main + 0x1b
0x7fea25cd1010 0x1e2a35bf739 _start + 0x4f
0x7fea25cd1040 0x21f84ba789e runtime_loader + 0x105
00000000 0x7fc2ebaf9260 commpage_thread_exit + 0
Determine License
Need to identify which license the code here was released under.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.