Unable to build source packages after 5cecf6a0 about haikuporter HOT 7 CLOSED

Here's my haikuports.conf for good measure:

# Example HaikuPorts configuration
#
# =============
# Installation:
#   1) cp haikuports-sample.conf ~/config/settings/haikuports.conf
#
#   2) customize your settings:
#      lpe ~/config/settings/haikuports.conf

# ==================
# Tip:
#
# Put this into your ~/config/settings/profile to search for a string in all
# recipes with "inrecipe {searchstring}" and build a package with
# "hp {packagename}" (adjust your /path/to/your/haikuports/):
#
#       function inrecipe { grep -n $1 /path/to/your/haikuports/*/*/*.recipe; }
#       export -f inrecipe
#
#       alias hp="haikuporter -S -j8 --get-dependencies --no-source-packages"

# ==================
# Required settings:
#

# --------------
# TREE_PATH:
#     The full path to your cloned haikuports tree.
TREE_PATH="/Data/Code/haikuports"

# --------------
# PACKAGER:
#     Your name and email
PACKAGER="EMAUL <[email protected]>"

# ==================
# Optional settings:

# --------------
# VENDOR:
#     Sets a custom VENDOR tag that will be inserted into all built packages
#     ("Haiku Project" by default).
#VENDOR="Haiku Project"

# --------------
# ALLOW_UNTESTED:
#     Allow build of untested recipes. '?x86' for example
ALLOW_UNTESTED="yes"

# --------------
# ALLOW_UNSAFE_SOURCES:
#     Allow building from unsafe sources. Setting this to yes allows
#     downloading sources for which there is no possibility to check if they
#     have been corrupted or tampered with.
#
#     Only set this to yes if you really need this and know what you're doing,
#     for example if you want to build recipes for development versions that
#     fetch the head from a repository.
#ALLOW_UNSAFE_SOURCES="yes"

# --------------
# TARGET_ARCHITECTURE:
#     The primary architectures you wish to compile recipes for.
#     Defaults to the current primary platform.
#TARGET_ARCHITECTURE="x86_gcc2"

# --------------
# SECONDARY_TARGET_ARCHITECTURES:
#     Secondary platforms you wish to build packages for (one per line)
#     Example is x86 (gcc4) packages on a x86_gcc2 (gcc2) system
#     Default is no secondary target architectures.
#SECONDARY_TARGET_ARCHITECTURES="x86"

from haikuporter.

What's 5cecf6a0? I get a 404 for that commit.

from haikuporter.

I get the same problem. This also blocks the boostrap build.
Problematic commit seems to be 5be7f1a
before: haikuporter builds source packages by default so --create-source-packages option is not needed (but also it results in error if we specify it explicitly)
after: haikuporter does not build source packages by default and we can't change this behavior with --create-source-packages as that results in the umount error

from haikuporter.

For this to work currently you need

CREATE_SOURCE_PACKAGES="yes"

in haikuports.conf.

It looks like I missed some cases, normally the source package should be enabled if you have either this option, or one of the command line options that results in creating a source package. Both shouldn't be needed, but it doesn't work as expected.

The condition at line 1055 looks particularly suspicious as it 'and's the config file option with the other conditions. Maybe try something like this?

if (not haveSourcePackage and not keys['DISABLE_SOURCE_PACKAGE']
			and not basedOnSourcePackage
			and (Configuration.shallCreateSourcePackages()
			or not getOption('noSourcePackages')))

I am not sure if this is right, either. This check is too complicated for me to understand what it does.

from haikuporter.

I have to admit that I'm a bit confused. The command line help prints out the following when invoked as haikuporter --help:

    --create-source-packages
                        build only the (regular) source packages
    --create-source-packages-for-bootstrap
                        build only source packages as required by thebootstrap
                        image

The --create-source-packages-for-bootstrap option is used during the bootstrap procedure when creating the 'rigged' source packages (which we don't really use) but it also needs regular source packages for the *_bootstrap recipes, and I'm not sure if we can rely on haikuporter.conf during bootstrapping. So how do we enable source package creation then, if not with the --create-source-packages option?

from haikuporter.

The command-line options should just work, but the commit introducing the option in haikuports.conf broke them. The option in haikuports.conf is meant to disable source packages only in the normal case (when --create-source-package is not specified), but I did not write the conditions the right way, and it doesn't work.

from haikuporter.

Note that you need to delete/regenerate the dependency info files in haikuports/repository for his fix to work.

from haikuporter.