Comments (6)
Also from @mmlr:
we should also generally disable extracting with other uids by means of filters
and probably heed the python tarfile docs warning about using data filter to prevent tars from writing anywhere in the system...
from haikuporter.
I wonder why we use Python's tar handling support anyway. It appears all the things we do with it can be done via tar
command line arguments, and we already use command line tools for extracting other types of archives. That'd be a lot simpler than all the code we have for filters and info-handling.
from haikuporter.
It appears tar
can only duplicate hardlinked files, though, not turn them into symlinks as our filtering code does. I think that should be fine?
from haikuporter.
I suppose, that, when cross-building, the provided tar version can be very different.
from haikuporter.
I think that should be fine?
Probably not, if the build modifies any of these files. It's difficult to say if some recipes would hit that specific problem.
In 2019, some build (@mmlr believes it to be https://build.haiku-os.org/buildmaster/master/x86_64/?buildrunDir=2953&viewMode=expanded) created a user named root. As the root user on Haiku is just called user, the new root user had a UID greater than 1000, not 0.
How did that even affect the builder? Creating a user should change the /etc/passwd file inside the chroot, but not the one used by the OS, right? So once the build is done, that user disappears? Otherwise, it is a chroot leak and that is a problem that should be solved on Haiku side?
from haikuporter.
Otherwise, it is a chroot leak and that is a problem that should be solved on Haiku side?
The useradd
command does not modify /etc/passwd
but contacts Registrar to ask it to make the change. And registrar only checks that the application making the request is running as root (UID 0) and nothing else, which it is inside the chroot
. Yes, we should probably fix this on the Haiku side, but I'm not quite sure about how.
from haikuporter.
Related Issues (20)
- entering the chroot for recipes with a PATCH() function fails
- [buildmaster] Only rename downloaded files from builder after all downloads succeed
- Skip creation of git repository if a recipe contains no patches or PATCH function HOT 5
- 'meson setup <builddir>' fails in recipes HOT 1
- Unable to build source packages after 5cecf6a0 HOT 7
- Using fixCMake doesn't work as expected. HOT 1
- Warning: POLICY ERROR: no matching self provides for "libart_lgpl_devel"
- Explicitly state which dependency could not be satisfied (or why) HOT 4
- buildmaster needs to leverage object storage HOT 23
- Use python packaging.Version to handle versioning inside HaikuPorter instead of custom solution HOT 7
- Changes committed to the master without PR HOT 1
- Cannot clone repository properly on MacOS HOT 16
- Using multiple underscores in recipe name/port name doesn't work for secondary architecture (32bit) HOT 3
- [enhancement] Add RSS/Atom feed for failed builds (skipped ones too?).
- pip3 install no longer adds executable to path HOT 6
- Reintroduce the lib:libstdc++ dependency in haikuporter
- can only concatenate str on --why
- Haikuporter makes too many assumptions about directories existing HOT 2
- When the PATCH function fails, haikuporter resets to ORIGIN, removing patchset commits
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haikuporter.