half-t / zmq_ex Goto Github PK

Elixir client should be able to connect to python server
Elixir server should allow connection from python client

ref : #15 #16 #17

Fill out more hex metadata

https://github.com/half-t/zmq_ex/blob/master/lib/zmq_ex.ex#L42

GenServer is a loop. If you recursively loop inside handle_*, it can't process new messages ever.
E.g. The initiation in handle_info should return state with socket and let GenServer accept new messages.
Later send_loop can be replaced by handle_cast like this.

# API function
send_message(pid, msg) when is_binary(msg) do
  GenServer.cast(pid, {:send_msg, msg})
end

handle_cast({:send_msg, msg}, %{socket: socket}) do
  enc_reply = encode(reply)
  :gen_tcp.send(socket, enc_reply)
  {:no_reply, state}
end

In general, never put loops inside handle_*. Even when playing around :D

Move implementation details outside

ref: #11 #26

As @tomekowal suggested #7 (comment) pre-commit hook can be created:

mix format --check-formatted
MIX_ENV=test mix do compile --warnings-as-errors
mix test
mix credo --strict

I have no strong opinion on it. @Dreat @nenros up to you

Hey guys! I want to participate a little bit, but I am not sure what is the end goal.
Could you explain what the project goal is?
How is it going to be different from existing work https://hex.pm/packages?_utf8=%E2%9C%93&search=zeromq&sort=recent_downloads

Is the project goal to learn or to make something production ready?

In case you'd like to make it production ready, I suggest using connection library for permanent connections https://hex.pm/packages/connection
And ranch as TCP acceptor pool https://hex.pm/packages/ranch
It would make both currently open PRs unnecessary.
(I am not that familiar with ZeroMQ so please check if that makes sense)

Blocked by: #21

Remove IO.gets("Please enter something: ") IO.get...