hammertater / treechop Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 7.0 4.87 MB

License: MIT License

Java 100.00%

treechop's People

Contributors

Stargazers

Watchers

Forkers

voidsong-dragonfly simgithub5 settingdust t0piy jovlax acgaming naji1368

treechop's Issues

Crash with SimpleFarming when a fruit tree log is broken

---- Minecraft Crash Report ----
// My bad.

Time: 28-11-20 20:24
Description: Exception in server tick loop

java.lang.NoSuchMethodError: net.minecraft.block.Block.func_180637_b(Lnet/minecraft/world/World;Lnet/minecraft/util/math/BlockPos;I)V
at ht.treechop.TreeChopMod.dropExperience(TreeChopMod.java:121) ~[?:0.7] {re:classloading}
at ht.treechop.TreeChopMod.onBreakEvent(TreeChopMod.java:90) ~[?:0.7] {re:classloading}
at net.minecraftforge.eventbus.ASMEventHandler_5_TreeChopMod_onBreakEvent_BreakEvent.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-3.0.5-service.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) ~[eventbus-3.0.5-service.jar:?] {}
at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:566) ~[?:?] {re:classloading}
at net.minecraft.server.management.PlayerInteractionManager.func_180237_b(PlayerInteractionManager.java:230) ~[?:?] {re:classloading}
at net.minecraft.server.management.PlayerInteractionManager.func_229860_a_(PlayerInteractionManager.java:220) ~[?:?] {re:classloading}
at net.minecraft.server.management.PlayerInteractionManager.func_225416_a(PlayerInteractionManager.java:190) ~[?:?] {re:classloading}
at net.minecraft.network.play.ServerPlayNetHandler.func_147345_a(ServerPlayNetHandler.java:929) ~[?:?] {re:classloading,pl:accesstransformer:B}
at net.minecraft.network.play.client.CPlayerDiggingPacket.func_148833_a(SourceFile:40) ~[?:?] {re:classloading}
at net.minecraft.network.play.client.CPlayerDiggingPacket.func_148833_a(SourceFile:10) ~[?:?] {re:classloading}
at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) ~[?:?] {re:classloading}
at net.minecraft.network.PacketThreadUtil$$Lambda$8375/2103535327.run(Unknown Source) ~[?:?] {}
at net.minecraft.util.concurrent.TickDelayedTask.run(SourceFile:18) ~[?:?] {re:classloading}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) ~[?:?] {re:mixin,re:computing_frames,re:classloading}
at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:733) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.func_213166_h(MinecraftServer.java:159) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:716) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:710) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) ~[?:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:695) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:645) [?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) [?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer$$Lambda$7381/885270011.run(Unknown Source) [?:?] {}
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

Using any multimedia key's causing switching chopping/felling mode

I haven't assigned any multimedia key to this action in settings, even not allowed to change mode in config

Respect tool enchantments

Things like "silk touch" and "fortune" should affect what items drop when felling a tree.

Durability doesn't go down

Describe the bug
I love the mod, but I was chopping trees with a wood ax and the durability never went down, even when I felled a huge tree. I don't think it should break from each wood chopped, but not going down at all seems like something is wrong

Versions

Version: TreeChop-1.16.4-0.5
Forge: forge-35.1.4

Use localized strings

...so that different language settings can be supported.

Suggestion: add config to change tools blacklist to a whitelist

...in case some crazy fools want to require an axe for chopping.

Respawn NPE

Minecraft v1.16.5
Forge v36.0.1
Tree Chop v0.12.1
Exotic Birds v1.0.3

I died on my server, but every time I clicked respawn, it would reappear. The server log also printed out an error every time the button was clicked. It mentions both this mod and Exotic Birds.
Error Log

Also reported to https://www.curseforge.com/minecraft/mc-mods/exotic-birds/issues/63

Suggestion: make Silent Gear saws (and similar items) do multiple chops instead of breaking the whole tree

...as suggested by this nice person.

Most can be made compatible using the "overrides" config, but note that when chopping is disabled, overridden items will revert to their default behavior. Ideally, mods can enable compatibility by implementing ht.treechop.api.IChoppingItem.

Some mods with super axes:

https://github.com/SlimeKnights/TinkersConstruct / https://www.curseforge.com/minecraft/mc-mods/tinkers-construct
- only handaxes are implemented as of 4-21-2021; no extra chops for these guys
https://github.com/SilentChaos512/Silent-Gear / https://www.curseforge.com/minecraft/mc-mods/silent-gear
https://github.com/astradamus/PracticalTools / https://www.curseforge.com/minecraft/mc-mods/practical-tools
https://github.com/DoubleDoorDevelopment/Lumberjack / https://www.curseforge.com/minecraft/mc-mods/lumberjack
https://github.com/mekanism/Mekanism / https://www.curseforge.com/minecraft/mc-mods/mekanism (also look at expansion mods)
- blacklist atomic disassembler
https://github.com/CoFH/ThermalInnovation / https://www.curseforge.com/minecraft/mc-mods/thermal-innovation
- note that 1.16 version does not seem to be open source
https://www.curseforge.com/minecraft/mc-mods/lumbercraft

1.12.2:

Fabric:

Let clients use their own item/block blacklists

...in case an item causes a crash when used to chop (#6, #25) but the player doesn't have access to the server config.

Or, give server ops the ability to (permanently?) modify config values in-game.

Mod doesn't detect if block is connected to a tree or if the block has leaves around it

I just made a test that I do with every timber-like mod and built a wall with some planks and no leaves touching it. For some reason the mod turns on even when i'm just chopping a wall. The mod should detect if the block the player is chopping is connected to leaves and/or somehow detect if it's a tree.

Don't partially fell trees that exceed max tree size

It leaves big floating blobs that are too high to reach.

Tree chop enable/disable is connected to all my utility keys

My volume buttons specifically are connected to Tree Chop's enable and disable feature, but are not bound to the feature and aren't able to be unbound. I have NO key bound to the toggle features and my apostrophe key is bound to cycle sneak behavior. Very annoying to change my volume while playing and be forced to pick between my default volume and the amount that lets Tree Chop stay enabled.

Forge 35.1.10 MC 1.16.4 Tree Chop 0.11.1

I'm trying not to update many mods while playing as that can cause issues for servers, that's why my version is out of date.

Server Crash

Minecraft v1.16.5
Forge v36.0.1
Tree Chop v0.12.0

My server crashed while loading the mod.
Crash Report

Hi, me again!

Hey, sorry to bug you, but this mod was throwing a crash when I tried to launch it on a server;
my friends and I are playing as of current, so I will send you a log when no one's online so I can freely crash the server lol

Just making this issue while I can! I think the crash was happening during the preintializing or loading process

Not Working Server Side

https://pastebin.com/VEedHLR5

Suggestion: add visual indicators to show whether chopping and felling are enabled

...when looking at a block that can be chopped. Maybe add an option to show an explanation when a log is not considered "choppable" (e.g. "no connected leaves" or "connected leaves are not persistent")

Allow some persistent leaves to be broken when felling

Currently, persistent leaves (typically ones placed by the player) are not broken when felling. Some mods make leaves persistent so that they don't decay when not directly adjacent to other leaves blocks. For example, Biomes O' Plenty's palm leaves.

Either allow all persistent leaves to be broken, or configure breaking persistents on a per-block basis.

Need models for horizontally-connected chopped logs

...as mentioned in #2 (comment).

There will still be weird-looking cases, e.g. when logs are diagonally connected.

Doesn't work on port-forward server

Mod is installed correctly on forge server client and server for myself and other players. No crash or mod failure to load for server or client start up. Mod works perfectly fine in single player world i.e works fine client side, but nothing on the server. Same issue with sapling planting mod.

List of modded trees that leave floating blocks

Arboria

#257

Biomes O' Plenty:

Palm trees (#31) (leaves are marked persistent)
Mystic grove oak trees (https://www.curseforge.com/minecraft/mc-mods/treechop?comment=514)

Oh The Biomes You'll Go:

Mangroves (#43)
Redwoods (#32)
Baobabs (#85)
Nightshades and others that contain non-log blocks (#188)

BetterEnd

See https://www.curseforge.com/minecraft/mc-mods/treechop?comment=244

Regions Unexplored

Sculkwood trees (leaves are marked persistent)
Brimwood trees (#242)
Redwood trees (#242)
(Visual problems) Bamboo trees

TerraFirmaCraft

Lots of trees

Tropicraft

Lots of trees (#209)

Mystic's Biomes

All of em

The Twilight Forest

All the big ones are whacky

Tan's Huge Trees

All of em

~~Autumnity:~~

Fixed! ~~All of 'em (waiting on team-abnormals/autumnity#46)~~

~~Atmospheric:~~

Fixed! ~~All of 'em (waiting on team-abnormals/atmospheric#81)~~

Allow tree limbs to be chopped without breaking the rest of the tree

Port to Fabric

Project MMO doesn't give wood cutting xp when chopping

...as realized in #34.

Make "onlyBreakTreesWithLeaves" config default to "true", or add an in-game toggle.

I understand it was deliberately left as false to keep with the original behavior of the mod (as per the comments in #2), but I think the commonly expected behavior of a tree-cutting mod is to only work on leaved logs by default.

I went to change the setting immediately after trying to deconstruct a wooden structure.

Sneaking or using the toggle keybind lets you work around this while keeping the setting enabled, but perhaps a better solution might be to implement a third state or separate toggle to enable/disable this functionality specifically.

[0.8] Chopped logs don't spawn drops

BYG Redwood Trees not fully breaking the entire tree

Consolidate item drops, xp drops, and block breaks

Instead of harvesting each block individually, combine their item and xp drops into fewer stacks.
Instead of syncing each block state change, send clients a list of block positions to change themselves.

Block item drops "don't spawn" or spawn far away

Currently, block items are dropped on the first chop*. Because the block is immediately replaced by a chopped block, there is nowhere for the item to go, so it gets pushed in a random direction. Sometimes this makes the dropped item unreachable or hard to find.

*this is because the chopped log has no memory of the block it used to be; this behavior will change eventually when each log block has its own corresponding chopped block

Suddenly stops functioning

Hey! I'm having a weird issue that came about yesterday
I was using the mod like normal, before my world seemed to lag behind for a bit? and when it resumed I was breaking wood as normal, no cool features. Doubled checked to make sure it was toggled and I wasn't crouching, and making another world didn't fix it. Any clue what could've caused this?

Too much Project MMO xp awarded when chopping player-placed logs

Project MMO normally reduces XP awarded for breaking player-placed blocks. That's not happening when chopping.

OTBYG's Mangrove trees leave floating blocks

...as mentioned in https://www.curseforge.com/minecraft/mc-mods/treechop?comment=105.

Let trees fall over when felled

...and either splatter log blocks all over the ground, or turn into item drops on impact.

Suggestion: "Inverse" mode where tree chopping only happens while sneaking (or other keybind)

Basically the opposite of when sneaking does normal log breaking

Server Crashes due to a server tick loop

Server seems to crash when trees are chopped with an item that can mine multiple blocks at once such as mekanism.

Attached a crash log.
crash-2020-12-22_12.58.26-server.txt

HT's Treechop Conflict with Enderio/EnderCore

Issue Description:

Creation of ghost blocks when simple machines are places then broken in survival mode

What happens:

Simple Alloy Smelter, SAG Mill, or Stirling Generator is placed, player attempts to break previously placed simple machine with pickaxe, simple machine is turned into ghost block and cannot be removed.

What you expected to happen:

Simple Alloy Smelter, SAG Mill, or Stirling Generator is placed, player attempts to break previously placed simple machine with pickaxe, simple machine is broken and drops in block form so player can move to optimal position

Steps to reproduce:

IN SURVIVAL MODE

craft a Simple Alloy Smelter, SAG Mill, or Stirling Generator
Place crafted simple machine in world
Break previously placed simple machine with pickaxe
...

Affected Versions:

EnderIO: 1.12.2-5.2.66
EnderCore: 1.12.2-0.5.76
HT's Treechop: 1.12.2-0.11.2
Minecraft: 1.12.2
Forge: 14.23.5.2855
SpongeForge? no
Optifine? no
Single Player and/or Server? Single Player

Your most recent log file where the issue was present:

file:///Users/zac/Library/Application%20Support/gdlauncher_next/instances/Testing1/logs/latest.log

Cactus blocks are marked as "treechop:choppables"

Exp-dropping logs don't drop exp

Maybe some mods will have some log blocks drop experience when broken. We should accommodate this.

Make item drops configurable

Configuration options to add:

Whether blocks spawn item drops when first chopped
Whether the original block's item drops should only spawn when the chopped block is destroyed
Whether chopped logs spawn item drops when chopped
Whether chopped logs spawn item drops when destroyed

In all cases, item drops will be determined by loot tables.

Things this would enable:

Chopping could produce wood chips items instead of log items
Dropping a log item on first chop is a little awkward; it might be preferable to drop it when the chopped block is destroyed

Add server-side config override for "onlyBreakTreesWithLeaves".

As an administrator I would like to be able to disable this functionality for all players on the server.

Add config option to only break logs of the same type

...as mentioned by #2 (comment).

This is not default behavior because modded trees are sometimes composed of multiple types of logs, but it should be an option.

java.lang.StackOverflowError with Silent Gear hammer

Minecraft 1.16.4
Tree Chop version: TreeChop-1.16.4-0.7fixed.jar
Silent Gear ver: SilentGear-1.16.3-2.3.10+182.jar
Silent Lib ver: SilentLib-1.16.3-4.9.0+63.jar
Forge 35.1.7

To reproduce:

Have both Silent Gear and Tree Chop installed
Create any Silent Gear hammer
Make sure you are in survival mode, not creative
Use the hammer on a 3x3 area of stone

The wall fails to break, and the game crashes after a bit of time. Looking at the crash log, there seems to be some sort of infinite recursion with Silent Gear's onBlockStartBreak and HT Tree Chop's onBreakEvent.

Logs: https://gist.github.com/FreeFull/441f4b9e5e24c033b0a1b0426a1bb5c5

Don't make chopped wood particles when a log breaks on first chop

Suggestion: Changing textures

Could you use the stripped log textures from the specific block instead of that custom one you made?

Cost a little bit of work but you don't need to create any textures, and bonus it's easy to create resource packs for your mod.

Crashes when used on a dedicated server

Attached is the crash log.
Specific failure message indicates that treechop failed to load correctly, along with "java.lang.RuntimeException: Attempted to load class net/minecraft/client/multiplayer/PlayerController for invalid dist DEDICATED_SERVER".

crash-2020-12-11_13.58.55-fml.txt