Use http://devdocs.io/javascript/global_objects/object/getownpropertydescriptor and check get/set

Hi,

I'd need a deep mapToObject for a feature in joi, like :

[ 'a', 'a.b.c', 'a.b.d', 'a.b.c.d' ]

would become

{
  a: {
    b: {
      c: {
        d: true
      }
    },
    d: true
  }
}

Do you think it's something that might go into hoek ?

I think this is happening after i increase the timeout for payload. Default was 10 sec and for my service i had to make it 3 min and after that it comes once a while. I am guessing its waiting for some hanged request where there is no answer and somehow throw this exception.

/node_modules/hapi/node_modules/hoek/lib/index.js:407
throw new Error(msgs.join(' ') || 'Unknown error');
^
Error: Invalid nested use of protect.run()
at Object.exports.assert (/node_modules/hapi/node_modules/hoek/lib/index.js:407:11)
at internals.Protect.run (/node_modules/hapi/lib/protect.js:41:11)
at Object.exports.invoke (/node_modules/hapi/lib/handler.js:378:22)
at process (/node_modules/hapi/lib/request.js:349:17)
at internals.Request._reply (/node_modules/hapi/lib/request.js:374:5)
at timeoutReply (/node_modules/hapi/lib/request.js:290:22)
at Timer.listOnTimeout as ontimeout

When I run npm test, I get a failing test in #displayStack.

Trace:

$ npm test

> [email protected] test c:\Documents and Settings\apenneba\Desktop\src\hoek
> make test-cov

node node_modules/lab/bin/lab -r threshold -t 100


  .................................................x
  ...................................

 1 of 85 tests failed:

  1) Hoek #displayStack  should return the full call stack for display:
     expected 'null (c:\\Documents and Settings\\apenneba\\Desktop\\src\\hoek\\test\\index.js:601:30)' to include 'test/index.js:'
      at c:\Documents and Settings\apenneba\Desktop\src\hoek\test\index.js:602:33


Coverage: 0.00%

Code coverage below threshold: 0.00 < 100
make: *** [test-cov] Error 1
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

System:

$ specs node os
Specs:

specs 0.4
https://github.com/mcandre/specs#readme

npm --version
1.2.17

node --version
v0.10.3

systeminfo | findstr /B /C:"OS Name" /C:"OS Version"
OS Name:                   Microsoft Windows XP Professional
OS Version:                5.1.2600 Service Pack 3 Build 2600

Per #98 we should make it clear what this module is for.

Test case:
https://github.com/hapijs/hoek/blob/master/test/index.js#L514-L519

        it('returns a copy of defaults if options is true', function (done) {

            var result = Hoek.applyToDefaults(defaults, true);
            expect(result).to.deep.equal(result);  //Should be result and defaults
            done();
        });

Either Hoek.merge() should not be destructive or the documentation is wrong. My feeling is that it should not be destructive.

> var Hoek = require('hoek');
undefined
> var a = { a: 1 }
undefined
> var b = { b: 2 }
undefined
> var c = Hoek.merge(a,b)
{ a: 1, b: 2 }
> a
{ a: 1, b: 2 }

applyToDefaults should not destroy the defaults object when undefined is passed as the options parameter.

Current functionality:

var defaults = {
    a: 'foo'
};

Hoek.applyToDefaults(defaults, undefined);    // Returns null

Desired / Expected functionality
Hoek should either return the original defaults object or it should return an error and not allow undefined to be passed as an options parameter.

@wpreul what do you think?

Add -a code to the Makefile

hoek.transform blacklists on the keys in the map. what are you thoughts on allowing an option to whitelist?

so if the source has keys not defined in the map, then they just pass through to the result.

Hi, several times found loops like:

for (var i = 0, il = err.details.length; i < il; ++i) {
//...
}

we could make more intuitive/readable using functions, just looking the ".forEach"already know exactly what type of loop is:

var forEach = Hoek.forEach;

forEach(err.details, function(i) {
//...
});

forEach(err.details, (i) => {
//...
});

make any sense?

var a = Object.create(null);
var b = Object.create(null);

a.b = 'c';
b.b = 'c';

Hoek.deepEqual(a, b);

Results in a Object object has no method 'hasOwnProperty' error.

A quick glance through Hoek’s source shows that most of the type detection is done through instanceof, eg. instanceof RegExp, etc.

This means that values from different contexts, eg. RegExps generated from a different realm through Node.js’s vm module would not be detected correctly, as the RegExp constructor is different and thus the instanceof check would fail.

Instead, you should use Object.prototype.toString, by doing something like:

var getClass = Object.prototype.toString;
var className = getClass.call(object);
console.log(className); // "[object RegExp]"

This method instead detects the [[Class]] attribute of objects, which are constant across contexts.

Keys can contain a period, but the this causes a problem when specifying the chain to be used by reach()

> obj = { a : { '[email protected]': 1 } }
{ a: { '[email protected]': 1 } }
> Hoek.reach(obj, '[email protected]')
undefined

Can I submit a PR to allow a chain to be specified like this Hoek.reach(obj, 'a["[email protected]"]')

Plenty of the utilities are no longer used or are used in one place and should just me moved there. Stuff like toss() doesn't even work.

What do you think about including a function to allow partial application of arguments?
I think it could be a useful addition and can PR it if you would like to.

Example use case: currently I'm working on a plug-in where I need pass parameters when using async.series:

async.series([
      f1,
      f2,
      f3],
      callback);

I'd like to do something like the following without having to include lodash or underscore:

async.series([
      Hoek.apply(f1, request),
      Hoek.apply(f2, request),
      Hoek.apply(f3, request)],
      callback);

Thoughts?

Currently assumes input will be a printable ascii string. Need to handle any UTF-8 string.

Discovered during a misadventure with plugin.method with bind set:

This code in lib/index.js is vulnerable to Object.getPrototypeOf returning null:

            var proto = Object.getPrototypeOf(obj);
            if (proto.isImmutable) { // hoek/lib/index.js:45
                newObj = obj;
            }

The crash:

     TypeError: Cannot read property 'isImmutable' of null
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:45:22)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at Object.exports.clone (node_modules/hapi/node_modules/hoek/lib/index.js:66:37)
      at internals.Methods._add (node_modules/hapi/lib/methods.js:50:25)
      at internals.Methods.add (node_modules/hapi/lib/methods.js:23:49)
      at Object.root.method (node_modules/hapi/lib/pack.js:334:34)

I'm not sure what's being closed, there, but it's the _cache property of some object wearing:

• _allowStale
• _cache
• _dispose
• _itemCount
• _length
• _lengthCalculator
• _lru
• _lruList
• _max
• _maxAge
• _mru

Would that be from lru-cache?

See: hapijs/hapi#1128

I think the description of the module should be rephrased as it is not a general purpose utility.

The Hoek general purpose node utilities library is used to aid in a variety of manners.

This line clearly conflicts with the paragraph at the top:

If you're looking for a general purpose utility module, check out lodash or underscore.

applyToDefaults will return null if options is undefined

> var options = undefined
undefined
> var defaults = { host: 'localhost', port: 10700, options: { cors: true } }
{ host: 'localhost', port: 10700, options: { cors: true } }
> var config = Hoek.applyToDefaults(defaults, options)
null

If a single error is passed in as the message to a hoek.assert(condition, msg) call, it should just throw that error. That would let us do stuff like:

hoek.assert(condition, Boom.badRequest('bad, bad request'));

and have the Boom error thrown, instead of a generic Error with 'bad, bad request' as its message, which is the current behavior if you do that.

ran in to this while implementing domains.

underscore's clone doesn't have this problem, i looked at what they are doing and they reference like 7 other internal functions so it's not super easy to pull out.

I'm pretty sure tests are not needed in production. :)
They just bloat project dependencies, install time, use bandwidth, etc.

You could either use the package.json files property to whitelist files for production or .npmignore to blacklist unneeded ones.

For more info on .npmignore and an automatic generator see https://github.com/inikulin/dmn

Same as Timer but uses process.hrtime() instead of Date.now()

What would you think of accepting negative indexes on Hoek.reach() ?
There's currently no way to take for example the last element of an array.
I know that would involve a bit more complexity but it would make hapijs/joi#507 doable, since reach is kind of hot code, it's up to you.