harish-io / impressionist Goto Github PK

Change the skew & scale controls to use mouse interactions, as opposed to using knobs.

Hey. I just recently found Impressionist. I've been working on a similar project for authoring ImpressJS presentations called Strut. It's also based on Twitter bootstrap but makes use of RequireJS and BackboneJS in order to keep the code modular and object oriented.

Maybe we can collaborate? I think both projects are about on par as far as features go.

Here is Strut if you want to see what I've got so far:
http://www.youtube.com/watch?v=zA5s8wwme44&feature=share
https://github.com/tantaman/Strut

live demo on github:
http://tantaman.github.com/Strut/client/web/index.html

Hi there,
I haven't had time to check out the rest of the source at all, but on preliminary scan, the file 'alpha3/server/generateArchive.php' has a rather glaring security error.
Simply put, this file is allowing any unvalidated, user-specified file name to be written to be written to with any unvalidated, user-specified data. Here's what happens if, for example, the following inputs are passed:
$_POST["data"] = "Just a test! Hope this doesn't work" $_POST["filename"] = "../../index"

result: http://www.hsivaram.com/impressionist/ (I didn't delete any data; there was no index page here before.)

One immediate fix would be to strip out dots and slashes from the file name to be written to. This should be done immediately, and retroactively -- fix this in all the previous versions you're hosting too!

I didn't want to submit a pull request since I have a feeling this may be an issue elsewhere. I would be verrry careful for the time being - your personal server is running code with some glaring security holes. My advice would be to take down your hosted copy immediately until you can resolve all of these with certainty.

Hi, i'm planning on using Impressionist on http://www.youblob.com/ as a free tool.
Just wanted to let you know :)

The site is a community for 3d printing, robotics, electronics, DIY and lots of other stuff.
Site not released yet though.

Using chrome on OS X.

After saving, choose "Open" from the file menu.

Listed saves don't stay selected so clicking "ok" doesn't have anything to act on.

Double clicking (as per instructions) also fails to open anything.

I assume these probably have the same underlying issue.

It's not addable and editable after I create some texts.

Not sure what's happening , it's still happening after I "open" the slide file,
I can't add new text in the slide after the issue happened.

Here's the demo for how it broken.
http://screencast.com/t/qQyX5XGiZY

There haven't been any commits for the past 8 months.

is this repo dead? I have some contributions but I'm not sure if I should help with another repo.

In german there are some chars called "Umlaute" like ä,ü,ö. Also in other Languages e.g. danish use characters like å,æ, ø or Æ. Impress does not recognize these characters. There are the following encoding-errors "rüß".

It will be more easier to edit the slide if we could have page-up/page-down support to switch slides.

First off, the naming is confusing. It should be named »Slide view« and »Overview«.

The switch view control should be a contextual toggle:

• when you are in slide view, the button should say »Overview« (maybe with icon) and clicking on it should directly lead to the overview, no dropdown.
• when you are in overview, the button should say »Slide view« (maybe with icon) and clicking on it should directly lead to the slide view, no dropdown.

This also solves the issue that you don’t know in which view you are, even when you click to reveal the dropdown.

It would be great if there was a way to support MathJax. I suppose it should be fairly easy since one should just add the MathJax JS in the header and some dedicated css hacks. The tricky part would be to switch between LaTeX compiled and LaTeX source code when one clicks on a text box.

On a more general level, it would be nice if we could have some sort of markdown language to easily format text. The markdown parser from mathoverflow is rather standardized and opensource...

Use the slide thumbnail also in the presentation view layer

It's annoying to click the text first than click the content area every time I want to create a text,
it's better to create the text when double click by default I think.

What is the license for this project and it's source code?

MIT? Apache license?

It would be neat if it could become any open license that permits commercial use :-)

Instead of permanently being in the same bar for all the elements, they should be directly at the element. Like with Photoshop or Gimp, rotating an element is possible by clicking it, then an edge becomes a rotation arrow which you can then drag to rotate. This is much easier to operate than the dislocated rotate and skew controls.

Similar with slide depth and slide scale: the resulting value is already displayed below the slide itself, so why not put the control directly there as control and value display. (Aside: slide depth could be more easily identifiable by changing the color brightness of the blue which frames the slide: brighter=higher, darker=deeper. And similarly slide scale should be directly represented in the overview.)

And the same with the text controls: These are useless unless text is selected. So they should not be displayed while useless. And when some text is selected, they should be displayed close to that element, as a little popover in place.

Also see principles of proximity: grouping

Basically: You can get rid of the black controls bar (also the black bar on the bottom, what does it do?)
In presentation view, the remaining element is just the view switcher, which can be placed in the blue top bar.
In orchestration view, the preview and download buttons can also be placed in the blue top bar. They are even similar to the »file« menu.

All the menu items are center aligned as they are inheriting that property from the ancestor(body) and doesn't look good.

Hey Harish and guys who contributing to the code,
Few major issues:

1. Text align doesn't work.
2. Headings doesn't work.
3. Added images show up really small. (also need ability to resize them)
4. Old presentations merges with new one's in preview.
5. Close buttons doesn't work. #43
6. After adding new header, Style needs to be set again.
7. And you can somehow edit the text in preview :)

That's it for now.

Hi, I'm not sure if I'm doing something wrong or not but I can't seem to get the preview and save working. I took a look at the other solutions to this issue and tried changing the permissions to all the files, copying the files/folders to the output folder, and disabling popup blocking. I'm not getting any errors just when I click the buttons nothing happens.

I'm using Windows 7 and Google Chrome and I just downloaded this today so it should be the most up to date version.

Also I wanted to know if I can get this working would it be okay to use the presentation I make for a school project?

Thanks,
Mark

I am still not able to preview or download my presentation. I continue to get these error messages using Google Chrome on Mac OSX:

XMLHttpRequest cannot load file://localhost/Users/chris/Desktop/hsivaramx-Impressionist-4af0fad/alpha3/server/generatePreview.php. Origin null is not allowed by Access-Control-Allow-Origin.

XMLHttpRequest cannot load file://localhost/Users/chris/Desktop/hsivaramx-Impressionist-4af0fad/alpha3/server/generateArchive.php. Origin null is not allowed by Access-Control-Allow-Origin.

Sorry to post this again, but I tried all of the suggested fixes and continue to get this issue.

Text: Font: Inserting a special character sets font to Times

Experienced: Im creating a slide with bullet points. When i insert a special character for a bullet point, the font appears to reset to times new roman.

Expected: The font should remain visually the same as when its being edited to when its not being edited.

Repro:

1. Open the App
2. Create some Text
3. Insert a special character at the beginning of the line, such as ♦ (Arial U+2666)
4. De-select the line. Observe the font change.

Version: Alpha3
Images:
Screenshot of text with it selected
Screenshot of text not selected

Browser: Google Chome
OS: Windows 7 Enterprise SP1

It would be nice to have 2-3 files I can open in Impressionist right away to test things out fast.
cheers!

I can't seem to get the preview or download functions to work at all. I saw in the video on Youtube that Previewing should just open a new tab with the presentation in it, but it doesn't work for me. When i try right clicking on preview and opening in a new tab, it just opens a new project.

EDIT: I am running in Google Chrome on Mac OS X and I'm using the Alpha 2 branch files.

It's better to provide a option for user to export the presentations as a file and allow them to import the exported file.

There's two benefits for this ,

one is to open the presentation in another computer and edit it ,
another one is for testing , if anyone find any bugs , they could export the content to us.

I think logout button is needed below My presentations and Facebook login is cool but hardly working for me. I would suggest using simple login a side from Facebook. And you're taste is good for choosing Flat UI for design :)

GUI: Presentation View: Inserting an image renders most buttons inactive

Impact: If the user has not inserted any text into the slide and decides to insert an image, further creation of the presentation is blocked. The presentation must be refreshed.

Experienced: I am creating a presentation and i want an image. After inserting the image, the only buttons that are active are the Bold, Underline, Italic, and Justify buttons. All other buttons are inactive and cannot be clicked on. This was even after i tried to click elsewhere on the canvas.

Expected: After images are inserted into a presentation, it should not block continued progress in creating the presentation.

Repro:

1. Open the App
2. Click on the insert image button
3. Insert an image into the presentation by supplying a URL ie: https://a248.e.akamai.net/assets.github.com/images/modules/about_page/octocat.png?1340659530
4. Notice now after the image has been inserted, the buttons can no longer be pressed.

Workaround:
If text has been inserted into the slide, a user can select the text after inserting an image in order to be able to use buttons in the GUI.

Additional Information:
Google Chrome Version 22.0.1229.94 m
Windows 7 Enterprise SP1
Impressionist Alpha 3

Why the project on Github looks completely different to demo?

For example , if I see this view , I would assume to click delete to remove this.
http://screencast.com/t/cLepLBdqySG

And there's a great JS plugin that made key binding easier.
https://github.com/madrobby/keymaster

I think it will be a good idea to move the code from alphaX folder into root and tag each version.

remoteStorage.js is a client-side library to add remoteStorage support to your client-side app. There is a tutorial for example usage and more info in the readme of the repository.

Basically, remoteStorage is an open standard to seperate web apps from per-user data storage – whereas at the moment, most web apps are an app+storage package deal. Check the website of the unhosted movement for more info, and feel free to join our chat room if you have questions.

And yeah – big props on Impressionist! I love it and would like to help more, but at the moment I only have time for evaluation & suggestions. :)

When we drag and drop ,
the item is required for top have to be less than 400 and left have to be less than 600 ,

That doesn't make any sense for my 1920*1080 screen , is there's any concern for this ?

I would suggest to remove this restriction.

Use shift+enter to enter a new ln and output
should be reasonable .

It would be great to move the slides via drag and drop to reorder.

The »exit« entry in the file menu seems redundant, as you can just close the window.

As for the rest, the functions should be directly in the blue bar, as monochrome white icons.
Clicking »Open« should reveal the existing documents as dropdown, not as modal.

Regarding »Save« and »Save as …« – first off, stuff should be autosaved always. User input is the most important thing in an app, you can’t just not save it (see Dropbox, Etherpad and I think new Mac apps also do it).

The name of the presentation should be displayed in the blue top bar, also editable. That way you quickly know what the document is that you edit.

How can I integrate charts support (maybe with Raphael.js or Google charts)??...maybe it would be interesting to include support for mind maps, here's a basic example but functional http://conceptmapp.com/ #

it would be nice to be ablt to switch to Code View

The subnav2 > div.container > div.nav-collapse > ul.nav is 30px too low, and thus hidden by mainfield. See screenshot.
Bypassed using
subnav2 > div.container > div.nav-collapse > ul.nav { margin-top: -30px; }

After logging in for the first time it presents a dialog asking you to create a new presentation.

There is a close button on this dialog. Clicking it does nothing.

Expected:
The dialog would go away and I would be able to explore whatever portion of the UI is explorable without a presentation.

Suggested fix:
Remove the close button when the user has no existing presentations.

Alternate fix:
Provide some feedback that the user must create a presentation before proceeding.

Hey Harish,
I just interested in future updates, if there's going to be any. Because repo seems quite dead again ;D

Hello. The project has become very nice.
I'm still missing the integration of a big background image moving around when going through the slides (like on prezi).
Maybe we collect ideas where we'll put the upload button in the UI and discuss whether the images got to be accessible for everyone or just a single person.
At least we (and I) should know if it's already feasible with impress.js.

Thank you!

I cannot change 'this is sample text'

it's always back to default..

I use google chrome

In case you don’t know Awwation yet (demo), it’s another editor for impress.js
Not sure if the bases are too different or if it would make sense to join forces.

Hey Harish,
I really don't want this repo dead :D I know you probably have more important things to do. So maybe you should pass this repo to someone else or just maybe fix the last bugs so it will become usable and extendable from that.

Best regards, Vaidas