harrystech / cronut Goto Github PK

I don't know why the ping requests need to be so locked down. I think just sending the job token over https is probably secure enough - we could add an optional shared API key too.

I have the following issue with cron jobs run once a day:

When I save the job, the next scheduled time appears in EDT time, but I have to save the job with a cron expression written in UTC time (so a job at noon would be * 16 * * *). That's no big deal (and may be preferable), but when the job gets pinged, the verification / next scheduled time-setting behavior appears to be four hours off (I'm in EST/EDT, so the mismatch is the same as the offset from UTC).

The specs test for a cron job that is running every ten minutes, so if Harry's is never running once-a-day jobs, I can see how this might be broken. I'm happy to write a PR with specific tests and a fix (if it is indeed broken), but in order to not generate any new compatibility problems with existing users of Cronut, I have a couple questions:

1. Are cron expressions in Cronut meant to be expressed in UTC or the local time zone?
2. Is Harry's currently using any cron jobs that are only run once a day? If so, can you show me an example from your setup? I have a job I've been executing daily at EST midnight, and it either fails for being run too early (if I write the cron as UTC), or it fails for being run too late (if I write the cron as EST and ignore the returned time in the interface).

Another question about potential functionality that I'm going to use that might make sense upstream: is there openness to making the IP whitelist optional?

Hard to tell what happened but in the current master version of cronut ping requests fail. It might be strong parameter requirements in rails 4.

Should be fairly straightforward to fix if we write some request specs.

Is the Harry's team open to building some very simple auth with a mechanism rather than HTTP? I'm proposing to do email/password auth with http://github.com/thoughtbot/clearance, which is much lower overhead than Devise, but still allows for email/password auth for multiple users.

I'm going to end up doing this for our own deployment of Cronut, so wanted to check.