hartenthaler / hh_imprint Goto Github PK

With webtrees 2.1.9, XAMPP 8.0.25 and only the hh_imprint module enabled I get this fatal error

Fatal error: Uncaught Fisharebest\Webtrees\Http\Exceptions\HttpBadRequestException: The parameter “tree” is missing. in D:\xampp\htdocs\webtrees-test\app\Validator.php:363 Stack trace: #0 D:\xampp\htdocs\webtrees-test\modules_v4\hh_imprint\module.php(297): Fisharebest\Webtrees\Validator->tree() #1 D:\xampp\htdocs\webtrees-test\resources\views\layouts\default.phtml(140): Fisharebest\Webtrees\Module\PrivacyPolicy@anonymous->getFooter(Object(Nyholm\Psr7\ServerRequest)) #2 [internal function]: Fisharebest\Webtrees\View::{closure}(Object(Fisharebest\Webtrees\Module\PrivacyPolicy@anonymous), '_hh_imprint_') #3 D:\xampp\htdocs\webtrees-test\vendor\illuminate\collections\Collection.php(695): array_map(Object(Closure), Array, Array) #4 D:\xampp\htdocs\webtrees-test\resources\views\layouts\default.phtml(141): Illuminate\Support\Collection->map(Object(Closure)) #5 D:\xampp\htdocs\webtrees-test\app\View.php(183): include('D:\\xampp\\htdocs...') #6 D:\xampp\htdocs\webtrees-test\app\View.php(278): Fisharebest\Webtrees\View->render() #7 D:\xampp\htdocs\webtrees-test\app\Helpers\functions.php(145): Fisharebest\Webtrees\View::make('layouts/default', Array) #8 D:\xampp\htdocs\webtrees-test\app\Http\ViewResponseTrait.php(54): view('layouts/default', Array) #9 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\HandleExceptions.php(171): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->viewResponse('components/aler...', Array, 400) #10 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\HandleExceptions.php(99): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->httpExceptionResponse(Object(Nyholm\Psr7\ServerRequest), Object(Fisharebest\Webtrees\Http\Exceptions\HttpBadRequestException)) #11 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #12 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\BaseUrl.php(73): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #13 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\BaseUrl->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #14 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\ReadConfigIni.php(68): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #15 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\ReadConfigIni->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #16 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\SecurityHeaders.php(48): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #17 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\SecurityHeaders->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #18 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\EmitResponse.php(57): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #19 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\EmitResponse->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #20 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(118): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #21 D:\xampp\htdocs\webtrees-test\app\Webtrees.php(275): Middleland\Dispatcher->dispatch(Object(Nyholm\Psr7\ServerRequest)) #22 D:\xampp\htdocs\webtrees-test\app\Webtrees.php(262): Fisharebest\Webtrees\Webtrees::dispatch(Object(Nyholm\Psr7\ServerRequest), Array) #23 D:\xampp\htdocs\webtrees-test\index.php(51): Fisharebest\Webtrees\Webtrees->httpRequest() #24 {main} thrown in D:\xampp\htdocs\webtrees-test\app\Validator.php on line 363

I have translated the header "Copyright" in Dutch into "Auteursrecht".

But instead of "Auteursrecht" I see "Copy right" (in English, with a space)::

A remark: using "IMPRINT" as english translation for "IMPRESSUM" is not correct on a website. The correct translation is "LEGAL NOTICE" or (less common) "LEGAL DISCLOSURE".

See e.g.
https://language-boutique.de/naithani/blogpost/impressum-auf-englisch.html
https://fluentlylegal.com/was-heist-impressum-auf-englisch/
https://superior-english.com/2020/12/09/wie-uebersetzt-man-impressum-ins-englische/

In the imprint the text under the heading Respondible person is the text:
This website is operated by the following responsible person:

This can be shortened to:
This website is operated by:

In the imprint the word eMail is not translated.

One translated string is not used: other

In Dutch I translated it with overig, but it shows andere.

Under the heading Respondible person there are three items that all relate to the Respondible person. Therefore, the text or respondible person after 'Sex' can be removed.

Saving the module preferences with simple email link disabled, causes an error:
ErrorException: Undefined index: simpleEmail in D:\xampp\htdocs\webtrees-test\modules_v4\hh_imprint-main\module.php:166 Stack trace: #0 D:\xampp\htdocs\webtrees-test\modules_v4\hh_imprint-main\module.php(166): Fisharebest\Webtrees\Webtrees::Fisharebest\Webtrees\{closure}(8, 'Undefined index...', 'D:\\xampp\\htdocs...', 166, Array) #1 D:\xampp\htdocs\webtrees-test\modules_v4\hh_imprint-main\module.php(150): class@anonymous->postAdminActionSave(Array) #2 D:\xampp\htdocs\webtrees-test\app\Http\RequestHandlers\ModuleAction.php(85): class@anonymous->postAdminAction(Object(Nyholm\Psr7\ServerRequest)) #3 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\RequestHandler.php(54): Fisharebest\Webtrees\Http\RequestHandlers\ModuleAction->handle(Object(Nyholm\Psr7\ServerRequest)) #4 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\RequestHandler->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #5 D:\xampp\htdocs\webtrees-test\app\Module\HitCountFooterModule.php(154): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #6 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Module\HitCountFooterModule->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #7 D:\xampp\htdocs\webtrees-test\app\Module\CheckForNewVersion.php(115): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #8 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Module\CheckForNewVersion->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #9 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\CheckCsrf.php(80): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #10 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\CheckCsrf->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #11 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(118): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #12 D:\xampp\htdocs\webtrees-test\app\Webtrees.php(275): Middleland\Dispatcher->dispatch(Object(Nyholm\Psr7\ServerRequest)) #13 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\Router.php(153): Fisharebest\Webtrees\Webtrees::dispatch(Object(Nyholm\Psr7\ServerRequest), Array) #14 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\Router->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #15 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\BootModules.php(60): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #16 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\BootModules->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #17 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\RegisterGedcomTags.php(54): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #18 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\RegisterGedcomTags->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #19 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\LoadRoutes.php(75): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #20 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\LoadRoutes->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #21 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\CheckForNewVersion.php(65): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #22 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\CheckForNewVersion->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #23 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseTransaction.php(45): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #24 D:\xampp\htdocs\webtrees-test\vendor\illuminate\database\Concerns\ManagesTransactions.php(29): Fisharebest\Webtrees\Http\Middleware\UseTransaction::Fisharebest\Webtrees\Http\Middleware\{closure}(Object(Illuminate\Database\MySqlConnection)) #25 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseTransaction.php(46): Illuminate\Database\Connection->transaction(Object(Closure), 3) #26 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UseTransaction->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #27 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\DoHousekeeping.php(73): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #28 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\DoHousekeeping->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #29 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseTheme.php(69): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #30 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UseTheme->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #31 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\CheckForMaintenanceMode.php(51): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #32 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\CheckForMaintenanceMode->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #33 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseLanguage.php(71): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #34 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UseLanguage->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #35 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseSession.php(78): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #36 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UseSession->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #37 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UpdateDatabaseSchema.php(57): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #38 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UpdateDatabaseSchema->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #39 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\UseDatabase.php(118): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #40 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\UseDatabase->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #41 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\BadBotBlocker.php(233): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #42 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\BadBotBlocker->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #43 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\CompressResponse.php(73): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #44 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\CompressResponse->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #45 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\ContentLength.php(40): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #46 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\ContentLength->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #47 D:\xampp\htdocs\webtrees-test\vendor\middlewares\client-ip\src\ClientIp.php(65): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #48 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\ClientIp.php(47): Middlewares\ClientIp->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #49 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\ClientIp->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #50 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\HandleExceptions.php(90): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #51 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #52 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\BaseUrl.php(79): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #53 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\BaseUrl->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #54 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\ReadConfigIni.php(68): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #55 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\ReadConfigIni->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #56 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\SecurityHeaders.php(48): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #57 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\SecurityHeaders->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #58 D:\xampp\htdocs\webtrees-test\app\Http\Middleware\EmitResponse.php(57): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #59 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(136): Fisharebest\Webtrees\Http\Middleware\EmitResponse->process(Object(Nyholm\Psr7\ServerRequest), Object(Middleland\Dispatcher)) #60 D:\xampp\htdocs\webtrees-test\vendor\oscarotero\middleland\src\Dispatcher.php(118): Middleland\Dispatcher->handle(Object(Nyholm\Psr7\ServerRequest)) #61 D:\xampp\htdocs\webtrees-test\app\Webtrees.php(275): Middleland\Dispatcher->dispatch(Object(Nyholm\Psr7\ServerRequest)) #62 D:\xampp\htdocs\webtrees-test\app\Webtrees.php(262): Fisharebest\Webtrees\Webtrees::dispatch(Object(Nyholm\Psr7\ServerRequest), Array) #63 D:\xampp\htdocs\webtrees-test\index.php(51): Fisharebest\Webtrees\Webtrees->httpRequest() #64 {main}

If there is no tree visible for visitors an error is shown: Parameter „tree“ is missing.

So do not use this custom module at the moment if all your trees are hidden for visitors.

The mail link in the imprint contains a hard coded website URL:

check this with the developer of the "modern" theme

Alignment problem of the hh_imprint module (2.1.15.1) with the Rural theme:

Are the MO files really needed for translation?

I ask this because it seems that other modules (like webtrees-fancy-treeview/resources/lang/) don't need them.

The Imprint looks fine in all themes, except the Rural theme;

Example with default webtrees theme:

Example with Rural theme: