Giter VIP home page Giter VIP logo

Comments (6)

tiilikainen avatar tiilikainen commented on August 16, 2024 1

I've just checked in a fix to the regex. However, with that there is still a configuration issue in the given example. If the name AmazonLinux2-EKS-1.27 is used as it, you get the following validation error:

InvalidParameterValueException: The value supplied for parameter 'distributions[0].amiDistributionConfiguration.name' is not valid. The EC2 AMI name must contain '{{ imagebuilder:buildDate }}' to ensure that the name will be unique.

So the name needs to have {{ imagebuilder:buildDate }} in there, such as AmazonLinux2-EKS-1.27-{{ imagebuilder:buildDate }}, to make it unique for each build.

And according to the documentation:

The Output AMI name is optional. If you provide a name, the final output AMI name includes an appended timestamp of when the AMI is built. If you do not specify a name, Image Builder appends the build timestamp to the recipe name. This ensures unique AMI names for each build.

But it looks like if you are calling the API directly instead of the console, you'd need to add the build date variable yourself which seems to be the case here.

Correct, that is the way it behaves, and yes, we do have to add that string to the end. Sorry about leaving that out of the original issue, but thank you for understanding my intent anyway. :)

from terraform-provider-aws.

github-actions avatar github-actions commented on August 16, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

from terraform-provider-aws.

acwwat avatar acwwat commented on August 16, 2024

I've just checked in a fix to the regex. However, with that there is still a configuration issue in the given example. If the name AmazonLinux2-EKS-1.27 is used as it, you get the following validation error:

InvalidParameterValueException: The value supplied for parameter 'distributions[0].amiDistributionConfiguration.name' is not valid. The EC2 AMI name must contain '{{ imagebuilder:buildDate }}' to ensure that the name will be unique.

So the name needs to have {{ imagebuilder:buildDate }} in there, such as AmazonLinux2-EKS-1.27-{{ imagebuilder:buildDate }}, to make it unique for each build.

And according to the documentation:

The Output AMI name is optional. If you provide a name, the final output AMI name includes an appended timestamp of when the AMI is built. If you do not specify a name, Image Builder appends the build timestamp to the recipe name. This ensures unique AMI names for each build.

But it looks like if you are calling the API directly instead of the console, you'd need to add the build date variable yourself which seems to be the case here.

from terraform-provider-aws.

github-actions avatar github-actions commented on August 16, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

from terraform-provider-aws.

github-actions avatar github-actions commented on August 16, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

from terraform-provider-aws.

github-actions avatar github-actions commented on August 16, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-provider-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.