haukex / ipc-run3-shell Goto Github PK

Some tests for this module check the exact number of warnings that a certain piece of code produces. Since Perl may add warnings in the future, that's not forward compatible, and sometimes it causes problems with backwards compatibility too:
http://www.cpantesters.org/cpan/report/fcf17bc0-03a4-11e5-83fe-dd35e14af301
Those tests should be changed so that they only check the warnings that are under the control of the module, and maybe also those warnings that have been present in Perl for a long time and are unlikely to be removed.

use warnings NONFATAL => ...; was not supported until Perl v5.8.
Affects tests 13_warn_fail.t and 20_opt_allow_exit.t, functionality of the module itself should not be affected.
See http://www.cpantesters.org/cpan/report/a6d1cb72-2d22-11e4-95a3-c8094a15a708

http://www.cpantesters.org/cpan/report/ad2dac3b-6c08-1014-a5ca-d6051481592f

Can't spawn "cmd.exe": No such file or directory at C:/strawberry163/perl/vendor/lib/IPC/Run3.pm line 408.

#   Failed test 'no warnings'
#   at t/13_warn_fail.t line 152.
#          got: '1'
#     expected: '0'
# Looks like you failed 1 test of 63.
t/13_warn_fail.t ........ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/63 subtests 

t/41_os_darwin.t ....... [...] defaults [...]
Domain com.apple.Safari does not exist
Command "defaults" failed: exit status 1 at t/41_os_darwin.t line 31
# Looks like your test exited with 25 before it could output anything.
t/41_os_darwin.t ....... Dubious, test returned 25 (wstat 6400, 0x1900)
Failed 3/3 subtests 

Workaround: If this is the only test failure, it's perfectly safe to force the module install anyway.

My Mac OS X specific tests rely too much on a desktop user running them and need to be updated accordingly.

see e.g. http://www.cpantesters.org/cpan/report/eb67af1a-26ef-11e4-b925-2beae0bfc7aa
Caused by use of defined-or operator // and possibly a few other things.
Either declare v5.10 as the minimum required version or update the code to make it backwards-compatible.

see e.g. http://www.cpantesters.org/cpan/report/e6675458-6c84-1014-808a-d1168ac59954

Use of uninitialized value $text in substitution (s///) at C:/strawberry/perl/vendor/lib/Win32/ShellQuote.pm line 84.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 25 just after 36.
t/13_warn_fail.t ....... 
Dubious, test returned 25 (wstat 6400, 0x1900)
All 36 subtests passed

IPC::Run3 >= 0.047 uses Win32::ShellQuote (see rjbs/IPC-Run3#5 and https://github.com/haarg/Win32-ShellQuote), which uses use warnings FATAL=>'all';, which seems to be what's causing argument lists with undef values to die. (Could be addressed in any of the three modules.)