Giter VIP home page Giter VIP logo

jukebox's Introduction

Hello, World!

Greetings. I'm a Software Engineer that usually does Back-end, System Administrator, DevOps Engineer, Cybersecurity Enthusiast, and most importantly, a Gamer.

Hazmi35's GitHub stats

jukebox's People

Contributors

ai-avalon avatar baskwo avatar billyaddlers avatar burakfati avatar dependabot-preview[bot] avatar dependabot[bot] avatar floxy-y avatar hazmi35 avatar ktsnowy avatar max-programming avatar mzrtamp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

jukebox's Issues

[BUG] Jukebox resuming queue timeout even if it doesn't need to

image

NodeJS version: 14.15.2 LTS
Bot version: 4.24.0

How to reproduce:

  1. Play a song
  2. Wait for Jukebox to connect to your voice channel
  3. Before the song starts to play and the start playing message is not sent, try to unmute, mute, deafen, or any voice state update event
  4. Bot resumes the music although it's not paused and throws TypeError: Cannot read property 'resume' of null

[Feature Request] Use discord-player

Hi there, I got many recommendations from my users about this.

So, I recommend you too to use this package as well, it's pretty powerful than before, because its no longer need API key and supports Spotify!

discord-player

Thanks❤️

Malformed cache when process is crashed

When the nodejs process crashed because of an error, the cache is not finished downloading and it generates a malformed cache.
Cache health checking can fix this issue maybe?

[Feature Request] Slash Command Support

Slash Commands are the new, exciting way to build and interact with apps on Discord.

With Slash Commands, all you have to do is type / and you're ready to use your favorite bot. Users can learn everything your bot does and easily find new features as you add them. Validation, error states, and helpful UI walks them through your commands, meaning they can get it right the first time, especially on mobile. You now have one more ally in the fight against your phone's autocorrect.

Slash Commands set your users up for success instead of confusion and frustration. They separate how users think and how your code works, meaning no matter how complex your codebase and commands may get, people who love your bot will find it approachable and easy to use.

About Multilingual Support

Currently, JukeBox outputs in English, but I would like to see support for multiple languages.
I'm Japanese and I'm willing to translate it into Japanese, so I'd appreciate it if you would consider it.

[BUG] Player still looping after the queue deleted (Queue Timeout).

Bot still looping queue (Repeat mode: ALL) & play the song(s) after queue deleted because there's no anyone in the voice channel.

NodeJS version: 14.15.1 LTS
Bot version: 4.22.0 (Latest)

How to reproduce:

  1. Join a voice channel.
  2. Play a song.
  3. Run Repeat All command.
  4. Leave the channel.
  5. Wait until the queue got deleted and see the song still playing.

12:30 UTC+7 - 09/12/2020

Stage Channel Support

Discord just released Stage channels, a new type of channel that allow you to share a focused conversation with select speakers to an audience of listeners. Currently music bot doesn't support to join this channel. So, I open this issue for that. Since discord.js still doesn't support new API, you can see this PR for reference discord/discord-api-docs#2751
The idea is extending discord.js structures for temporary until discord.js fully supported stage channels.

[Changes Request] Reduce impressions of spam

Hello, I have a request or maybe just a suggestion about Jukebox's messaging

In the first section, I will discuss the play command

image

  • Isn't the message "added to the queue" better if it isn't displayed if the user only plays 1 music?

Let's move to the second thing, it's similar to the first one, skip command

image

  • In my opinion, it is better if the user executes this command and the bot does not display the "Skipped" message if after the queue there are still other songs. Maybe you can delete it and make a new statement? or just changing the promises to add reactions like Groovy's skip command?

image

This is useful so that it is more precise with your goal on yesterday's commit, which is to reduce messages that seem spammy (#354)

That's all, nothing I can do 😕

[INFO] Planned removal of YouTubeAPI

YouTube API Data v3 causes too many problems and is unreliable, we won't know when YouTube API Data v4 releases and what changes will it come, and will it be better than v3.

So, I'm planning to remove YouTubeAPI in Jukebox v5, and probably adding them in v6 as experimental.

[YTDLError: aborted] Facing this in Heroku.

Haven't changed anything, Just deployed the app through the "Deploy to Heroku" button, and it keeps telling me Error while playing music Reason: YTDLError: aborted. - How do I fix this?

Music not working on Docker

Because jukebox uses Alpine Linux image, and @discordjs/opus prebuilt is not working in Alpine Linux as of discordjs/opus#3, music won't start and always get a segmentation fault and then crashes.

[INFO] Jukebox's future

Jukebox v5 will require Node.js version 16.6.0 or above, as in discordjs/discord.js#5119.
When v5 is released, I'll Immediately start rewriting Jukebox with an entirely new music system, marking it as v6.
I will try to maintain v5 until the end of 2021, and I'll also try to update v4 (unlikely, I'll probably deprecate that version after Discord.js major update) until it's broken because Discord kills the v6 gateway.

Playlist Message Spam

I just wondering what if user play a playlist with over 100+ same songs
It'll spam like this right:
image
Maybe it's better to make a final message rather than send each video?

[BUG] YouTube API: WHATWG URL API makes makePaginatedRequest causes INVALID_ARGUMENT

"null" in URLSearchParams are not removed, and if pageToken is null, Google API throws Bad Request with this exact response

{
  "error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "errors": [
      {
        "message": "Request contains an invalid argument.",
        "domain": "global",
        "reason": "badRequest"
      }
    ],
    "status": "INVALID_ARGUMENT"
  }
}

Jukebox's Future

Current status

With the release of Jukebox v5, we are not finished. I'm still adding more features to Jukebox v5 (Pull request welcome!)
I'll also add languages support, so when #650 is resolved, you can add your own languages to Jukebox!

After the new base is finished (Hazmi35/discordbot-template) and I feel Jukebox v5 is finished (by features), I'll rewrite Jukebox entirely. With a new Base and new Music system.

Message Inconsistencies

There are many message inconsistencies in Jukebox, one of the examples is: Video, Music, or Song? fix this ASAP

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.