hca-healthcare / elixir-hl7 Goto Github PK

Currently it return %Hl7.Message{} or blows up. Type specs would be nice too. Specs in a consuming app caught the goof.

There's a lot of info in the readme about parsing HL7 messages, but I'm trying to create them and I don't see a straightforward way to add segments to a message. A new message can be created with raw input, or with a header, but how do you add segments?

The typing has pos_integer, but in reality we allow 0 for the field.

Since HL7 is 1 based I don't know if we should change the code to be 1 based or if the typing should be updated.

https://v2plus.hl7.org/2021Jan/composition/Control.html#Control-5-4

iex(2)> hl7_text = HL7.Examples.wikipedia_sample_hl7() gives me this error , any reason why
also tried running HL7.Examples.wikipedia_sample_hl7()

(UndefinedFunctionError) function HL7.Examples.wikipedia_sample_hl7/0 is undefined (module HL7.Examples is not available)
HL7.Examples.wikipedia_sample_hl7()

    hl7
    |> HL7.Query.replace_parts("MSH-9.3", nil)
    |> HL7.Query.to_message()

Is valid and removed the part, but the types don't line up and there is no test. I think this is valid and we should document the support.

Since the types don't line up if people are using dialyzer they get warnings.

Would it be possible to implement the Enumerable Protocol for the HL7.Query Struct, so that Enum.map and HL7.Query.map would be equivalent?

The latest tag that I see on https://github.com/HCA-Healthcare/elixir-hl7/tags is 0.6.3

The current version in https://hex.pm/packages/elixir_hl7/versions is 0.8.0

Could you please add the missing tags for each of the versions so that I can compare the diffs between each version that got released?

HL7.Query.number_set_ids puts a Number in the MSH-1 Field, I would only expect it to number the remaining Fields.

If the library is capable of doing encoding?, an example and/or test for encoding a message starting from a filled in struct (like MSH) would be very helpful.

looks like Bryan had to go all anarchist on the naming conventions.... need some kind of enforcement agency or something to keep things like this from happening.

I'm not sure if this is the right place to report this, but since I don't know much about macros and the HL7.Query changes seem to have triggered this, I'll report it here first.

For example, if we do a query on a non-existent TXA-16 field and check if the result is nil, dialyzer scolds us that a binary cannot be nil, while at runtime nil is returned.

defmodule Test do
  require HL7.Query
  import HL7.Query, only: [sigil_g: 2]
  # Will return :was_nil
  def test do
    msg = HL7.Query.new(HL7.Examples.wikipedia_sample_hl7())

    part = HL7.Query.get_part(msg, ~g"TXA-16")

    if is_nil(part) do
      :was_nil
    else
      :not_nil
    end
  end
end

Dialyzer Output:

lib/test.ex:11:exact_eq
The test binary() == nil can never evaluate to 'true'.
``