Player names missing when converting reconnected games about python-hsreplay HOT 6 CLOSED

My solution for this in HDT was to set the names on the first CURRENT_PLAYER change.

from python-hsreplay.

Here's more detailed explanation:

Excerpt from the log:

D 13:20:09.6106926 GameState.DebugPrintPower() -     Player EntityID=2 PlayerID=1 GameAccountId=[hi=144115198130930503 lo=15856412]
[...]
D 13:20:09.6106926 GameState.DebugPrintPower() -         tag=CURRENT_PLAYER value=1
[...]
D 13:20:09.6116931 GameState.DebugPrintPower() -     Player EntityID=3 PlayerID=2 GameAccountId=[hi=144115198130930503 lo=71919920]
[...]
[...]
D 13:20:28.3481950 GameState.DebugPrintPower() -     TAG_CHANGE Entity=Epix tag=CURRENT_PLAYER value=0
D 13:20:28.3481950 GameState.DebugPrintPower() -     TAG_CHANGE Entity=ALEKS tag=CURRENT_PLAYER value=1

• On reconnect we know the CURRENT_PLAYER (PlayerID=1)
• The first CURRENT_PLAYER tag change to 0 occours on Entity=Epix
• Therefore we know the player with PlayerID=1 is Epix

from python-hsreplay.

Try after HearthSim/python-hearthstone@8986ebd

from python-hsreplay.

http://hsreplay.net/joust/replay/e8c20d26-2d39-48da-a144-8decb96f33b5

Generated with 1.1, no player names. Contains only the part after the reconnect (this is correct).

from python-hsreplay.

Oh, this is fun, there is the log: http://files.hsdecktracker.net/powerlog_reconnect_uhp.txt
UNKNOWN HUMAN PLAYER :)

from python-hsreplay.

I pushed a fix... it's not perfect but it'll be better now.

from python-hsreplay.