hellotham / hello-astro Goto Github PK

Hello Astro is a multi purpose Astro starter theme written in Typescript, TailwindCSS and AlpineJS. It supports Markdown and MDX based pages and blog posts.

Home Page: https://hellotham.github.io/hello-astro

License: MIT License

JavaScript 8.43% Astro 84.78% TypeScript 3.63% Roff 0.85% MDX 2.31%

astro blog starter tailwindcss typescript dark-mode markdown mdx katex lunrjs

hello-astro's People

Contributors

Stargazers

Watchers

hello-astro's Issues

Scroll position lost when navigating

Thanks for the really nice theme!

Is there any way to remember the scroll position when navigating back to the homepage?

Go to https://hellotham.github.io/hello-astro/
Scroll down and click on tags
Press the browser back button.

The page will be scrolled back to the top, instead of remembering the scroll position.

Firefox 116.0 (64-bit).

[enhancement] How can we fix Content Security Policy， Subresource Integrity and X-Content-Type-Options..

https://observatory.mozilla.org/analyze/hellotham.github.io

Thank you.

Error log

I have ran PageSpeed and found there were error in your console log.

I'm still learning about Astro and Tailwind and I noticed that you mention TailwindUI in the README.md. I was looking into tailwindui.com and reading about their licenses, but I'm not sure exactly how/if hello-astro uses tailwindui. Do you know if there are any licensing issues related to tailwindui that would affect users of hello-astro?

Another option I'm looking into is building something similar using https://daisyui.com/, since it uses the MIT license. If I wanted to do that, would I need to replace the contents of components/ with similar components from daisyui?

Thanks for any guidance you can provide and for sharing such a beautiful theme with us!

"Loading module from “h/hello-astro/_astro/hoisted.d643c4ae.js” was blocked because of a disallowed MIME type (“text/html”)"

Got this on my first build. I suspect there's an nginx setting I need to tweak?

Mermaid doesn't work

Visit https://hellotham.github.io/hello-astro/blog/2022-08-20-mermaid-diagrams/ and looks like Mermaid Diagrams are broken.

I'm use MS Edge v119.0.2151.72

Cannot run with output: 'server' [ vercel ]

I try to setup deploy Vercel which I add in astro.config

  output: 'server',
  adapter: vercel(),

after that I run

yarn dev

then I enter to /blog

the error show up: Cannot read properties of undefined (reading 'size')

I'm not sure, Does getStaticPaths can deploy with Vercel SSR ?

if you have some free time would you mind to help me check please thanks

dev urls don't match prod urls due to trailing slashes

As in this Issue, there may be a discrepancy in dev and prod URLs which may cause Google indexing to think the site has redirect issues.

We may need to switch URLs to new URL('./relative', Astro.url) according to https://docs.astro.build/en/reference/configuration-reference/#buildformat , in order to be consistent but I could be wrong.

Also, there seems to be some work going on with astrojs/sitemap withastro/astro#5604 and withastro/astro#5630 to fix this issue.

This theme just not work with node v19.4.0. Also, has a duplicate MDX entry

❯ pnpm i
WARN deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead
WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
Packages: +589
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Packages are hard linked from the content-addressable store to the virtual store.
Content-addressable store is at: /Users/alejo/Library/pnpm/store/v3
Virtual store is at: node_modules/.pnpm
Progress: resolved 630, reused 589, downloaded 0, added 589, done

dependencies:

@astrojs/rss 1.2.1 (2.0.0 is available)
astro-icon 0.7.3 (0.8.0 is available)
astro-seo 0.6.1
hero-patterns 2.1.0
katex 0.16.4
leaflet 1.9.3
lunr 2.3.9
photoswipe 5.3.4
photoswipe-dynamic-caption-plugin 1.2.7

devDependencies:

@akebifiky/remark-simple-plantuml 1.0.2
@astrojs/alpinejs 0.1.2
@astrojs/image 0.10.0 (0.12.1 is available)
@astrojs/mdx 0.11.6 (0.14.0 is available)
@astrojs/sitemap 1.0.0
@astrojs/tailwind 2.1.3
@tailwindcss/aspect-ratio 0.4.2
@tailwindcss/forms 0.5.3
@tailwindcss/line-clamp 0.4.2
@tailwindcss/typography 0.5.9
@types/alpinejs 3.7.1
@types/leaflet 1.9.0
alpinejs 3.10.5
astro 1.5.2 (1.8.0 is available)
astro-robots-txt 0.3.11
exifr 7.1.3
mdast-util-to-string 3.1.0
prettier-plugin-astro 0.6.0 (0.7.2 is available)
reading-time 1.5.0
rehype-katex 6.0.2
remark-math 5.1.1
schema-dts 1.1.0
tailwindcss 3.2.4
unist-util-visit 4.1.1

WARN Issues with peer dependencies found
.
├─┬ @astrojs/mdx 0.11.6
│ └─┬ @mdx-js/rollup 2.2.1
│ ├── ✕ missing peer rollup@>=2
│ └─┬ @rollup/pluginutils 5.0.2
│ └── ✕ missing peer rollup@^1.20.0||^2.0.0||^3.0.0
└─┬ schema-dts 1.1.0
└── ✕ missing peer typescript@>=4.1.0
Peer dependencies that should be installed:
rollup@">=2.0.0 <3.0.0 || >=3.0.0 <4.0.0"
typescript@>=4.1.0

Done in 12.4s
❯ pnpm run dev

[email protected] dev /Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro
astro dev

[MDX] Now inheriting remark and rehype plugins from "markdown" config.
If you applied a plugin to both your Markdown and MDX configs, we suggest removing the duplicate MDX entry.
See "extendPlugins" option to configure this behavior.
🚀 astro v1.5.2 started in 473ms

┃ Local http://localhost:3000/hello-astro/
┃ Network use --host to expose

/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/[email protected]/node_modules/web-streams-polyfill/dist/polyfill.js:362
throw new TypeError(context + " is not a ReadableStream.");
^

TypeError: First parameter has member 'readable' that is not a ReadableStream.
at assertReadableStream (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/[email protected]/node_modules/web-streams-polyfill/dist/polyfill.js:362:19)
at convertReadableWritablePair (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/[email protected]/node_modules/web-streams-polyfill/dist/polyfill.js:3524:9)
at ReadableStream.pipeThrough (/Users/alejo/Documents/Code/GitHub-i7.tmp/test/hello-astro/node_modules/.pnpm/[email protected]/node_modules/web-streams-polyfill/dist/polyfill.js:3608:29)
at fetchFinale (node:internal/deps/undici/undici:13682:56)
at mainFetch (node:internal/deps/undici/undici:13574:9)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

PhotoSwipe is broken

Since the last update, photos in a gallery are opening as @astroimage and not in a lightbox.

Problem with implementation of logo display in dark and light modes

Description:

The project currently does not provide for proper display of the logo in dark and light modes. In the original code, the same logo is displayed regardless of the mode selected by the user.

The relevant code is as follows:

<div class='flex flex-shrink-0 items-center'>
  <img class='block h-8 w-8 dark:bg-gray-100' src={Logo.src} alt='Logo' />
</div>

Cannot read properties of undefined (reading 'set') after upgrade to 2.8.0 #build

error here : src/pages/blog/[slug].astro

Cannot read properties of undefined (reading 'set')
  File:
    src/pages/blog/[slug].astro
  Stacktrace:
TypeError: Cannot read properties of undefined (reading 'set')
    at factory (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/2023-06-10-sample-gallery-post-markdoc.394cd6e2.mjs:64:26)
    at AstroComponentInstance.factory (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1131:12)
    at AstroComponentInstance.init (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1664:29)
    at AstroComponentInstance.render (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1669:18)
    at render.next (<anonymous>)
    at renderChild (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1727:18)
    at async EagerAsyncIterableIterator.next (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1486:14)
    at async renderChild (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1731:5)
    at async renderAstroTemplateResult (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1606:24)
    at async renderChild (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1725:5)
    at async renderSlot (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1751:5)
    at async renderSlotToString (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1761:20)
    at async Promise.all (index 0)
    at async renderSlots (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:1777:5)
    at async renderFrameworkComponent (file:///home/manjaro/DEV/sup/hello-astro/dist/chunks/astro.a9f939f3.mjs:2422:42)
    at async bufferHeadContent (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/runtime/server/render/page.js:44:25)
    at async renderPage (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/runtime/server/render/page.js:99:5)
    at async renderPage (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/render/core.js:41:18)
    at async generatePath (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/generate.js:446:20)
    at async generatePage (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/generate.js:206:5)
    at async generatePages (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/generate.js:133:7)
    at async staticBuild (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/static-build.js:84:7)
    at async AstroBuilder.build (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/index.js:118:5)
    at async AstroBuilder.run (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/index.js:149:7)
    at async build (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/core/build/index.js:37:3)
    at async runCommand (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/cli/index.js:219:14)
    at async cli (file:///home/manjaro/DEV/sup/hello-astro/node_modules/.pnpm/[email protected]/node_modules/astro/dist/cli/index.js:260:5)

 ELIFECYCLE  Command failed with exit code 1.
 ```

Dev server does not load on http://localhost:3000/hello-astro/

Hi, thanks for the creation of the astro template, I had a chance to try running this with yarn run dev, but the site does not load from http://localhost:3000/hello-astro/

The Issue

If I try the root path, it will return the expected 404 page:

However, if I navigate to http://localhost:3000/hello-astro/ it will just keep loading indefinitely with no response:

Other Findings

I tried run a different astro dev server with a different project under the same http://localhost:3000/ , seems to work perfectly. The issue seems to be specific to hello-astro.
In hello-astro, yarn build + yarn preview works flawlessly 🎉

Was there any other steps needed before running yarn run dev?
Any guidance would be much appreciated, thank you.

Problems rendering diagram blog posts

Hi I noticed that some of the example diagram blog posts don't render images.

Mindmap Diagram
https://hellotham.github.io/hello-astro/blog/2022-08-26-markmap-diagrams

Mermaid Diagram
https://hellotham.github.io/hello-astro/blog/2022-08-20-mermaid-diagrams

I have check with both Edge and Firefox browsers.

problem trying to depoly site

Hi!

i've tried to deploy your site on github pages, vercel and netlify and it has been impossible

when trying pnpm preview my terminal shows this error

`$ pnpm preview

[email protected] preview C:\Users\USUARIO\Desktop\Programación\Proyectos\hello-astro
astro preview
[preview] The @astrojs/vercel/serverless adapter does not support the preview command.
Stack trace:
at preview (file:///C:/Users/USUARIO/Desktop/Programaci%C3%B3n/Proyectos/hello-astro/node_modules/.pnpm/[email protected][email protected]/node_modules/astro/dist/core/preview/index.js:31:11)
at async runCommand (file:///C:/Users/USUARIO/Desktop/Programaci%C3%B3n/Proyectos/hello-astro/node_modules/.pnpm/[email protected][email protected]/node_modules/astro/dist/cli/index.js:129:22)
ELIFECYCLE Command failed with exit code 1.`

Change Color Theme

Has some easy way to change color from purple to green?

Reading Time on blog index

Hello, I just cloned the repository and when I run it I'm not seeing the reading time of each post on blog path but on your website is there, do you know why?

Thanks in advance!