henrygarner / biscuit Goto Github PK

Extend the reach of this lib by providing support for ClojureScript.

Pull request incoming..

I need to calculate digests for byte array/coll inputs, i.e. not strings. With the current api, I have to convert raw bytes to a string (which biscuit then converts back to bytes). For my byte data, this conversion to string and back breaks, and the calculated digest e.g. crc-16 is incorrect.

If I change the api to allow raw bytes to be passed in, the calculated digests are correct (I compared the results with various online crc calculators).

Pull request incoming..

Hi,

Not sure if this library is being maintained, but hopefully you'll see this

I had different CRC32 checksums returned for the same string on different machines, because .getBytes is called without specifying a character encoding. The default encoding will be used, which is unspecified.

I believe you should be calling it with utf-8 specified.