herczogzoltan / aoc2019 Goto Github PK

Context

I received a review from @yitsushi which highlighted the downsides of the current structure of the code. The key points of the review included the followings:

• Using just one cmd directory to organize the functions - I'm going to end up in a situation where using the same (general) function names is impossible because of name conflict.

• Reuse / Lib - The current structure of the code doesn't give room to use logical functions and structs or if there's a common solution for multiple tasks, it'll not have the correct namespace. Also restructuring the functions under libs will provide a clearer way of testing those submodules (instead of testing the whole command).

He also provided an example about the new structure which looks like this:

.
├── README.md
├── cmd
│   ├── day01.go
│   └── root.go
├── go.mod
├── go.sum
├── main.go
└── src
    ├── core
    │   └── day.go
    └── day01
        └── parser.go

Acceptance criteria

All the previously submitted tasks are refactored to align with the structure given in the example above.

Inputs directory shouldn't be part of the app repository.