hermeznetwork / cli-bidding Goto Github PK

Sometimes bidding transactions take too long to process because gas price is too low (https://goerli.etherscan.io/tx/0x4fc4fca293e0792c88b2a5f25a1cdeb08eff788433ed183395ae87f031757e29). It would be nice to have an option to increase the price by some factor, and even to speed previously sent transactions.

let dataPermit;
  if(command === "BID" || command === "MULTIBID") {
    // Create Permit Signature
    const nonce = await HezContract.nonces(wallet.getAddress());
    const deadline = ethers.constants.MaxUint256;

    let amountUnits = amount
    let bidAmountUnits = bidAmount
    let maxBidUnits = maxBid
    let minBidUnits = minBid
    if (units == "ether") {
      amountUnits = ethers.utils.parseEther(amount);
      bidAmountUnits = ethers.utils.parseEther(bidAmount);
      maxBidUnits = ethers.utils.parseEther(maxBid);
      minBidUnits = ethers.utils.parseEther(minBid);
   }

amountUnits and bidAmountUnits are defined in a limited scope, but then are used after the if block

• Add tests
  • setup github actions
• change ./src/.env.example
  • set PRIVATE_KEY_CLI_BIDDING (it must include 0x)
  • set NODE_ETHEREUM_URL to https://localhost:8545
• explain amount and bidAmount when bidding in quick guide (or just link to the explanation)
• explain amount is set with 18 decimals since HEZ is used in quick guide (or just link to the explanation)
• it may be useful to add an option to perform an infinite approval (just to safe gas if you perform multiple bids)
• add eslint --> https://github.com/hermeznetwork/circuits/blob/master/.eslintrc.js
• add package-lock.json to ensure node_modules versions
• this repo should be public and it should have an npm package
  • improve package.json id npm package is fianlly done
• code already supports 3 chainId (1, 4, 5). We could hardcode smart contracts addresses on those three environments and in environemnt ile the user should choose between mainnet, rinkeby or goerli. Contracts addressescould be overwritten is set actual environment vars HERMEZ_AUCTION_ADDRESS & HEZ_TOKEN_ADDRESS
• It would be nice to separate console client and functionality, just to keep the repo best organized and probably functionality could be used externally (in a webApp for bidding for example)

• create a proper package.json to publish npm package @hermeznetwork/cli-bidding
• publish package on npm

maxBid and minBid parameters are used for multibid. However, the code uses them in the simple bid scenario and returns an error.

  if(command === "BID" || command === "MULTIBID") {
    // Create Permit Signature
    const nonce = await HezContract.nonces(wallet.getAddress());
    const deadline = ethers.constants.MaxUint256;

    amountUnits = amount
    bidAmountUnits = bidAmount
    let maxBidUnits = maxBid
    let minBidUnits = minBid
    if (units == "ether") {
      amountUnits = ethers.utils.parseEther(amount);
      bidAmountUnits = ethers.utils.parseEther(bidAmount);
      maxBidUnits = ethers.utils.parseEther(maxBid);
      minBidUnits = ethers.utils.parseEther(minBid);
    }

If I do node src/biddingCLI.js slotinfo --startingSlot 4350 --endingSlot 4370 to get the first biddable slot, and then bid in the returned first biddable slot, the bid returns an AUTION_CLOSED error