Giter VIP home page Giter VIP logo

Comments (5)

ed255 avatar ed255 commented on August 17, 2024 1

I've created the PR #14 adding some events as a result of the TOB audit. For now they are:

* Hermez (InstantWithdrawManager.sol) -> UpdateWithdrawalDelay

* Hermez (InstantWithdrawManager.sol) -> UpdateBucketsParameters

* Hermez (InstantWithdrawManager.sol) -> UpdateTokenExchange

* Hermez (InstantWithdrawManager.sol) -> SafeMode

If @arnaubennassar @ed255 @krlosMata you think there are some other missing events or want to change some of them, I can add them to this PR.

The two events that I was missing were about WithdrawalDelay and Buckets. I see in the PR that now there are events for those two. Nevertheless I think the event for buckets could be extended! I'll leave a comment in the PR explaining this.

EDIT: Link to the comment in the PR #14 (comment)

from contracts.

krlosMata avatar krlosMata commented on August 17, 2024
  • I think it is useful to have events for those parameters that the governance can update. In this way you avoid to do polling to detect a variable update.

As far as I see in the Hermez.sol there are already events for those variables:

  • UpdateFeeAddToken
  • UpdateForgeL1L2BatchTimeout

from contracts.

ed255 avatar ed255 commented on August 17, 2024

Here's an incomplete list of public variables that don't have events:

  • Hermez (InstantWithdrawManager.sol) -> withdrawalDelay
  • Hermez (InstantWithdrawManager.sol) -> buckets

from contracts.

eduadiez avatar eduadiez commented on August 17, 2024

I've created the PR #14 adding some events as a result of the TOB audit. For now they are:

  • Hermez (InstantWithdrawManager.sol) -> UpdateWithdrawalDelay
  • Hermez (InstantWithdrawManager.sol) -> UpdateBucketsParameters
  • Hermez (InstantWithdrawManager.sol) -> UpdateTokenExchange
  • Hermez (InstantWithdrawManager.sol) -> SafeMode

If @arnaubennassar @ed255 @krlosMata you think there are some other missing events or want to change some of them, I can add them to this PR.

from contracts.

eduadiez avatar eduadiez commented on August 17, 2024

We need to add the new hashGlobalInputs to the event

from contracts.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.