hermeznetwork / contracts Goto Github PK

There should be a consistent criteria for using or not events.
Right now, some events are necessary in order to synchronize and forge blocks as:
event ForgeBatch
event L1UserTxEvent

Others like event UpdateFeeAddToken are only usefull to track all previous changes.
But not all the state variables that can be updated have and event to notify them.
So there's 2 options:

• Emit events only when are necessary in order to synchronize and forge blocks
• Also add events for every state variable that can be update

As far as I know, there's no way to obtain the bootCoordinator URL. But clients need it in order to send l2txs when a slot hasn't been bid.
I think it would be interesting to have the bootCoordinatorURL as a public variable, with an associated event when it's updated.

I am deploying hermez by using localDeploy.js , but this error appears.
I used to my private Ethereum blockchain (not ganache).

Here is the error.

How can I solve this problem?
Thank you.

Research best MAX_TOKEN_WITHDRAW

The condition checking if it has an address in the config file, is missing.

In the deployment script, it's deployed with a proxy.

It should be deployed directly because it must not be upgradable.

I think it would be better to set up a global variable MAX_FEE_TX which determines the total number of fee transactions that the protocol can handle. It is directly related with the length of idx where the coordinator could receive the accumulated fees.

The first version sets this number to 64 fee transactions as it is coded in the next line: https://github.com/hermeznetwork/contracts/blob/master/contracts/hermez/Hermez.sol#L894

I think we should make this parameter a global variable in the contract as it is done with _MAX_L1_TX.

Hi, would it be possible to release a GitHub package with the repository?
The main motivation would be to allow other devs to consume the contracts as a package.json dependency.
Something similar to:

npm install @hermeznetwork/[email protected]
or
"@hermeznetwork/contracts": "^1.0.0"

More info on how to do this: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry

Best,
Galimba

Summary

Apply proper changes to hermez contract to support the following new features:

• new exits approach
• withdraw-multi-token
  • check specification here
• withdraw-bjj
  • check specification here

Overview changes

• remove variables regarding exit-tree
• update withdrawal approach to https://github.com/hermeznetwork/docs/blob/feature/update-v1/docs/developers/protocol/hermez-protocol/protocol.md#hermezwithdraw
• add withdraw-multi-token function

Write specification and implementation regarding how to manage proporly the state root upgrade.

First draft

• Stop rollup features until root is fully upgraded
• Add function updateRoot which should be called N times, depending on current account numbers and maximum accocunt that the circuit can handle
• add necessary information in events, so data could be synchronized
• increase batch number by 1, which would set the updateBatchNumber
• maintain old functionalities if batch number is < updateBatchNumber

Add functionalities to Rollup.sol contract to support massive migration features