hernpiblo / pe Goto Github PK

According to your UG, this command should be acceptable (just find itself) but it throws an error. Probably a UG bug

What does return Empty mean? Could perhaps be more descriptive to explain which part is empty

words in image are small compared to other texts

what does *all and *filtered mean here

Include command sequence diagram
Self invocation calls should be solid lines. If its a limitations of PlantUML, should state somewhere

Edit command diagram:
No condition mentioned for the alternative route

Not supppose to have space between edited and Event

Found in include command

Input validation should be done. This also leads to the issue where the delete command comnfirmation message is not shown, which is why this is severity low

Command:

Result:

This should not be the case since email is unique especially in a people management app

steps to reproduce:
command : edit 1 fd/20-13-2022
result: error message

command : delete 1 1

error message was from previous command

This part could have been text where the user can copy and paste into their own csv file to test out the import.
Now users have to manually type out everything just to test.
And the export function does not help since it does not export the same details as the required one for import.

test desc

Did not explain what t and f stands for

Say i added 500 residents into my app and i want to export them and import the new data into another computer. I cant use the export function since it does not even export it into the same format as the one required for the input. The only way is to manually convert the json file to csv.

name matches the infomation* instead of name match information

Command:

Result:

Does not affect much but input should have been validated

The things that happen inside the model section can be abstracted into another diagram. Now this diagram looks cluttered and the text is small

I feel like both should have the same error mesage since -1 is an invalid index

Only appears in the error message

There is a horizontal line in the activation bar of the find person sequence diagram

I feel like i should be able to trace t/0 since im able to input the resident on todays date, i shouldnt have to wait till tomorrow to be able to see who the person's close contact is for today

Command:

Result:

This should not be the case since phone numbers are unique

Capitalise first letter or not? "Room" or "Room Number"? "Phone" or "Phone Number"?

This will be troublesome for user to debug since it requires them to test out different variations manually in their csv file

find person command activity diagram is very blur

Did not explain or give example of what "local-part", "domain name" and "domain labels" are. Users would have to google to find what constraints each part has.