hexanet / monologextrabundle Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 1.0 78 KB

:memo: Symfony bundle with extra processors and logger to log request/response

License: MIT License

PHP 100.00%

bundle php symfony symfony-bundle

monologextrabundle's People

Contributors

Stargazers

Watchers

Forkers

jeromemacias

monologextrabundle's Issues

Delete compatibility code for security and old symfony versions

For old versions of Symfony, we have a compatibility codeto get the token storage or the security context.

This code should be deleted for the 2.0 of the bundle

What about a CommandProcessor for command name, options and arguments extra

Nice bundle !

Can a CommandProcessor be useful (see https://github.com/otobank/monolog-console-processor/blob/master/src/ConsoleProcessor.php) ?

We could add 3 informations:

name
options
arguments

Symfony 4 compatibility

TODO:

add monolog bundle in "require"
use class name for service id ?

Avoid using deprecated APIs in Symfony 2.6+

See stof/StofDoctrineExtensionsBundle@cd0f80e

Remake the README

TODO :

Example
More informations on apache UID

Add type hinting

The 2.0 version will support only php > 7 so we can use type hinting

gelf optionnal

TODO :

suggest graylog2/gelf-php instead of required
Add option to enable Gelf publisher
Check that graylog2/gelf-php exist when gelf publisher is enabled

Use ConsoleEvents::ERROR instead of ConsoleEvents::EXCEPTION for Symfony >= 3.3

See http://symfony.com/doc/current/components/console/events.html#the-consoleevents-exception-event

New in version 3.3: The ConsoleEvents::EXCEPTION event was deprecated in Symfony 3.3. Use the ConsoleEvents::ERROR event instead.

Error if HttpFoundation is not present

In a project without web :

In DefinitionErrorExceptionPass.php line 37:

  Cannot autowire service "Hexanet\Common\MonologExtraBundle\Provider\Session
  \SymfonySessionIdProvider": argument "$session" of method "__construct()" r
  eferences interface "Symfony\Component\HttpFoundation\Session\SessionInterf
  ace" but no such service exists. It cannot be auto-registered because it is
   from a different root namespace.


Script Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::clearCache handling the symfony-scripts event terminated with an exception


  [RuntimeException]
  An error occurred when executing the "'cache:clear --no-warmup'" command:




  In DefinitionErrorExceptionPass.php line 37:

    Cannot autowire service "Hexanet\Common\MonologExtraBundle\Provider\Session
    \SymfonySessionIdProvider": argument "$session" of method "__construct()" r
    eferences interface "Symfony\Component\HttpFoundation\Session\SessionInterf
    ace" but no such service exists. It cannot be auto-registered because it is
     from a different root namespace.

Compatibility with Symfony < 2.6

Clean SymfonySessionIdProvider constructor

Related to @nclsHart comment :

public function __construct(bool $startSession = false, SessionInterface $session)

This is not directly related to this PR, but arguments with default value should be at end of arguments list.

Use class name for service id

use class name for service id
use autowire
set symfony 3.4 as min version

Release a new major after the merge

quoting scalar starting with the "%" indicator character

Not quoting the scalar "%hexanet_monolog_extra.session_start%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0.

Add PHP 7.2

See Hexanet/swiftmailer-image-embed#10 (comment)

ConsoleExceptionListener - command can be null

$ sf hexaenet:doctor

Fatal error: Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function getName() on null in /Users/floranbrutel/dev/si/applications/citadel/vendor/hexanet/monolog-extra-bundle/src/EventListener/ConsoleExceptionListener.php:42
Stack trace:
#0 [internal function]: Hexanet\Common\MonologExtraBundle\EventListener\ConsoleExceptionListener->onConsoleException(Object(Symfony\Component\Console\Event\ConsoleErrorEvent), 'console.error', Object(Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher))
#1 /Users/floranbrutel/dev/si/applications/citadel/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/Debug/WrappedListener.php(104): call_user_func(Array, Object(Symfony\Component\Console\Event\ConsoleErrorEvent), 'console.error', Object(Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher))
#2 /Users/floranbrutel/dev/si/applications/citadel/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php(212): Symfony\Component\EventDispatcher\Debug\WrappedListener in /Users/floranbrutel/dev/si/applications/citadel/vendor/hexanet/monolog-extra-bundle/src/EventListener/ConsoleExceptionListener.php on line 42

$event->getCommand(); return Command or null : we need to adapt the ConsoleExceptionListener