What happened to the ARC branch? about hexfiend HOT 13 CLOSED

HF is now 100% ARC 🎉

from hexfiend.

Maybe I never pushed it? Anyways I pushed it now as ARC.

from hexfiend.

Yes. But development seems to carry on with MRC! master is still full of retain and release.

from hexfiend.

Why migrate to ARC today when you can migrate to Swift tomorrow? Heh.

from hexfiend.

Is there any interest in migrating to/continuing the move to ARC?

@percontation I would argue that no real migration to Swift is possible. Only porting, be it piecemeal or monolithic. :)

from hexfiend.

Nah, just follow these 20 easy steps and you'll be fine! :P
Anyway, the benefits of switching everything to ARC are kinda low. On the other hand, ARC seems unlikely to go the way of GC or anything, so I don't see any hidden downsides.

from hexfiend.

Even though I had used MRC for years I found that ARC frees up your capacity for other things. One thing less you might be screwing up.

from hexfiend.

Yeah, I'm all for ARC, it's just that HexFiend is past the point where migration is sufficiently automatic and error-free for me personally to want to do :). But if you wanna take a stab at brining the ARC branch up to parity with master, I'd happily start dogfooding that to help spot issues.

FWIW at some point a while ago I tried collecting the ARC stuff at https://github.com/percontation/HexFiend/tree/ARC_rebase. I don't really remember exactly where that's at, or if it's even worth using.

from hexfiend.

Could always start turning on ARC for files one by one. That way it's not a huge set of changes to test and code review.

from hexfiend.

Yeah, I imagine there are quite a few files that could be auto-ARCed and merged straight into master without raising too much concern. I'd have to catch up on those "Writing Modern ObjC" docs before I could help though :P

from hexfiend.

I did two changes for ARC:

1. Replaced NSAutoreleasePool with @autoreleasepool [bc8ebcd]
2. Moved HexFiendling to ARC [7bdc030]

I just did these in master since they were relatively harmless.

from hexfiend.

Closing this. ARC changes will continue to occur (slowly though), and pull requests are always welcomed. The problem is making mass changes to the code will most likely result in bugs, so they need to be done carefully and in small chunks at a time.

from hexfiend.

HF is now 95% ARC. There are only 4 remaining files to convert in the framework, but these are the most difficult due to mixing Objective-C objects with C data structures, or with CoreFoundation collections. I'll get to them eventually.

I nearly completed converting HFByteArray_FileWriting.m but came across an issue where createAcyclicGraphFromStronglyConnectedComponents() creates dependencies and dependencyObjects variables, then iterates over them, but never references them. There have been no reports on file writing not working, so I'm not sure what's going on with this code.

from hexfiend.