hi-manshu / charty Goto Github PK

The CurveLineChart does not display xlabels

The path is displayed when you create a LineChart with a single point.

Incorrect state:

Source code:

LineChart(
    modifier = Modifier
        .fillMaxWidth()
        .height(300.dp),
    color = colors.first(),
    lineData = listOf(
        LineData(10F, 35F)
    )
)

Expected state:

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency io.gitlab.arturbosch.detekt:detekt-gradle-plugin to v1.23.6
• Update dependency com.google.android.material:material to v1.11.0
• Update dependency com.slack.lint.compose:compose-lint-checks to v1.3.1
• Update dependency org.jetbrains.dokka:android-documentation-plugin to v1.9.20
• Update dependency org.jetbrains.kotlinx:kotlinx-datetime to v0.5.0
• Update plugin com.vanniktech.maven.publish to v0.28.0
• Update plugin org.jetbrains.dokka to v1.9.20
• Update actions/checkout action to v4
• Update actions/setup-java action to v4
• Update dependency androidx.compose:compose-bom to v2024
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency androidx.activity:activity-compose to v1.8.2
• Update dependency androidx.compose:compose-bom to v2022.12.00
• Update dependency androidx.compose:compose-bom to v2023.10.01
• Update dependency androidx.core:core-ktx to v1.12.0
• Update dependency androidx.lifecycle:lifecycle-runtime-ktx to v2.7.0
• Update dependency composeOptions to v1.5.11
• Update dependency gradle to v8.7
• Update plugin com.android.application to v8.3.1
• Update plugin com.android.library to v8.3.1
• Update plugin org.jetbrains.kotlin.android to v1.9.23
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

When not giving a direct size with Modifier.size(Some.dp), and using Modifier.fillMaxSize(.#f) or Modifier.fillMaxWidth(.#f) the chart looks fine, however the background size does not wrap the object. Here are some pictures to compare

PieChart(
                   modifier = Modifier
                       .scale(1f)
                       .fillMaxWidth(.4f)
                       .background(color = Color.White),
                   pieData = pieData,
               )

PieChart(
                    modifier = Modifier
                        .scale(1f)
                        .background(color = Color.White)
                        .size(size.dp),
                    pieData = pieData, config = PieConfig(isDonut = true, expandDonutOnClick = false),
                )

I'd like to display data in my app un the shape of a Spider chart (aka radar chart)
I have been searching and the only solutions I've been able to find had their last commit years ago.

I'd love an updated solution like yours would include this particular type of chart.

An example of the type of chart would be the one on the right of this image
https://www.gamerguides.com/assets/media/17/134/pokemon_usum_421_stats_left.jpg

please add candle stick chart

Hello there, i discovered a bug similar to the one in the line data where the recomposition of the bar chart will display fresh data incorrectly. Here is my data displayed monthly before i update it using a filter to show data yearly :

listOf(
     BarData(xValue=1, yValue=0.0), 
     BarData(xValue=2, yValue=0.0), 
     BarData(xValue=3, yValue=0.0), 
     BarData(xValue=4, yValue=0.0), 
     BarData(xValue=5, yValue=0.0), 
     BarData(xValue=6, yValue=0.0), 
     BarData(xValue=7, yValue=120.0), 
     BarData(xValue=8, yValue=0.0), 
     BarData(xValue=9, yValue=120.0), 
     BarData(xValue=10, yValue=0.0), 
     BarData(xValue=11, yValue=240.0), 
     BarData(xValue=12, yValue=0.0), 
     BarData(xValue=13, yValue=0.0), 
     BarData(xValue=14, yValue=0.0), 
     BarData(xValue=15, yValue=0.0), 
     BarData(xValue=16, yValue=0.0), 
     BarData(xValue=17, yValue=0.0), 
     BarData(xValue=18, yValue=0.0), 
     BarData(xValue=19, yValue=0.0), 
     BarData(xValue=20, yValue=0.0), 
     BarData(xValue=21, yValue=240.0), 
     BarData(xValue=22, yValue=0.0), 
     BarData(xValue=23, yValue=0.0), 
     BarData(xValue=24, yValue=0.0), 
     BarData(xValue=25, yValue=480.0), 
     BarData(xValue=26, yValue=0.0), 
     BarData(xValue=27, yValue=0.0), 
     BarData(xValue=28, yValue=0.0), 
     BarData(xValue=29, yValue=0.0), 
     BarData(xValue=30, yValue=0.0), 
     BarData(xValue=31, yValue=0.0)
)

And this is my data after updating it to display yearly :

listOf(
   BarData(xValue=1, yValue=0.0), 
   BarData(xValue=2, yValue=0.0), 
   BarData(xValue=3, yValue=0.0), 
   BarData(xValue=4, yValue=0.0), 
   BarData(xValue=5, yValue=0.0), 
   BarData(xValue=6, yValue=0.0), 
   BarData(xValue=7, yValue=0.0), 
   BarData(xValue=8, yValue=0.0), 
   BarData(xValue=9, yValue=0.0), 
   BarData(xValue=10, yValue=600.0), 
   BarData(xValue=11, yValue=120.0), 
   BarData(xValue=12, yValue=1200.0)
)

I would love to know if this is a usage error from my part or is it a bug in the library itself

For now we are able to create line charts with single line representing the data in it.
Something like this ->

It would be really beneficial to have multiple lines in a single line graph. Most mobile apps require this in order to display a comparative analysis of data to the user.

Example graph ->

(this image is taken from internet just to demonstrate the requirement)

I am using CurveLineChart to display some data.

Here is the code that displays the chart

CurveLineChart(
    modifier = Modifier
        .fillMaxWidth()
        .padding(vertical = 10.dp),
    lineData = lineData,
    chartColors = listOf(
        MaterialTheme.colors.secondary,
        MaterialTheme.colors.secondary
    ),
    lineColors = listOf(
        MaterialTheme.colors.primary,
        MaterialTheme.colors.primary
    )
)
// Where lineData is
// [LineData(xValue=Oct 27, 2022, yValue=0.0), LineData(xValue=Oct 28, 2022, yValue=0.0), ......]
// the other values have yValue equals to 0

When I run the app, I have the following stacktrace

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.ola.myapp, PID: 7867
    java.lang.IllegalArgumentException
        at android.graphics.LinearGradient.nativeCreate(Native Method)
        at android.graphics.LinearGradient.createNativeInstance(LinearGradient.java:158)
        at android.graphics.Shader.getNativeInstance(Shader.java:191)
        at android.graphics.Paint.getNativeInstance(Paint.java:726)
        at android.graphics.BaseRecordingCanvas.drawPath(BaseRecordingCanvas.java:292)
        at androidx.compose.ui.graphics.AndroidCanvas.drawPath(AndroidCanvas.android.kt:242)
        at androidx.compose.ui.graphics.drawscope.CanvasDrawScope.drawPath-GBMwjPU(CanvasDrawScope.kt:473)
        at androidx.compose.ui.node.LayoutNodeDrawScope.drawPath-GBMwjPU(Unknown Source:26)
        at androidx.compose.ui.graphics.drawscope.DrawScope.drawPath-GBMwjPU$default(DrawScope.kt:800)
        at com.himanshoe.charty.line.CurveLineChartKt$CurveLineChart$5.invoke(CurveLineChart.kt:187)
        at com.himanshoe.charty.line.CurveLineChartKt$CurveLineChart$5.invoke(CurveLineChart.kt:112)
        at androidx.compose.ui.draw.DrawBackgroundModifier.draw(DrawModifier.kt:104)
        at androidx.compose.ui.node.DrawEntity.draw(DrawEntity.kt:98)
        at androidx.compose.ui.node.LayoutNodeDrawScope.drawContent(LayoutNodeDrawScope.kt:46)
        at androidx.compose.ui.draw.DrawBackgroundModifier.draw(DrawModifier.kt:105)
        at androidx.compose.ui.node.DrawEntity.draw(DrawEntity.kt:98)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:316)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:139)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:139)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:139)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:139)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.ModifiedLayoutNode.performDraw(ModifiedLayoutNode.kt:139)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.draw(LayoutNodeWrapper.kt:306)
        at androidx.compose.ui.node.LayoutNode.draw$ui_release(LayoutNode.kt:839)
        at androidx.compose.ui.node.InnerPlaceable.performDraw(InnerPlaceable.kt:90)
        at androidx.compose.ui.node.LayoutNodeWrapper.drawContainedDrawModifiers(LayoutNodeWrapper.kt:314)
        at androidx.compose.ui.node.LayoutNodeWrapper.access$drawContainedDrawModifiers(LayoutNodeWrapper.kt:60)
        at androidx.compose.ui.node.LayoutNodeWrapper$invoke$1.invoke(LayoutNodeWrapper.kt:336)
        at androidx.compose.ui.node.LayoutNodeWrapper$invoke$1.invoke(LayoutNodeWrapper.kt:335)
        at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2101)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:110)
        at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
        at androidx.compose.ui.node.LayoutNodeWrapper.invoke(LayoutNodeWrapper.kt:335)
        at androidx.compose.ui.node.LayoutNodeWrapper.invoke(LayoutNodeWrapper.kt:60)
        at androidx.compose.ui.platform.RenderNodeApi29.record(RenderNodeApi29.android.kt:180)

It looks like this error is related to the gradient but I get the same error even if I pass one color to the chart when using lineColor and chartColor

Thank you for submitting this wonderful project to JetpackCompose.app. It's now featured on the site and we really appreciate your contribution to the Android community!

Add demo apk link in readme file and that should be updated on each release.

When my account was compromised a spam issue was created in this repo. I sincerely apologize. Cleaning up such issues via script.

The point with max yValue is always at the top edge of the graph. Which clips the circle. It would really help a lot if you could add the functionality to set offsets (as paddings in other views) to the graph.

Thanks!

LineChart:
Please make the call to drawXLabel configurable as well as the first and last line from and back to zero, that does not correspond to any of my LineData (moveTo(0f, size.height) and path.lineTo(size.width, size.height)).

Thank you for the library.

Using a LineChart, the x and y-axis labels aren't legible on dark mode since they are in black color. The axis config colors aren't applied to them.

LineChart(
            lineData = minutesReadData,
            color = MaterialTheme.colors.primaryVariant,
            modifier = modifier
                .height(250.dp)
                .fillMaxWidth()
                .padding(vertical = 32.dp, horizontal = 32.dp),
            axisConfig = AxisConfig(
                showAxis = true,
                isAxisDashed = false,
                showUnitLabels = true,
                showXLabels = true,
                xAxisColor = Color.White,
                yAxisColor = Color.White,
            ),
        )

On Light Mode:

On Dark Mode:

Using a LineChart, when the dataset is updated with a large value, the recomposition results in a line being drawn out of bounds.

LineChart(
            lineData = pagesReadData,
            color = MaterialTheme.colors.primaryVariant,
            modifier = modifier
                .height(250.dp)
                .fillMaxWidth()
                .padding(32.dp),
            axisConfig = AxisConfig(
                showAxis = true,
                isAxisDashed = false,
                showUnitLabels = true,
                showXLabels = true,
                xAxisColor = MaterialTheme.colors.onSurface,
                yAxisColor = MaterialTheme.colors.onSurface,
            )
        )

Resultant:

ScreenCap:
Out of bounds.webm

Please let me know if any other data is needed.

setting to true or false animates and expands the donut, and shows the percentage text.

(Also unrelated, after the rewrite were you wanting the donut to be thinner and more ring like? I like both looks but was just curious if that was intended)

Does charty support a mix of positive and negative integer values in a HorizontalBarChart? I tried a simple horizontal bar chart with a mix of positive and negative y-axis values and the negative values were clipped in the resulting chart. Before I try any further, wanted to confirm if this is indeed a supported usecase?

Is it possible at the moment to create point-line combo chart? Something like this: Simple Linear Regression

Add ability to scroll in x-axis when there's a lot of entry to work with. Else it's everything at a place, all jam-packed.

It would be great if you also add some functionality to programmatically focus on a particular entry. e.g.: there's 100 entries and the last nth entry is focused on the startup and the user also has the ability to scroll the x-axis.

when showLabel is true in the config this error occurs I use v2.0.0-alpha01

Sample app of Charty and Kalendar having the same package name "com.himanshoe.sample", so not able to install both at the same time.

Would be great if the build was updated to produce multiplatform artifacts with compose-multiplatform

See picture below

data for this was 3,1,1. Happens with and without expandDonutOnClick enabled

It's not an issue for non donut

The x-axis does not display labels of any data type from text to numbers.

Thanks to all contributors for this library, which is very useful. If you can add support for compose-jb on the desktop, that will be nice.

When I added Charty dependence in desktop compose-jb.
implementation("com.himanshoe:charty:1.0.1")

showing this error
`Could not resolve all files for configuration ':runtimeClasspath'.

Could not resolve com.himanshoe:charty:1.0.1.
Required by:
project :
No matching variant of com.himanshoe:charty:1.0.1 was found. The consumer was configured to find a runtime of a library compatible with Java 18, packaged as a jar, preferably optimized for standard JVMs, and its dependencies declared externally, as well as attribute 'org.jetbrains.kotlin.platform.type' with value 'jvm' but:
- Variant 'releaseVariantReleaseApiPublication' capability com.himanshoe:charty:1.0.1 declares a library, and its dependencies declared externally:
- Incompatible because this component declares an API of a component, with the library elements 'aar' and the consumer needed a runtime of a component, packaged as a jar
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
- Doesn't say anything about its target Java version (required compatibility with Java 18)
- Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'jvm')
- Variant 'releaseVariantReleaseRuntimePublication' capability com.himanshoe:charty:1.0.1 declares a runtime of a library, and its dependencies declared externally:
- Incompatible because this component declares a component, with the library elements 'aar' and the consumer needed a component, packaged as a jar
- Other compatible attributes:
- Doesn't say anything about its target Java environment (preferred optimized for standard JVMs)
- Doesn't say anything about its target Java version (required compatibility with Java 18)
- Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'jvm')`

My build.gradle.kts
`
import org.jetbrains.compose.desktop.application.dsl.TargetFormat
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
kotlin("jvm")
id("org.jetbrains.compose")
}

repositories {
google()
mavenCentral()
maven("https://maven.pkg.jetbrains.space/public/p/compose/dev")
}

dependencies {
testImplementation(kotlin("test"))
implementation(compose.desktop.currentOs)
implementation("com.himanshoe:charty:1.0.1")
}

tasks.test {
useJUnitPlatform()
}

tasks.withType {
kotlinOptions.jvmTarget = JavaVersion.VERSION_18.toString()
}

compose.desktop {
application {
mainClass = "MainKt"
nativeDistributions {
includeAllModules = true
targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
packageName = projectName
packageVersion = projectVersion
}
}
}

`