hi-ray / infinityedge Goto Github PK

Describe the bug
After the last changes to infinite edge, it is slow too run, and has several console errors with the .svg, .webm, .jpg files, it seems that some addresses in the program are wrong and makes INFINITE EDGE try those addresses when they are badly structured.

Here is the case that i explain. It seems that the first case is the ERROR in the console, and below is the successful download without errors with the proper address.

This is a example for soul fighter event:

Here is example of somes .webm files errors in console:

/landing-button-video-left.webm --> this is link address in the tool that do error in the console
_/lib-embed/videos/landing-button-video-left.1158f6.webm --> This is the link that seems to be correct.

Here is example of somes .svg files errors in console:

and .jpg, .png files usually happens too, not in many cases, but it usually happens in someones.

Obviously this means that if you do the first few cases and these errors appear in the console, these attempts are wasted time, so you should only download the .webm files with the appropriate address, so as not to cause these errors and waste of time.

I hope it can be fixed soon.

thx!

Describe the bug
Practically when infinite finds the events for download, only the LOL events appear in the console, not the event that is currently active at: https://clientconfig.rpg.riotgames.com/api/v1/config/public?namespace=lol.client_settings.tft with the URL: https://embed.rgpub.io/wwpub-tft-soul-fighter-embed-2023/{bcplocale}/

To Reproduce
Steps to reproduce the behaviour:

1. Ejecute Infinite Edge

Expected behaviour
That in addition to the LOL events, you can download the TFT event or events correctly.

Screenshots
there's no need

Desktop (please complete the following information):

• OS: Win
• Version 10

Describe the feature
From: https://embed.rgpub.io/mgs-soul-fighter-2023/en-us

Riot has added a new metagame with a lot of assets, very similar to the sentinels of light event, where there is a story mode with sprints, text among other important assets that really from what I have investigated are not located in the event address as normal events that assets are located in the typical app.js or dist.js.

From what I have verified to be unity, in an address:

• https://embed.rgpub.io/mgs-soul-fighter-2023/webgl/StreamingAssets/aa/catalog.json

Which here are mostly the assets of the different characters, maps, location, among others, obviously the full address is not really there, but from what I have been able to verify the URL from where it starts for the assets is:

• https://embed.rgpub.io/mgs-soul-fighter-2023/webgl/StreamingAssets/aa/

If we accompany for example: /WebGL/motioncomics_assets_motioncomic_soulfighter_intro_651b7bba461d66ebde947f9c8fb0a69f.bundle

and we get: https://embed.rgpub.io/mgs-soul-fighter-2023/webgl/StreamingAssets/aa//WebGL/motioncomics_assets_motioncomic_soulfighter_intro_651b7bba461d66ebde947f9c8fb0a69f.bundle

to the previous address, we will download the unity file where it contains several assets, I don't know if you can add this type of events for download to this tool, I have given the information that I have researched, I hope it will be useful.

Describe the bug
Run infinity edge and fail to download some event assets.
logs.txt

I only attached the files that it does not download.

Describe the bug
when you run infinitedge it only downloads assets from the riot client (lor, lol, valorant etc...) but it doesn't download the available events... (now its UP milio assets)

To Reproduce
Steps to reproduce the behaviour:

1. run the tool

Expected behaviour
download the availables events assets

Screenshots

Desktop (please complete the following information):

• OS: win 10

Describe the bug
It seems that when you run infinite, it shows up in the console, download failed eg:
2023-07-21T21:18:12+0200 <warn> index.js:75 (downloadFiles) Failed to download /_generated/sprite-pre-default.jpg

When I assume it will be creating the folder WITHOUT the file this could be the BUG I posted earlier: #12

To Reproduce
Steps to reproduce the behaviour:

1. Run infinite

Expected behaviour
Be efficient and fast for the user.

Screenshots
I show a part of the console so you can understand it, I don't really know if it is, but from what I understand, it's failing to download, but still, then it tries again and finally those files are downloaded. This could imply more time than infinite actually takes to download the assets.

2023-07-21T21:18:11+0200 <info> index.js:54 (downloadFiles) Attempting to download /_generated/sprite-pre-default.jpg
2023-07-21T21:18:11+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/_generated/sprite-pre-default.jpg
2023-07-21T21:18:12+0200 <warn> index.js:75 (downloadFiles) Failed to download /_generated/sprite-pre-default.jpg
2023-07-21T21:18:12+0200 <info> index.js:54 (downloadFiles) Attempting to download /abilities-showcase-decor.jpg
2023-07-21T21:18:13+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/abilities-showcase-decor.jpg
2023-07-21T21:18:14+0200 <warn> index.js:75 (downloadFiles) Failed to download /abilities-showcase-decor.jpg
2023-07-21T21:18:14+0200 <info> index.js:54 (downloadFiles) Attempting to download /bg-default.jpg
2023-07-21T21:18:14+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/bg-default.jpg
2023-07-21T21:18:15+0200 <warn> index.js:75 (downloadFiles) Failed to download /bg-default.jpg
2023-07-21T21:18:15+0200 <info> index.js:54 (downloadFiles) Attempting to download /bg-index-samira.jpg
2023-07-21T21:18:16+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/bg-index-samira.jpg
2023-07-21T21:18:17+0200 <warn> index.js:75 (downloadFiles) Failed to download /bg-index-samira.jpg
2023-07-21T21:18:17+0200 <info> index.js:54 (downloadFiles) Attempting to download /bg-index-viego.jpg
2023-07-21T21:18:17+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/bg-index-viego.jpg
2023-07-21T21:18:18+0200 <warn> index.js:75 (downloadFiles) Failed to download /bg-index-viego.jpg
2023-07-21T21:18:18+0200 <info> index.js:54 (downloadFiles) Attempting to download /bg-intro.jpg
2023-07-21T21:18:19+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/bg-intro.jpg
2023-07-21T21:18:20+0200 <warn> index.js:75 (downloadFiles) Failed to download /bg-intro.jpg
2023-07-21T21:18:20+0200 <info> index.js:54 (downloadFiles) Attempting to download /card-cinematic.jpg
2023-07-21T21:18:20+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/card-cinematic.jpg
2023-07-21T21:18:21+0200 <warn> index.js:75 (downloadFiles) Failed to download /card-cinematic.jpg
2023-07-21T21:18:21+0200 <info> index.js:54 (downloadFiles) Attempting to download /card-new-mode.jpg
2023-07-21T21:18:22+0200 <info> index.js:70 (downloadFiles) Attempting to download https://assetcdn.rgpub.io/public/live/bundle-offload/7df87236-402e-487a-9b60-e3016ad27fe4/64b9a8e6fcae86000882534e/_/lib-embed/images/card-new-mode.jpg

Desktop (please complete the following information):

• OS: Windows 10

Describe the feature
From here --> https://embed.rgpub.io/wwpub-lol-august-event-embed-2023/en-us

are in 2 formats: ogg and m4a, i think the best format is: .ogg

Describe the bug
For example, in the new soul fighter event, infinite edge downloads all the assets of the event but it seems that it doesn't know if there could be duplicate assets, since Riot on the page from what I've seen there are duplicate assets that are the same image but something changes the name of the asset. I will attach an image so that it is understood.

To Reproduce
Steps to reproduce the behaviour:

1. Run infinite

Expected behaviour
Don't download duplicate assets.

Screenshots
Added.

For example, in this image, where you can see the name for example: bg-index-samira.6a5d94 there are two bg-index-samira but in the end the final part changes, so infinite is downloading this, having 2 duplicate assets and they are the same.

There are several cases, in _generated, in the root folder as seen in the image.

Desktop (please complete the following information):

• OS: Windows
• Version: 10

Describe the bug
Cannot downloads but find it the new event faerie (event logs attach) It downloads the riot client and milio files, but not the new one.

To Reproduce
Steps to reproduce the behaviour:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behaviour
Must be download the assets of the new event

Screenshots

2023-03-23T21:14:14+0100 <info> scraper.js:136 () Found LOL event: milio-embed-2023
2023-03-23T21:14:14+0100 <info> scraper.js:136 () Found LOL event: merch
2023-03-23T21:14:14+0100 <info> index.js:33 (main) Found 3 potential current events.
2023-03-23T21:14:14+0100 <info> index.js:36 (main) Downloading event: milio-embed-2023
2023-03-23T21:14:14+0100 <info> index.js:138 (handle) Found 0 potential files.
2023-03-23T21:14:14+0100 <info> finder.js:27 (findFiles) Found 0 potential assets files.
2023-03-23T21:14:14+0100 <info> finder.js:65 (findSvgs) Found 1 SVGs.
2023-03-23T21:14:14+0100 <info> index.js:36 (main) Downloading event: milio-embed-2023
2023-03-23T21:14:15+0100 <info> index.js:138 (handle) Found 0 potential files.
2023-03-23T21:14:15+0100 <info> finder.js:27 (findFiles) Found 0 potential assets files.
2023-03-23T21:14:15+0100 <info> finder.js:65 (findSvgs) Found 0 SVGs.
2023-03-23T21:14:15+0100 <info> index.js:36 (main) Downloading event: milio-embed-2023
2023-03-23T21:14:15+0100 <info> index.js:138 (handle) Found 96 potential files.
2023-03-23T21:14:15+0100 <info> finder.js:27 (findFiles) Found 50 potential assets files.
2023-03-23T21:14:15+0100 <info> finder.js:65 (findSvgs) Found 18 SVGs.

Desktop (please complete the following information):

• OS: win 10

Describe the bug + Suggestion
From what I see, it doesn't seem to download anything from the AU "Cupcakes 4 Heartaches" event (test).
In addition, it does not find the event (lunar) currently, in the previous version it downloaded the assets without problems. However, in "AU" there is the lunar event and it still does not download it. Below, I propose an idea of if it could be done.

On the other hand, I don't know if changing "lc_home_en_US.json" to "lc_home_en_AU.json" will affect the arrival and detection of events in one region to another. I don't know if there will be an opportunity to do one thing in the tool:

• If there is any new event in "lc_home_en_AU.json" that is not in "lc_home_en_US.json" download it and then re-download the existing ones in the main "US"
• On the other hand, I don't know if this is a bug, but I'll explain. When downloading assets from riot client I put an example here:
  https://lol.secure.dyn.riotcdn.net/channels/public/rccontent/theme/manifest_default.json, there are other types of assets that should be downloaded such as: the videos found in that .json, there are also other images like the uncut full splash art that doesn't download "splash-assets/Product_Details_Background_2023.jpg", I'll attach an image.

Infinite seems to prioritize the download of the first images and not the videos and the following images from "game_library" "product_details" as I said, the first image is the same but it is the cut image. The other .json, the same thing happens.

To Reproduce
Steps to reproduce the behaviour:
I run the program, it detects the (AU) event but in the end it doesn't download any asset and either the LUNAR EVENT.

There is no asset inside the event? Is rare.

Expected behaviour
Find assets (someone)

Screenshots
Added.

Desktop (please complete the following information):

• OS: Windows 10

Additional context
No.

Describe the bug
When infinite creates the corresponding folders and downloads the assets I have observed that it creates in: events/lol//here
Folders that do not contain anything, which later is actually inside the "images" folder where they really are again with their respective assets.
For example, in the current soul fighter event, I show an image where it creates the _generated folder that is empty and several folders of the different champion skins of the event that are empty, but then if we enter the "images" folder they find their respective assets.

To Reproduce
Steps to reproduce the behaviour:

1. Run infinite

Expected behaviour
Don't create unnecessary folders without files.

Screenshots
Added.

Desktop (please complete the following information):

• OS: Windows
• Version: 10