hiddevdploeg / billboard Goto Github PK

providerToken (from the app) and the a campaignToken, people can attribute the installs in ASC

let config = SKOverlay.AppConfiguration(appIdentifier: advert.appStoreID, position: .bottom)
config.userDismissible = true
config.campaignToken = "CAMPAIGN_TOKEN"
config.providerToken = "PROVIDER_ID"

BillboardCountdownView renders weirdly when counting down the remaining time until the user can dismiss BillboardBannerView

based on the current documentation, it should be possible to fetch an ad via BillboardViewModel like this:

let newAdvert = try? await viewModel.fetchRandomAd()
advertisement = newAdvert

but there are two difference to what is actually implemented in code:

• fetchRandomAd needs an URL parameter
• fetchRandomAd is static

current workaround:

guard  let adsURL = BillboardConfiguration().adsJSONURL else {
    return
}

Task {
    try await BillboardViewModel.fetchRandomAd(from: adsURL)
}

a good solution would be to merge showAdvertisement and fetchRandomAd somehow. what would you say to this?

Display a label in the AdvertisementView that highlights the fact that it's an ad and it's friendly

This will allow to reset a counter on dismiss of the overlay

Hello, during development I found this issue

It seems like, looking at the frame variables that appName seems to cause the the issue

because the url cannot be constructed, as there is a space in the app name.
Of course, this would be valid for any character that is not allowed in urls.

Several apps have this issue when looking at the default list:

https://billboard-source.vercel.app/ads.json

Have a new smaller styled advertisement to display without blocking the whole view

Hi. The demo app project doesn't compile. It seems BillboardBannerView isn't present in the package on the main branch

Give the public list categories and let you only show ads from specific categories to better match your own app

Not sure of the use case that makes it internal only, but I'd rather have at least one public option to initialize one and keep it around in my own views

Force unwrapping is the issue :(

Great work on the package. I was wondering if visionOS support would be possible, as I think it should be as easy as disabling all haptic feedback (as that isn't available on visionOS). TIA!

Primarily macOS but watchOS would be 🔥

When tapping the BillboardBannerView, the whole view should be tappable. Instead, currently only the image and text content is tappable.