hideakitai / arxsmartptr Goto Github PK

Hello,

Super appreciate someone taking the time to port over the shared_ptr construct into Arduino space. Want to first just say a big THANK YOU for doing this - it's been needed for some time.

As I'm working with trying to replicate some of the more common dev environments we find in more modern languages, mixing SimpleCollections and SharedPointers seems like a no-brainer.

Anyways, the declaration is:

tccollection::BtreeList<String, arx::stdx::shared_ptr<BaseObject>> _objects;

And error is:

the object has type qualifiers that are not compatible with the member function "tccollection::BtreeList<K, V>::getByKey [with K=String, V=arx::stdx::shared_ptr<BaseObject>]"C/C++(1086)
BaseObject.cpp(488, 25): object type is: const tccollection::BtreeList<String, arx::stdx::shared_ptr<BaseObject>>

Seems that the function from SimpleCollections, for this getByKey method is as follows:

V *getByKey(K key) { return reinterpret_cast<V *>(treeStorage.getByKey(key)); };

(Template type V is value type, K is key type)

So I believe the issue is that because it's trying to reinterpret_cast< shared_ptr * > it's basically failing out.

I noticed that you have reinterpret_pointer_cast (and static, dynamic, etc) that is used instead, and I think that is where this is originating from.

I can also open this issue up on SimpleCollections but I figured I would start with shared_ptrs since it's definitely a more complex case.

I thought this lib had unique pointer? Does it not?