hiulit / delaunator-gdscript Goto Github PK

Great script - thanks!

I noticed that you only mentioned the variable types as comment instead of using static typing:

I wonder whether you could increase the script performance by switching to static typing?

var coords : PoolRealArray = []
...

Even if the performance would not be affected, it would increase readability and has some other advantages, too.

Godot4 array api has changed a lot, and the meaning of end param in slice method has changed, which is the inclusive index previously and now is the exclusive index, same as the original javascript lib.

In this case, line 295-296 should be

    triangles = _triangles.slice(0, triangles_len)
    halfedges = _halfedges.slice(0, triangles_len)

otherwise you will got a non-3-multiply length array .triangles, which is invild.

could instead just be

hull = []

Thank you! This is excellent work!

I was having trouble getting the code to run in the Godot 4 alpha, and since it's not reasonable to start a new issue for that, I was hoping to see what else I could do! The link currently takes me to a 404 page