Giter VIP home page Giter VIP logo

Comments (10)

DavidGutknecht avatar DavidGutknecht commented on September 17, 2024

Hello Michaela,

I'm really not an expert in slicing, but did you try with a different kind of discriminator like ?

<discriminator>
	<type value="value"/>
        <path value="system"/>
</discriminator>
<discriminator>
        <type value="value"/>
        <path value="code"/>
</discriminator>

Best regards,
David

from ch-core.

ziegm avatar ziegm commented on September 17, 2024

Dear David

Thanks for your input.

image

You can see from the example of the Patient.identifier that the discriminator should be pattern, because the identifier:LocalPid is built differently than the others.

Best regards,
Michaela

from ch-core.

DavidGutknecht avatar DavidGutknecht commented on September 17, 2024

Thanks for the explanation !

Just another supposition.
LocalPid has cardinality 0..*
But the pattern identifier is fix
grafik

This would mean that the system will not be able to distinguish between two LocalPid.
You should somehow also include the system and the value or ?

Best regards,
David

from ch-core.

oliveregger avatar oliveregger commented on September 17, 2024

System and value are set to 1 for identifier:LocalPID, so you can distinguish between different LocalPID's according to system. The slice however identifies all localPID's together, thats intended.

The origin of this issue is that the html representation in the implementation guide is not correct, the snaphshot which is generated however is correct.

from ch-core.

DavidGutknecht avatar DavidGutknecht commented on September 17, 2024

Hello,
just as information, I solved this duplicate on my side by doing as following:
For example line 199
If you remove the patternIdentifier

 <patternIdentifier>
                <type>
                    <coding>
                        <system value="http://terminology.hl7.org/CodeSystem/v2-0203" />
                        <code value="MR" />
                    </coding>
                </type>
            </patternIdentifier>

And if you fix the "system" and the "code" in separated elements:

		<element id="Patient.identifier:LocalPid.type.coding.system">
			<path value="Patient.identifier.type.coding.system" />
			<fixedUri value="http://terminology.hl7.org/CodeSystem/v2-0203"/>
		</element>
		<element id="Patient.identifier:LocalPid.type.coding.code">
			<path value="Patient.identifier.type.coding.code" />
			<fixedCode value="MR"/>
		</element>

It should do the Trick, and nomore duplicate in the html the "system" part.
I'm not sure that the signification is the same. But from the look and feel point of view it looks ok ;-)

Best regards,
David

from ch-core.

oliveregger avatar oliveregger commented on September 17, 2024

we need to use the patternIdentifier otherwise the slicing will not work with the different identifier usecases. can you validate with your setup all the examples?

from ch-core.

DavidGutknecht avatar DavidGutknecht commented on September 17, 2024

You are right, after validating throw the examples I got some errors :-(
Sorry for the disturbing.

from ch-core.

ziegm avatar ziegm commented on September 17, 2024

Added question in zulip: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Duplicated.20element.20in.20snapshot.20when.20using.20slicing

from ch-core.

ziegm avatar ziegm commented on September 17, 2024

Changes:

from ch-core.

oliveregger avatar oliveregger commented on September 17, 2024

Telco vom 1.3: 12 - 0 - 0

from ch-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.