hlavacs / viennavulkanengine Goto Github PK

in VulkanEngine\VESceneManager.cpp line 930
develop branch

after i used key "1" without creating an event listener for that key

There exists function VEWindow::windowShouldClose() that is not actually used in the VEEngine class and can't be used by the derived classes because of its protected modifier. Proposed solutions:

1. Make VEWindow::windowShouldClose() public. Not the best option, because this way condition could be checked only during processing of some other event (e.g. VE_EVENT_FRAME_STARTED)
2. Create new event type that fires when VEWindow::windowShouldClose() becomes true.

Is there any specific reason why you've decided to cast duration to milliseconds instead of directly returning time_span in this function?

float vhTimeDuration(std::chrono::high_resolution_clock::time_point t_prev) {
	std::chrono::duration<double> time_span =
		std::chrono::duration_cast<std::chrono::duration<double>>(vhTimeNow() - t_prev);
	return std::chrono::duration_cast<std::chrono::milliseconds>(time_span).count() / 1000.0f;
}

This function is used to calculate dt for events and I would assume that clock resolution of 1 millisecond is not good enough, which is quite noticeable in cases when frame time is 1-2 ms, because truncation error can be as high as 50% in those cases.