Giter VIP home page Giter VIP logo

arbitragetrackerv2's People

Contributors

hmprt avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

arbitragetrackerv2's Issues

something wrong with the pairlist remove logic

There is something wrong:
if (int(pairAddress[2:], 16) == 0):
print("Removed " + pair.name + ": no exchange")
pairsList.remove(pair)
continue
the pair generated by combinations is:
++++++++++++++++++++
DAI USDT
DAI LINK
DAI USDC
DAI WETH
DAI sUSD
USDT LINK
USDT USDC
USDT WETH
USDT sUSD
LINK USDC
LINK WETH
LINK sUSD
USDC WETH
USDC sUSD
WETH sUSD
++++++++++++++++++++

when access pair after remove operation:
say,
uniswapV2 = self.w3.eth.contract(address=pair.exchanges['Uniswap']['address'],
we get a KeyError: 'Uniswap'

Suggestion:

    if (int(pairAddress[2:], 16) == 0):
        print("Removed " + pair.name + ": no exchange")
        # pairsList.remove(pair)
        # continue
        removePair.append(pair)


    if (ABI.find("Contract source code not verified") > -1):
        print("Contract source code not verified! \n Try https://etherscan.io/address/" + pairAddress)
        # removePair.append(pair)
        continue

before return:
_list = list(set(removePair))
removePair = _list
for rePair in removePair:
pairsList.remove(rePair)

It seems to work for me

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.