hng-teamfury / team-fury-1 Goto Github PK

View Code? Open in Web Editor NEW

13.0 13.0 274.0 1.23 MB

PHP 20.23% CSS 2.79% JavaScript 58.78% Python 17.79% Java 0.33% Dockerfile 0.07%

team-fury-1's People

Contributors

Stargazers

Watchers

Forkers

sniffedpcs adiomojeed beardless-sheik kay-ai noble-47 idss15 bram24 omyasobie oelun-in ifihan akiinrinde ajaodolapo1301 francisudeji kaycce 0xtimoo asimic-james dave-ok davonjagah zinniee roguecode007 costamay sorin-tech francisop tobey133 timothy16 sizo527 amanie-sandy smizzy01 gkarumbi benjamin-411 technelly stephenkayade imeakpan30 mercybassey tossyynne kanu-ship-it jamilumar ayopips acefestus vikhthor amuhd elvis-1 aremcx onuoha92 simply-alliv oyedeyeye g-prog mrkellard ekiminfo ruffychris ajadi473 gideonbusayo ijequay-wisdom yediran mutiyah mustafa-aisha marvvy-g sammyebinne tonyouma okeydibia doncity-tech forte001 alimisulaimon1 odofing 3kingz nwosu-ihueze alxzndr2019 aigberua121 toyyib06 ekaji christie-code samliks themobolaakins nasrullahiolamide babafemi99 faithmo naomianthony kikwen01 tonyngeno abuh05 qobitech abdul-barri mikailjunor abiiagarin mayowa09 emedee tolu31 codessage phoxtrot ismailmuhammed2019 adekniyi dro-1 jebitok-dev thebolarin funshi ekpenyongmike malgwi iambuksman gyrationtechs ghaalib99

team-fury-1's Issues

Trouble comparing the output from the scripts to the expected output

`<?php
$names = array();
$key_words = "Hello World, this is with HNGi7 ID using language for stage 2 task";

foreach(glob("scripts/*.js") as $filename){
    $output = exec("node $filename");
	echo $output;
	echo $key_words;
    if(preg_match('/{$key_words}/i', $output)){
       echo "pass";
       echo "<br>";
    }else{
       echo "fail";
       echo "<br>";
    }
    array_push($names, $filename);
}
foreach(glob("scripts/*.php") as $filename){
    $output = shell_exec("node $filename");
    echo($output);
    echo "<br>";
    array_push($names, $filename);
}
foreach(glob("scripts/*.py") as $filename){
    $output = shell_exec("./$filename");
    array_push($names, $filename);
}

echo "All files in the scripts directory are: ";
foreach($names as $name){
    print_r($name);
    echo "<br>";
}
?>
`

Creating Server to run script and also to watchout for new commits

I have created a server that is currently running on aws and it runs the scripts for php, python, and also nodejs...now I would like to make it watch for each commit that is been done so as to have a straight and effect server for the display of output for each commit.

Thank you.

Ideas for the next tasks

Stage 2

Slack Link

Designers

Slack Link

Mobile

Slack Link

Frontend

Slack Link

Backend

Slack Link

All Python Scripts not working

All the .py scripts are not working on http://209.151.156.206/team-fury/
please check it out. Not even 1 is working

Python Scripts not working on my xampp.

Someone please help me look at this code:

6c70e10

Live server edit

The names of the old team leads is what shows on our live server. Someone please look into it and change it.

Possible improvements

Ensure Language in script and file type are the same
If the intern chooses Python as his main language for stage 2 then he should use a python file etc..

JSON output fails validation

One wrong entry is making our JSON fail and we need to fix it rapidly!

file: ./scripts/NwaiwuVictoria.php

Please let's find Victoria and help them resubmit!

KISS Principle

Email Regex in Output

The parser.php $regex includes the email and mark has instructed we leave our email out of the output....it should only be one of the variables in our script.....
Can this issue be addressed?

Implement frontend ui

Many of us are separately working on a UI version, this issue is to help merge our efforts to go with the backend in #22

Please review work so far and discuss with @Adiomojeed in #2 for all frontend ideas.

You can mention your PRs here if any or move all discussions to #2

Thank you!

Remove email from regex

The assignment doesn't require us to output our email. And as it stands those who will not provide it will get a fail.

Merging PRs of Scripts Team

This issue is responsible for ensuring that all open PRs for scripts are closed before the deadline. The review team should coordinate with us to increase our productivity. Will communicate with them on that.

@Peacepac Please deal with the PRs from page 1
@johnsani Please deal with the PRs from page 2
@maroafenogho Please deal with the PRs from page 3
@Francisop Please deal with the PRs from page 4

Update

We will now be reviewing and merging the PRs.

Add a label "under review" when you start working on a PR.
Check the base branch is dev if not, edit the title and change to dev branch before merging..
Do not merge too many files
If you find errors, please add to the Invalid Scripts file.

israel

var text="hello world,Am ";
var fullname="Israel ";
var word="from ";
var company="HNGi7 ";
var id="HNG-04195 ";
var text1="using ";
var language="javascript language ";
var stage="for stage 2 task email is,";
var email="[email protected]";
console.log(text+fullname+word+company+id+text1+language+stage+email);

Ideas for Designers

Implement server side code to exec all scripts and return pass or fail

Run exec on all files in ./scripts and read results
Compare each result with expected output
Output pass if result match expected or fail otherwise

Example JSON output

{
  "file": "myScript.py",
  "output": "Hello World, this is Olagesin Samuel with HNGi7 ID HNG-04817 using Python for stage 2 task",
  "name": "Olagesin Samuel",
  "id": "HNG-04817",
  "email": "[email protected]",
  "language": "Python",
  "status": "Pass"
}

Example HTML output

<table>
  <tr>
    <th>file</th>
    <th>output</th>
    <th>name</th>
    <th>id</th>
    <th>email</th>
    <th>language</th>
    <th>status</th>
  </tr>
  <tr>
    <td>myScript.py</td>
    <td>Hello World, this is Olagesin Samuel with HNGi7 ID HNG-04817 using Python for stage 2 task</td>
    <td>Olagesin Samuel</td>
    <td>HNG-04817</td>
    <td>[email protected]</td>
    <td>Python</td>
    <td>Pass</td>
  </tr>
</table>

Improve Documentation

Great documentation, rules, and guidelines for team

Description

Since we have to work very efficiently and effectively together. One of the most important resources for great collaboration, especially for newcomers, is great documentation. Great documentation can help the team understand what needs to be done and how it should be done. It can also allow the team to remain consistent and improve productivity. This is achieved through rules and guidelines spread throughout the documentation.

Requirements

Below is a list of requirements we should do to improve our documentation. The requirements can be updated.

README.md file (contains all the instructions to get started and provides an overview of what the project is and what its main counterparts (e.g. backend) are).
CONTRIBUTING.md file (contains all the instructions for contributing to the project)
CODE_OF_CONDUCT.md file (contains all the instructions on how we should conduct ourselves when interacting with any team member)
STYLE_GUIDE.md file (contains all the instructions on how code should be styled to maintain consistency between all team members)